On Thu, 2019-05-23 at 22:07 +0200, Sebastian Reichel wrote:
This macro is only used by omapdrm, which should print debug messages using the DRIVER category instead of the default CORE category.
[]
diff --git a/drivers/gpu/drm/omapdrm/omap_drv.h b/drivers/gpu/drm/omapdrm/omap_drv.h
[]
@@ -37,8 +37,8 @@ #include "omap_irq.h" #include "omap_plane.h"
-#define DBG(fmt, ...) DRM_DEBUG(fmt"\n", ##__VA_ARGS__) -#define VERB(fmt, ...) if (0) DRM_DEBUG(fmt, ##__VA_ARGS__) /* verbose debug */ +#define DBG(fmt, ...) DRM_DEBUG_DRIVER(fmt"\n", ##__VA_ARGS__) +#define VERB(fmt, ...) if (0) DRM_DEBUG_DRIVER(fmt, ##__VA_ARGS__) /* verbose debug */
Trivia:
Strictly, this should use do { if (0) etc... } while (0)
Also, none of the VERB uses have a terminating newline so ideally, this should be:
#define VERB(fmt, ...) do { if (0) DRM_DEBUG_DRIVER(fmt "\n", ##__VA_ARGS__); } while (0) /* verbose debug */
And VERB isn't a particularly intelligible macro name. Maybe VDBG instead.