Hey,
Op 14-01-13 06:25, Ben Skeggs schreef:
On Fri, 2013-01-11 at 16:04 +0100, Maarten Lankhorst wrote:
When a specific engine is needed that's not GR, struct nve0_fifo should be used, and the engine member should be used to select the engine.
This will fail on kernels before 3.8, since no support for such engines has been added yet.
This looks strikingly similar to the version of the patch I sent you ages back. Was there something you noticed wrong with that version?
I think you forgot to send that patch to me, I remember you sending me the mesa changes, but not the libdrm diff. :)
I do need to re-check some things with that patch and make sure it'll work properly on both 32/64-bit (hint: sizeof(struct nve0_fifo) is the same as nvc0_fifo on 64-bit, due to padding...), and maintain compat with pre-3.8 kernels.
This should not be the case with the patch I wrote. Since I encapsulate the original nvc0_fifo struct as base, the size should be different.
I'll try and sort this out before the end of tomorrow.
Ben.
Sure, np. Just wanted to see if I could get the mesa changes in before 9.1 branching off. :)
~Maarten