Quoting Laurent Pinchart (2021-10-06 18:17:25)
Hi Stephen,
Thank you for the patch.
On Wed, Oct 06, 2021 at 12:37:46PM -0700, Stephen Boyd wrote:
Replace 'struct master' with 'struct aggregate_device' and then rename 'master' to 'adev' everywhere in the code. While we're here, put a struct device inside the aggregate device so that we can register it with a bus_type in the next patch.
Not "while at it" please. The signal to noise ratio is very high here. Adding the struct device in the structure is the important change that needs to be properly reviewed and discussed, the rename is noise. You're even adding an IDA and an id without mentioning it at all in the commit message. This should be split in two patches, you can decide whether to perform the rename at the bottom or top of the series (it would be more logical to group all renames together though, there's currently one in 01/34 and one in 34/34, so please group them both at the top or bottom).
Got it. I will split the rename from this change and let things lie until I change that line.