[Removed stable-kernel from Cc]
At Fri, 11 Mar 2011 02:35:45 +0100 (CET), Indan Zupancic wrote:
drm/i915: Fix DPMS and suspend interaction for intel_panel.c
When suspending intel_panel_disable_backlight() is never called, but intel_panel_enable_backlight() is called at resume. With the effect that if the brightness was ever changed after screen blanking, the wrong brightness gets restored at resume time.
Nothing guarantees that those calls will be balanced, so having backlight_enabled makes no sense, as the real state can change without the panel code noticing. So keep things as stateless as possible.
Signed-off-by: Indan Zupancic indan@nul.nu
Indan, when you need a patch to be added to stable kernel, just put Cc to stable kernel around your sign-off line. Then Greg will pick it up automatically once when the patch is merged to Linus tree.
Anyway, the patch looks good to me. A nice clean-up.
Reviewed-by: Takashi Iwai tiwai@suse.de
thanks,
Takashi