Hi,

On Tue, Mar 23, 2021 at 05:34:53PM +0800, Yang Li wrote:

fixed the following coccicheck: ./drivers/gpu/drm/omapdrm/dss/dsi.c:4329:7-27: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT

Reported-by: Abaci Robot abaci@linux.alibaba.com Signed-off-by: Yang Li yang.lee@linux.alibaba.com

---

Reviewed-by: Sebastian Reichel sebastian.reichel@collabora.com

Also maybe add this, so that it is properly backported. OTOH old code did not have IRQF_ONESHOT either.

Fixes: 4c1b935fea54 ("drm/omap: dsi: move TE GPIO handling into core")

-- Sebastian

Change in v2: -Modify the fourth parameter, not the first

drivers/gpu/drm/omapdrm/dss/dsi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c index b31d750..5f1722b 100644 --- a/drivers/gpu/drm/omapdrm/dss/dsi.c +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c @@ -4327,7 +4327,8 @@ static int omap_dsi_register_te_irq(struct dsi_data *dsi, irq_set_status_flags(te_irq, IRQ_NOAUTOEN);

err = request_threaded_irq(te_irq, NULL, omap_dsi_te_irq_handler,

• 		   IRQF_TRIGGER_RISING, "TE", dsi);
  

• 		   IRQF_TRIGGER_RISING | IRQF_ONESHOT,
  

• 		   "TE", dsi);
  

  if (err) { dev_err(dsi->dev, "request irq failed with %d\n", err); gpiod_put(dsi->te_gpio);

-- 1.8.3.1

---

dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel