With patch http://patchwork.freedesktop.org/patch/msgid/1455106118-32145-1-git-send-ema... i2c slave encoder drivers no longer need to implement dummy mode_fixup function.
This patch set nukes the dummy functions from i2c slave encoder drivers.
(changes made on top of Daniel Vetter topic/drm-misc branch)
Changes v1->v2: Added proper cover letter to patch 0.
Carlos Palminha (2): drm/i2c/sil164: removed unnecessary code, mode_fixup is now optional. drm/i2c/tda998x: removed unnecessary code, mode_fixup is now optional.
drivers/gpu/drm/i2c/sil164_drv.c | 9 --------- drivers/gpu/drm/i2c/tda998x_drv.c | 9 --------- 2 files changed, 18 deletions(-)
Removed dummy mode_fixup.
Signed-off-by: Carlos Palminha palminha@synopsys.com --- drivers/gpu/drm/i2c/sil164_drv.c | 9 --------- 1 file changed, 9 deletions(-)
diff --git a/drivers/gpu/drm/i2c/sil164_drv.c b/drivers/gpu/drm/i2c/sil164_drv.c index c400428..db0b03f 100644 --- a/drivers/gpu/drm/i2c/sil164_drv.c +++ b/drivers/gpu/drm/i2c/sil164_drv.c @@ -252,14 +252,6 @@ sil164_encoder_restore(struct drm_encoder *encoder) priv->saved_slave_state); }
-static bool -sil164_encoder_mode_fixup(struct drm_encoder *encoder, - const struct drm_display_mode *mode, - struct drm_display_mode *adjusted_mode) -{ - return true; -} - static int sil164_encoder_mode_valid(struct drm_encoder *encoder, struct drm_display_mode *mode) @@ -347,7 +339,6 @@ static const struct drm_encoder_slave_funcs sil164_encoder_funcs = { .dpms = sil164_encoder_dpms, .save = sil164_encoder_save, .restore = sil164_encoder_restore, - .mode_fixup = sil164_encoder_mode_fixup, .mode_valid = sil164_encoder_mode_valid, .mode_set = sil164_encoder_mode_set, .detect = sil164_encoder_detect,
Removed dummy mode_fixup.
Signed-off-by: Carlos Palminha palminha@synopsys.com --- drivers/gpu/drm/i2c/tda998x_drv.c | 9 --------- 1 file changed, 9 deletions(-)
diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c index 34e3874..b61282d 100644 --- a/drivers/gpu/drm/i2c/tda998x_drv.c +++ b/drivers/gpu/drm/i2c/tda998x_drv.c @@ -856,14 +856,6 @@ static void tda998x_encoder_dpms(struct drm_encoder *encoder, int mode) priv->dpms = mode; }
-static bool -tda998x_encoder_mode_fixup(struct drm_encoder *encoder, - const struct drm_display_mode *mode, - struct drm_display_mode *adjusted_mode) -{ - return true; -} - static int tda998x_connector_mode_valid(struct drm_connector *connector, struct drm_display_mode *mode) { @@ -1343,7 +1335,6 @@ static void tda998x_encoder_commit(struct drm_encoder *encoder)
static const struct drm_encoder_helper_funcs tda998x_encoder_helper_funcs = { .dpms = tda998x_encoder_dpms, - .mode_fixup = tda998x_encoder_mode_fixup, .prepare = tda998x_encoder_prepare, .commit = tda998x_encoder_commit, .mode_set = tda998x_encoder_mode_set,
dri-devel@lists.freedesktop.org
-
Carlos Palminha