On 3/25/2019 4:46 AM, Kangjie Lu wrote:

pm_runtime_get_sync could fail and thus deserves a check.

The patch adds such a check and return its error code upstream if it indeed failed.

Signed-off-by: Kangjie Lu kjlu@umn.edu

Reviewed-by: Mukesh Ojha <mojha@codeaurora.org mailto:mojha@codeaurora.org>

Thanks. Mukesh

---

drivers/gpu/drm/v3d/v3d_drv.c | 2 ++ 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/v3d/v3d_drv.c b/drivers/gpu/drm/v3d/v3d_drv.c index f0afcec72c34..99daad11fac2 100644 --- a/drivers/gpu/drm/v3d/v3d_drv.c +++ b/drivers/gpu/drm/v3d/v3d_drv.c @@ -101,6 +101,8 @@ static int v3d_get_param_ioctl(struct drm_device *dev, void *data, return -EINVAL;

ret = pm_runtime_get_sync(v3d->dev);

• if (ret < 0)
  

• 	return ret;
  

  if (args->param >= DRM_V3D_PARAM_V3D_CORE0_IDENT0 && args->param <= DRM_V3D_PARAM_V3D_CORE0_IDENT2) { args->value = V3D_CORE_READ(0, offset);