On 8/19/19 2:18 AM, Stephen Rothwell wrote:
Hi all,
Changes since 20190816:
on x86_64:
../drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c: In function ‘amdgpu_exit’: ../drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c:1471:2: error: implicit declaration of function ‘mmu_notifier_synchronize’; did you mean ‘__sync_synchronize’? [-Werror=implicit-function-declaration] mmu_notifier_synchronize(); ^~~~~~~~~~~~~~~~~~~~~~~~ __sync_synchronize
Full randconfig file is attached.
Hi all,
On Mon, 19 Aug 2019 18:34:41 -0700 Randy Dunlap rdunlap@infradead.org wrote:
On 8/19/19 2:18 AM, Stephen Rothwell wrote:
Hi all,
Changes since 20190816:
on x86_64:
../drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c: In function ‘amdgpu_exit’: ../drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c:1471:2: error: implicit declaration of function ‘mmu_notifier_synchronize’; did you mean ‘__sync_synchronize’? [-Werror=implicit-function-declaration] mmu_notifier_synchronize(); ^~~~~~~~~~~~~~~~~~~~~~~~ __sync_synchronize
Full randconfig file is attached.
Caused by commit
6832c9dc8358 ("hmm: use mmu_notifier_get/put for 'struct hmm'")
from the hmm tree.
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c need to include linux/mmu_notifier.h
On Tue, Aug 20, 2019 at 11:45:54AM +1000, Stephen Rothwell wrote:
Hi all,
On Mon, 19 Aug 2019 18:34:41 -0700 Randy Dunlap rdunlap@infradead.org wrote:
On 8/19/19 2:18 AM, Stephen Rothwell wrote:
Hi all,
Changes since 20190816:
on x86_64:
../drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c: In function ‘amdgpu_exit’: ../drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c:1471:2: error: implicit declaration of function ‘mmu_notifier_synchronize’; did you mean ‘__sync_synchronize’? [-Werror=implicit-function-declaration] mmu_notifier_synchronize(); ^~~~~~~~~~~~~~~~~~~~~~~~ __sync_synchronize
Full randconfig file is attached.
Caused by commit
6832c9dc8358 ("hmm: use mmu_notifier_get/put for 'struct hmm'")
from the hmm tree.
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c need to include linux/mmu_notifier.h
Ah yes, thanks, it is because of !CONFIG_HMM_MIRROR in this randconfig. I've fixed it up.
Regards, Jason
On 2019-08-20 8:36 a.m., Jason Gunthorpe wrote:
On Tue, Aug 20, 2019 at 11:45:54AM +1000, Stephen Rothwell wrote:
Hi all,
On Mon, 19 Aug 2019 18:34:41 -0700 Randy Dunlap rdunlap@infradead.org wrote:
On 8/19/19 2:18 AM, Stephen Rothwell wrote:
Hi all,
Changes since 20190816:
on x86_64:
../drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c: In function ‘amdgpu_exit’: ../drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c:1471:2: error: implicit declaration of function ‘mmu_notifier_synchronize’; did you mean ‘__sync_synchronize’? [-Werror=implicit-function-declaration] mmu_notifier_synchronize(); ^~~~~~~~~~~~~~~~~~~~~~~~ __sync_synchronize
Full randconfig file is attached.
Caused by commit
6832c9dc8358 ("hmm: use mmu_notifier_get/put for 'struct hmm'")
from the hmm tree.
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c need to include linux/mmu_notifier.h
Ah yes, thanks, it is because of !CONFIG_HMM_MIRROR in this randconfig. I've fixed it up.
Thanks Jason. I'm trying to follow what's going on here, but I can't find the commit hash quoted above in any of the public repositories I'm tracking:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git ssh://git.freedesktop.org/git/drm/drm ssh://people.freedesktop.org/~agd5f/linux ssh://people.freedesktop.org/~glisse/linux
Where is this work happening?
Thanks, Felix
Regards, Jason
amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
On Wed, Aug 21, 2019 at 03:34:12PM +0000, Kuehling, Felix wrote:
On 2019-08-20 8:36 a.m., Jason Gunthorpe wrote:
On Tue, Aug 20, 2019 at 11:45:54AM +1000, Stephen Rothwell wrote:
Hi all,
On Mon, 19 Aug 2019 18:34:41 -0700 Randy Dunlap rdunlap@infradead.org wrote:
On 8/19/19 2:18 AM, Stephen Rothwell wrote:
Hi all,
Changes since 20190816:
on x86_64:
../drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c: In function ‘amdgpu_exit’: ../drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c:1471:2: error: implicit declaration of function ‘mmu_notifier_synchronize’; did you mean ‘__sync_synchronize’? [-Werror=implicit-function-declaration] mmu_notifier_synchronize(); ^~~~~~~~~~~~~~~~~~~~~~~~ __sync_synchronize
Full randconfig file is attached.
Caused by commit
6832c9dc8358 ("hmm: use mmu_notifier_get/put for 'struct hmm'")
from the hmm tree.
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c need to include linux/mmu_notifier.h
Ah yes, thanks, it is because of !CONFIG_HMM_MIRROR in this randconfig. I've fixed it up.
Thanks Jason. I'm trying to follow what's going on here, but I can't find the commit hash quoted above in any of the public repositories I'm tracking
I was able to squash the one line fix, so the commit ID is gone, it is now:
https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git/commit/?h=hmm&...
From
https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git/log/?h=hmm
Jason
dri-devel@lists.freedesktop.org
-
Jason Gunthorpe -
Kuehling, Felix -
Randy Dunlap -
Stephen Rothwell