Drop the following headers_check errors: /linux-2.6/usr/include/drm/drm_mode.h:85: found __[us]{8,16,32,64} type without #include <linux/types.h> /linux-2.6/usr/include/drm/i915_drm.h:120: found __[us]{8,16,32,64} type without #include <linux/types.h> /linux-2.6/usr/include/drm/mga_drm.h:260: found __[us]{8,16,32,64} type without #include <linux/types.h> /linux-2.6/usr/include/drm/radeon_drm.h:758: found __[us]{8,16,32,64} type without #include <linux/types.h> /linux-2.6/usr/include/drm/via_drm.h:117: found __[us]{8,16,32,64} type without #include <linux/types.h>
Cc: David Airlie airlied@linux.ie Cc: Chris Wilson chris@chris-wilson.co.uk Cc: dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Felipe Balbi balbi@ti.com --- include/drm/drm_mode.h | 2 ++ include/drm/i915_drm.h | 1 + include/drm/mga_drm.h | 1 + include/drm/radeon_drm.h | 1 + include/drm/via_drm.h | 1 + 5 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/include/drm/drm_mode.h b/include/drm/drm_mode.h index 0fc7397..1678d7b 100644 --- a/include/drm/drm_mode.h +++ b/include/drm/drm_mode.h @@ -27,6 +27,8 @@ #ifndef _DRM_MODE_H #define _DRM_MODE_H
+#include <linux/types.h> + #define DRM_DISPLAY_INFO_LEN 32 #define DRM_CONNECTOR_NAME_LEN 32 #define DRM_DISPLAY_MODE_LEN 32 diff --git a/include/drm/i915_drm.h b/include/drm/i915_drm.h index 0039f1f..4b211c8 100644 --- a/include/drm/i915_drm.h +++ b/include/drm/i915_drm.h @@ -27,6 +27,7 @@ #ifndef _I915_DRM_H_ #define _I915_DRM_H_
+#include <linux/types.h> #include "drm.h"
/* Please note that modifications to all structs defined here are diff --git a/include/drm/mga_drm.h b/include/drm/mga_drm.h index c16097f..1107097 100644 --- a/include/drm/mga_drm.h +++ b/include/drm/mga_drm.h @@ -35,6 +35,7 @@ #ifndef __MGA_DRM_H__ #define __MGA_DRM_H__
+#include <linux/types.h> #include "drm.h"
/* WARNING: If you change any of these defines, make sure to change the diff --git a/include/drm/radeon_drm.h b/include/drm/radeon_drm.h index e95a86b..f9ec151 100644 --- a/include/drm/radeon_drm.h +++ b/include/drm/radeon_drm.h @@ -33,6 +33,7 @@ #ifndef __RADEON_DRM_H__ #define __RADEON_DRM_H__
+#include <linux/types.h> #include "drm.h"
/* WARNING: If you change any of these defines, make sure to change the diff --git a/include/drm/via_drm.h b/include/drm/via_drm.h index fd11a5b..23880b0 100644 --- a/include/drm/via_drm.h +++ b/include/drm/via_drm.h @@ -24,6 +24,7 @@ #ifndef _VIA_DRM_H_ #define _VIA_DRM_H_
+#include <linux/types.h> #include "drm.h"
/* WARNING: These defines must be the same as what the Xserver uses.
Hi,
On Sun, Jan 16, 2011 at 12:46:22PM +0200, Felipe Balbi wrote:
Drop the following headers_check errors: /linux-2.6/usr/include/drm/drm_mode.h:85: found __[us]{8,16,32,64} type without #include <linux/types.h> /linux-2.6/usr/include/drm/i915_drm.h:120: found __[us]{8,16,32,64} type without #include <linux/types.h> /linux-2.6/usr/include/drm/mga_drm.h:260: found __[us]{8,16,32,64} type without #include <linux/types.h> /linux-2.6/usr/include/drm/radeon_drm.h:758: found __[us]{8,16,32,64} type without #include <linux/types.h> /linux-2.6/usr/include/drm/via_drm.h:117: found __[us]{8,16,32,64} type without #include <linux/types.h>
Cc: David Airlie airlied@linux.ie Cc: Chris Wilson chris@chris-wilson.co.uk Cc: dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Felipe Balbi balbi@ti.com
$SUBJECT shouldn't have number actually. Git added those automatically. Oh well, not a big deal.
On Sun, 16 Jan 2011 12:46:22 +0200, Felipe Balbi balbi@ti.com wrote:
Drop the following headers_check errors: /linux-2.6/usr/include/drm/drm_mode.h:85: found __[us]{8,16,32,64} type without #include <linux/types.h> /linux-2.6/usr/include/drm/i915_drm.h:120: found __[us]{8,16,32,64} type without #include <linux/types.h> /linux-2.6/usr/include/drm/mga_drm.h:260: found __[us]{8,16,32,64} type without #include <linux/types.h> /linux-2.6/usr/include/drm/radeon_drm.h:758: found __[us]{8,16,32,64} type without #include <linux/types.h> /linux-2.6/usr/include/drm/via_drm.h:117: found __[us]{8,16,32,64} type without #include <linux/types.h>
Cc: David Airlie airlied@linux.ie Cc: Chris Wilson chris@chris-wilson.co.uk Cc: dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Felipe Balbi balbi@ti.com
include/drm/drm_mode.h | 2 ++ include/drm/i915_drm.h | 1 + include/drm/mga_drm.h | 1 + include/drm/radeon_drm.h | 1 + include/drm/via_drm.h | 1 + 5 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/include/drm/drm_mode.h b/include/drm/drm_mode.h index 0fc7397..1678d7b 100644 --- a/include/drm/drm_mode.h +++ b/include/drm/drm_mode.h @@ -27,6 +27,8 @@ #ifndef _DRM_MODE_H #define _DRM_MODE_H
+#include <linux/types.h>
Would
#if 0 #include <linux/types.h> /* silence make header_check */ #endif
be an acceptable compromise? -Chris
On Sun, Jan 16, 2011 at 11:07:32AM +0000, Chris Wilson wrote:
On Sun, 16 Jan 2011 12:46:22 +0200, Felipe Balbi balbi@ti.com wrote:
Drop the following headers_check errors: /linux-2.6/usr/include/drm/drm_mode.h:85: found __[us]{8,16,32,64} type without #include <linux/types.h> /linux-2.6/usr/include/drm/i915_drm.h:120: found __[us]{8,16,32,64} type without #include <linux/types.h> /linux-2.6/usr/include/drm/mga_drm.h:260: found __[us]{8,16,32,64} type without #include <linux/types.h> /linux-2.6/usr/include/drm/radeon_drm.h:758: found __[us]{8,16,32,64} type without #include <linux/types.h> /linux-2.6/usr/include/drm/via_drm.h:117: found __[us]{8,16,32,64} type without #include <linux/types.h>
Cc: David Airlie airlied@linux.ie Cc: Chris Wilson chris@chris-wilson.co.uk Cc: dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Felipe Balbi balbi@ti.com
include/drm/drm_mode.h | 2 ++ include/drm/i915_drm.h | 1 + include/drm/mga_drm.h | 1 + include/drm/radeon_drm.h | 1 + include/drm/via_drm.h | 1 + 5 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/include/drm/drm_mode.h b/include/drm/drm_mode.h index 0fc7397..1678d7b 100644 --- a/include/drm/drm_mode.h +++ b/include/drm/drm_mode.h @@ -27,6 +27,8 @@ #ifndef _DRM_MODE_H #define _DRM_MODE_H
+#include <linux/types.h>
Would
#if 0 #include <linux/types.h> /* silence make header_check */ #endif
be an acceptable compromise?
Why would you want to do that ? I truly have those types in use. headers_check seems to be reporting correctly.
Hi,
On Sun, Jan 16, 2011 at 09:42:37PM +1000, Dave Airlie wrote:
I'll push the attached I think this time.
the point of headers_check is exactly to prevent indirect inclusion. This is even 1st topic o SubmitChecklist:
" 1: If you use a facility then #include the file that defines/declares that facility. Don't depend on other header files pulling in that you use."
dri-devel@lists.freedesktop.org