https://bugs.freedesktop.org/show_bug.cgi?id=64600

--- Comment #2 from darkbasic darkbasic@linuxsystems.it --- Any news? With latest stack and HD 7950 I get

~ $ pyrit benchmark Pyrit 0.4.0 (C) 2008-2011 Lukas Lueg http://pyrit.googlecode.com This code is distributed under the GNU General Public License v3+

Calibrating... 0x7f981cb8b690: i64 = ExternalSymbol'__muldi3' Stack dump: 0. Running pass 'Function Pass Manager' on module 'radeon'. 1. Running pass 'AMDGPU DAG->DAG Pattern Instruction Selection' on function '@opencl_pmk_kernel' Errore di segmentazione

https://bugs.freedesktop.org/show_bug.cgi?id=64600

--- Comment #4 from Tom Stellard tstellar@gmail.com --- Created attachment 86005 --> https://bugs.freedesktop.org/attachment.cgi?id=86005&action=edit Possible Fix

Can you try this patch, and if it doesn't work post the output of R600_DEBUG=cs.

https://bugs.freedesktop.org/show_bug.cgi?id=64600

--- Comment #6 from Tom Stellard tstellar@gmail.com --- (In reply to comment #5)

It hangs at calibrating now:

~ $ R600_DEBUG=cs pyrit benchmark Pyrit 0.4.0 (C) 2008-2011 Lukas Lueg http://pyrit.googlecode.com This code is distributed under the GNU General Public License v3+

Calibrating... ^CTerminato

Where should I find the output of R600_DEBUG=cs? There is nothing even in dmesg.

This bug was filed against Evergreen/NI GPUs. If you are using SI, you will need to use RADEON_DUMP_SHADERS=1

Otherwise, R600_DEBUG=cs will print output to stderr.

https://bugs.freedesktop.org/show_bug.cgi?id=64600

--- Comment #8 from Tom Stellard tstellar@gmail.com --- (In reply to comment #7)

Created attachment 86011 [details] pyrit debug

Here it is, thanks.

There are no compute shaders in this output. You should let the program run longer, if possible, to give it time to dump all the output.

https://bugs.freedesktop.org/show_bug.cgi?id=64600

--- Comment #10 from Erdem U. Altınyurt spamjunkeater@gmail.com --- Created attachment 86118 --> https://bugs.freedesktop.org/attachment.cgi?id=86118&action=edit Debug output

I am attaching debug output generated with R600_DEBUG=cs pyrit benchmark 2> debug.txt

without the patch (attachment 86005).

With the latest proposed patch, there are no output on debug. Just stalling. Don't know why. Thanks.

https://bugs.freedesktop.org/show_bug.cgi?id=64600

--- Comment #12 from Tom Stellard tstellar@gmail.com --- These patches should fix the crash on Evergreen/NI GPUs: http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20131007/190695....

https://bugs.freedesktop.org/show_bug.cgi?id=64600

--- Comment #14 from Peter Wu lekensteyn@gmail.com --- Created attachment 87536 --> https://bugs.freedesktop.org/attachment.cgi?id=87536&action=edit piglit test kernel with pyrit

The patches did avoid the crash, but the results are still invalid.

For convenience, I have added some test vectors and glue to the pyrit kernel. I don't know if such a complex testcase is acceptable for piglit, hence I am posting it here. Let me know if such a case is suitable for piglit and if it should be posted to the piglit list too.

The test passes with the POCL implementation but not with the R600 one.

Without the patches the output is: ## Test: Pyrit WPA2-PSK accelerator (/src/piglit/tests/cl/program/program-tester.c) ##

# Running on: # Platform: Default # Device: AMD BARTS # OpenCL version: 1.1 # OpenCL C version: 1.1 # Build options: -cl-std=CL1.1 Program has been built successfully

Running kernel test:

Using kernel opencl_pmk_kernel Setting kernel arguments... Running the kernel... cl-program-tester: /src/llvm/include/llvm/MC/MCRegisterInfo.h:65: unsigned int llvm::MCRegisterClass::getRegister(unsigned int) const: Assertion `i < getNumRegs() && "Register number out of range!"' failed. Stack dump: 0. Running pass 'Function Pass Manager' on module 'radeon'. 1. Running pass 'R600 Handle indirect addressing' on function '@opencl_pmk_kernel' Aborted (core dumped)

With branch tsellar/r600-private-mem-fixes, up to commit cf5d9a2: [..] Running the kernel... Validating results... Expecting 3201012614 (0xbecb9386) with tolerance 0, but got 844928435 (0x325c95b3) Error at uint[0] Argument 1: FAIL PIGLIT:subtest {'' : 'fail'}

...

Some or all of the tests FAILED

# Result: PIGLIT: {'result': 'fail' }

https://bugs.freedesktop.org/show_bug.cgi?id=64600

--- Comment #16 from Peter Wu lekensteyn@gmail.com --- Created attachment 87609 --> https://bugs.freedesktop.org/attachment.cgi?id=87609&action=edit R600_DEBUG=cs cl-program-tester struct-copy.cl

The parameter tests passes when the struct contains one member, but the struct assignment still fails. Attached is the shader debug output for the original test case.

LLVM: r600-private-mem-fixes rebased on master (01436ba3066b99547c1138edf5c36ef2ad467e71, SVN rev 192587) Mesa: git snb-magic-18531-ge6c2afa

https://bugs.freedesktop.org/show_bug.cgi?id=64600

--- Comment #18 from Peter Wu lekensteyn@gmail.com --- Created attachment 87706 --> https://bugs.freedesktop.org/attachment.cgi?id=87706&action=edit piglit test (messy, with comments) that fails on R600

I'll await the feedback in your thread before submitting it to piglit.

So the struct bug is fixed, yet I encountered another issue that seems to be related to alignment. Please find attached piglit test, it fails on R600 but passes with POCL and a C wrapper.

The Pyrit kernel has been stripped, only the sha1_process function remains (with one macro expanded and every macro thereafter undef'd). See the comments in the test.

https://bugs.freedesktop.org/show_bug.cgi?id=64600

--- Comment #20 from Tom Stellard tstellar@gmail.com --- Created attachment 87757 --> https://bugs.freedesktop.org/attachment.cgi?id=87757&action=edit Additional Bug fix - Apply to my master-testing branch