Hi Laurent,

Thanks for your work.

On 2020-06-21 03:47:27 +0300, Laurent Pinchart wrote:

Convert the Renesas R-Car FCP text binding to YAML.

Signed-off-by: Laurent Pinchart laurent.pinchart+renesas@ideasonboard.com Reviewed-by: Geert Uytterhoeven geert+renesas@glider.be

---

Changes since v1:

• Simplify comments on compatible strings
• Update MAINTAINERS

---

.../devicetree/bindings/media/renesas,fcp.txt | 34 ----------- .../bindings/media/renesas,fcp.yaml | 56 +++++++++++++++++++ MAINTAINERS | 2 +- 3 files changed, 57 insertions(+), 35 deletions(-) delete mode 100644 Documentation/devicetree/bindings/media/renesas,fcp.txt create mode 100644 Documentation/devicetree/bindings/media/renesas,fcp.yaml

diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt b/Documentation/devicetree/bindings/media/renesas,fcp.txt deleted file mode 100644 index 79c37395b396..000000000000 --- a/Documentation/devicetree/bindings/media/renesas,fcp.txt +++ /dev/null @@ -1,34 +0,0 @@

-Renesas R-Car Frame Compression Processor (FCP)

-The FCP is a companion module of video processing modules in the Renesas R-Car -Gen3 and RZ/G2 SoCs. It provides data compression and decompression, data -caching, and conversion of AXI transactions in order to reduce the memory -bandwidth.

-There are three types of FCP: FCP for Codec (FCPC), FCP for VSP (FCPV) and FCP -for FDP (FCPF). Their configuration and behaviour depend on the module they -are paired with. These DT bindings currently support the FCPV and FCPF.

• • compatible: Must be one or more of the following
• • "renesas,fcpv" for generic compatible 'FCP for VSP'
• • "renesas,fcpf" for generic compatible 'FCP for FDP'
• • reg: the register base and size for the device registers
• • clocks: Reference to the functional clock

-Optional properties:

• • power-domains : power-domain property defined with a power domain specifier

•    to respective power domain.
  

-Device node example

• fcpvd1: fcp@fea2f000 {

• compatible = "renesas,fcpv";
  

• reg = <0 0xfea2f000 0 0x200>;
  

• clocks = <&cpg CPG_MOD 602>;
  

• power-domains = <&sysc R8A7795_PD_A3VP>;
  

• };

diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.yaml b/Documentation/devicetree/bindings/media/renesas,fcp.yaml new file mode 100644 index 000000000000..9241bf3c5efc --- /dev/null +++ b/Documentation/devicetree/bindings/media/renesas,fcp.yaml @@ -0,0 +1,56 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/renesas,fcp.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml#

+title: Renesas R-Car Frame Compression Processor (FCP)

+maintainers:

• • Laurent Pinchart laurent.pinchart@ideasonboard.com

+description: |

• The FCP is a companion module of video processing modules in the Renesas
• R-Car Gen3 and RZ/G2 SoCs. It provides data compression and decompression,
• data caching, and conversion of AXI transactions in order to reduce the
• memory bandwidth.
• There are three types of FCP: FCP for Codec (FCPC), FCP for VSP (FCPV) and
• FCP for FDP (FCPF). Their configuration and behaviour depend on the module
• they are paired with. These DT bindings currently support the FCPV and FCPF.

+properties:

• compatible:
• enum:

•  - renesas,fcpv # FCP for VSP
  

•  - renesas,fcpf # FCP for FDP
  

• reg:
• maxItems: 1
• clocks:
• maxItems: 1
• power-domains:
• maxItems: 1

+required:

• • compatible
• • reg
• • clocks

+additionalProperties: false

+examples:

• # R8A7790 (R-Car H2) VSP1-S

Hum, R8A7790 is H2 but the example below is from H3 R8A7795[01] is it not? With this fixed,

Reviewed-by: Niklas Söderlund niklas.soderlund+renesas@ragnatech.se

• • |
• #include <dt-bindings/clock/renesas-cpg-mssr.h>
• #include <dt-bindings/power/r8a7795-sysc.h>
• fcp@fea2f000 {

•    compatible = "renesas,fcpv";
  

•    reg = <0xfea2f000 0x200>;
  

•    clocks = <&cpg CPG_MOD 602>;
  

•    power-domains = <&sysc R8A7795_PD_ALWAYS_ON>;
  

• };

+... diff --git a/MAINTAINERS b/MAINTAINERS index 68f21d46614c..660ed6606de2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -10700,7 +10700,7 @@ L: linux-media@vger.kernel.org L: linux-renesas-soc@vger.kernel.org S: Supported T: git git://linuxtv.org/media_tree.git -F: Documentation/devicetree/bindings/media/renesas,fcp.txt +F: Documentation/devicetree/bindings/media/renesas,fcp.yaml F: drivers/media/platform/rcar-fcp.c F: include/media/rcar-fcp.h

-- Regards,

Laurent Pinchart

Convert the Renesas R-Car FCP text binding to YAML.

Signed-off-by: Laurent Pinchart laurent.pinchart+renesas@ideasonboard.com Reviewed-by: Geert Uytterhoeven geert+renesas@glider.be Reviewed-by: Niklas Söderlund niklas.soderlund+renesas@ragnatech.se --- Changes since v2:

- Refer to the correct device in the comment above the example

Changes since v1:

- Simplify comments on compatible strings - Update MAINTAINERS --- .../devicetree/bindings/media/renesas,fcp.txt | 34 ----------- .../bindings/media/renesas,fcp.yaml | 56 +++++++++++++++++++ MAINTAINERS | 2 +- 3 files changed, 57 insertions(+), 35 deletions(-) delete mode 100644 Documentation/devicetree/bindings/media/renesas,fcp.txt create mode 100644 Documentation/devicetree/bindings/media/renesas,fcp.yaml

diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt b/Documentation/devicetree/bindings/media/renesas,fcp.txt deleted file mode 100644 index 79c37395b396..000000000000 --- a/Documentation/devicetree/bindings/media/renesas,fcp.txt +++ /dev/null @@ -1,34 +0,0 @@ -Renesas R-Car Frame Compression Processor (FCP) ------------------------------------------------ - -The FCP is a companion module of video processing modules in the Renesas R-Car -Gen3 and RZ/G2 SoCs. It provides data compression and decompression, data -caching, and conversion of AXI transactions in order to reduce the memory -bandwidth. - -There are three types of FCP: FCP for Codec (FCPC), FCP for VSP (FCPV) and FCP -for FDP (FCPF). Their configuration and behaviour depend on the module they -are paired with. These DT bindings currently support the FCPV and FCPF. - - - compatible: Must be one or more of the following - - - "renesas,fcpv" for generic compatible 'FCP for VSP' - - "renesas,fcpf" for generic compatible 'FCP for FDP' - - - reg: the register base and size for the device registers - - clocks: Reference to the functional clock - -Optional properties: - - power-domains : power-domain property defined with a power domain specifier - to respective power domain. - - -Device node example -------------------- - - fcpvd1: fcp@fea2f000 { - compatible = "renesas,fcpv"; - reg = <0 0xfea2f000 0 0x200>; - clocks = <&cpg CPG_MOD 602>; - power-domains = <&sysc R8A7795_PD_A3VP>; - }; diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.yaml b/Documentation/devicetree/bindings/media/renesas,fcp.yaml new file mode 100644 index 000000000000..ec0cb42ca464 --- /dev/null +++ b/Documentation/devicetree/bindings/media/renesas,fcp.yaml @@ -0,0 +1,56 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/renesas,fcp.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Renesas R-Car Frame Compression Processor (FCP) + +maintainers: + - Laurent Pinchart laurent.pinchart@ideasonboard.com + +description: | + The FCP is a companion module of video processing modules in the Renesas + R-Car Gen3 and RZ/G2 SoCs. It provides data compression and decompression, + data caching, and conversion of AXI transactions in order to reduce the + memory bandwidth. + + There are three types of FCP: FCP for Codec (FCPC), FCP for VSP (FCPV) and + FCP for FDP (FCPF). Their configuration and behaviour depend on the module + they are paired with. These DT bindings currently support the FCPV and FCPF. + +properties: + compatible: + enum: + - renesas,fcpv # FCP for VSP + - renesas,fcpf # FCP for FDP + + reg: + maxItems: 1 + + clocks: + maxItems: 1 + + power-domains: + maxItems: 1 + +required: + - compatible + - reg + - clocks + +additionalProperties: false + +examples: + # R8A7795 (R-Car H3) FCP for VSP-D1 + - | + #include <dt-bindings/clock/renesas-cpg-mssr.h> + #include <dt-bindings/power/r8a7795-sysc.h> + + fcp@fea2f000 { + compatible = "renesas,fcpv"; + reg = <0xfea2f000 0x200>; + clocks = <&cpg CPG_MOD 602>; + power-domains = <&sysc R8A7795_PD_ALWAYS_ON>; + }; +... diff --git a/MAINTAINERS b/MAINTAINERS index 634d2c3d621a..d69e49067d1a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -10700,7 +10700,7 @@ L: linux-media@vger.kernel.org L: linux-renesas-soc@vger.kernel.org S: Supported T: git git://linuxtv.org/media_tree.git -F: Documentation/devicetree/bindings/media/renesas,fcp.txt +F: Documentation/devicetree/bindings/media/renesas,fcp.yaml F: drivers/media/platform/rcar-fcp.c F: include/media/rcar-fcp.h

Hi Laurent,

Thanks for your patch.

On 2020-06-21 03:47:29 +0300, Laurent Pinchart wrote:

The resets and iommus properties are used in DT sources in the kernel tree. Document them, and make resets mandatory. The iommus property is optional as not all platforms wire the FCP to a functional IOMMU.

Signed-off-by: Laurent Pinchart laurent.pinchart+renesas@ideasonboard.com Reviewed-by: Geert Uytterhoeven geert+renesas@glider.be

Reviewed-by: Niklas Söderlund niklas.soderlund+renesas@ragnatech.se

---

Documentation/devicetree/bindings/media/renesas,fcp.yaml | 9 +++++++++ 1 file changed, 9 insertions(+)

diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.yaml b/Documentation/devicetree/bindings/media/renesas,fcp.yaml index eeca7e255420..b6cf2958e6c9 100644 --- a/Documentation/devicetree/bindings/media/renesas,fcp.yaml +++ b/Documentation/devicetree/bindings/media/renesas,fcp.yaml @@ -31,14 +31,21 @@ properties: clocks: maxItems: 1

• iommus:

• maxItems: 1

• power-domains: maxItems: 1

• resets:

• maxItems: 1

required:

• compatible
• reg
• clocks
• power-domains

• • resets

additionalProperties: false

@@ -53,5 +60,7 @@ examples: reg = <0xfea2f000 0x200>; clocks = <&cpg CPG_MOD 602>; power-domains = <&sysc R8A7795_PD_ALWAYS_ON>;

•    resets = <&cpg 602>;
  

•    iommus = <&ipmmu_vi0 9>;
  

  };

...

Regards,

Laurent Pinchart

Hi Laurent,

Thank for your patch.

On 2020-06-21 03:47:31 +0300, Laurent Pinchart wrote:

All DT source files in the kernel tree specify the power-domains property. Make it mandatory.

Signed-off-by: Laurent Pinchart laurent.pinchart+renesas@ideasonboard.com Reviewed-by: Geert Uytterhoeven geert+renesas@glider.be

Reviewed-by: Niklas Söderlund niklas.soderlund+renesas@ragnatech.se

---

Changes since v1:

• Fix typo in comment message

---

Documentation/devicetree/bindings/media/renesas,fdp1.yaml | 1 + 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/media/renesas,fdp1.yaml b/Documentation/devicetree/bindings/media/renesas,fdp1.yaml index f4db96a1f53c..39184bd21a27 100644 --- a/Documentation/devicetree/bindings/media/renesas,fdp1.yaml +++ b/Documentation/devicetree/bindings/media/renesas,fdp1.yaml @@ -43,6 +43,7 @@ required:

• reg
• interrupts
• clocks

• • power-domains

additionalProperties: false

-- Regards,

Laurent Pinchart

Hi Laurent,

Thanks for your patch.

On 2020-06-21 03:47:33 +0300, Laurent Pinchart wrote:

Convert the Renesas R-Car VSP1 text binding to YAML.

Signed-off-by: Laurent Pinchart laurent.pinchart+renesas@ideasonboard.com Reviewed-by: Geert Uytterhoeven geert+renesas@glider.be

Reviewed-by: Niklas Söderlund niklas.soderlund+renesas@ragnatech.se

---

Changes since v1:

• Simplify comments on compatible strings
• Update MAINTAINERS

---

.../bindings/media/renesas,vsp1.txt | 30 ------- .../bindings/media/renesas,vsp1.yaml | 83 +++++++++++++++++++ MAINTAINERS | 2 +- 3 files changed, 84 insertions(+), 31 deletions(-) delete mode 100644 Documentation/devicetree/bindings/media/renesas,vsp1.txt create mode 100644 Documentation/devicetree/bindings/media/renesas,vsp1.yaml

diff --git a/Documentation/devicetree/bindings/media/renesas,vsp1.txt b/Documentation/devicetree/bindings/media/renesas,vsp1.txt deleted file mode 100644 index cd5a955b2ea0..000000000000 --- a/Documentation/devicetree/bindings/media/renesas,vsp1.txt +++ /dev/null @@ -1,30 +0,0 @@ -* Renesas VSP Video Processing Engine

-The VSP is a video processing engine that supports up-/down-scaling, alpha -blending, color space conversion and various other image processing features. -It can be found in the Renesas R-Car Gen2, R-Car Gen3, RZ/G1, and RZ/G2 SoCs.

-Required properties:

• • compatible: Must contain one of the following values
• • "renesas,vsp1" for the R-Car Gen2 and RZ/G1 VSP1
• • "renesas,vsp2" for the R-Car Gen3 and RZ/G2 VSP2
• • reg: Base address and length of the registers block for the VSP.
• • interrupts: VSP interrupt specifier.
• • clocks: A phandle + clock-specifier pair for the VSP functional clock.

-Optional properties:

• • renesas,fcp: A phandle referencing the FCP that handles memory accesses

•             for the VSP. Not needed on Gen2, mandatory on Gen3.
  

-Example: R8A7790 (R-Car H2) VSP1-S node

• vsp@fe928000 {

• compatible = "renesas,vsp1";
  

• reg = <0 0xfe928000 0 0x8000>;
  

• interrupts = <0 267 IRQ_TYPE_LEVEL_HIGH>;
  

• clocks = <&mstp1_clks R8A7790_CLK_VSP1_S>;
  

• };

diff --git a/Documentation/devicetree/bindings/media/renesas,vsp1.yaml b/Documentation/devicetree/bindings/media/renesas,vsp1.yaml new file mode 100644 index 000000000000..65e8ee61ce90 --- /dev/null +++ b/Documentation/devicetree/bindings/media/renesas,vsp1.yaml @@ -0,0 +1,83 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/renesas,vsp1.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml#

+title: Renesas VSP Video Processing Engine

+maintainers:

• • Laurent Pinchart laurent.pinchart@ideasonboard.com

+description:

• The VSP is a video processing engine that supports up-/down-scaling, alpha
• blending, color space conversion and various other image processing features.
• It can be found in the Renesas R-Car Gen2, R-Car Gen3, RZ/G1, and RZ/G2 SoCs.

+properties:

• compatible:
• enum:

•  - renesas,vsp1 # R-Car Gen2 and RZ/G1
  

•  - renesas,vsp2 # R-Car Gen3 and RZ/G2
  

• reg:
• maxItems: 1
• interrupts:
• maxItems: 1
• clocks:
• maxItems: 1
• renesas,fcp:
• $ref: /schemas/types.yaml#/definitions/phandle
• description:

•  A phandle referencing the FCP that handles memory accesses for the VSP.
  

+required:

• • compatible
• • reg
• • interrupts
• • clocks

+additionalProperties: false

+if:

• properties:
• compatible:

•  items:
  

•    - const: renesas,vsp1
  

+then:

• properties:
• renesas,fcp: false

+else:

• required:
• • renesas,fcp

+examples:

• # R8A7790 (R-Car H2) VSP1-S
• • |
• #include <dt-bindings/clock/renesas-cpg-mssr.h>
• #include <dt-bindings/interrupt-controller/arm-gic.h>
• vsp@fe928000 {

•    compatible = "renesas,vsp1";
  

•    reg = <0xfe928000 0x8000>;
  

•    interrupts = <GIC_SPI 267 IRQ_TYPE_LEVEL_HIGH>;
  

•    clocks = <&cpg CPG_MOD 131>;
  

• };
• # R8A77951 (R-Car H3) VSP2-BC
• • |
• #include <dt-bindings/clock/renesas-cpg-mssr.h>
• #include <dt-bindings/interrupt-controller/arm-gic.h>
• vsp@fe920000 {

•    compatible = "renesas,vsp2";
  

•    reg = <0xfe920000 0x8000>;
  

•    interrupts = <GIC_SPI 465 IRQ_TYPE_LEVEL_HIGH>;
  

•    clocks = <&cpg CPG_MOD 624>;
  

•    renesas,fcp = <&fcpvb1>;
  

• };

+... diff --git a/MAINTAINERS b/MAINTAINERS index 7383dfa510a3..22e079cc3e3f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -10730,7 +10730,7 @@ L: linux-media@vger.kernel.org L: linux-renesas-soc@vger.kernel.org S: Supported T: git git://linuxtv.org/media_tree.git -F: Documentation/devicetree/bindings/media/renesas,vsp1.txt +F: Documentation/devicetree/bindings/media/renesas,vsp1.yaml F: drivers/media/platform/vsp1/

MEDIA DRIVERS FOR ST STV0910 DEMODULATOR ICs

Regards,

Laurent Pinchart