The driver requires OF support, add a dependency in Kconfig and remove the platform_device_id table that isn't used anymore.
Signed-off-by: Laurent Pinchart laurent.pinchart+renesas@ideasonboard.com --- drivers/gpu/drm/rcar-du/Kconfig | 2 +- drivers/gpu/drm/rcar-du/rcar_du_drv.c | 11 +---------- 2 files changed, 2 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/rcar-du/Kconfig b/drivers/gpu/drm/rcar-du/Kconfig index 11485a4a16ae..d4e0a39568f6 100644 --- a/drivers/gpu/drm/rcar-du/Kconfig +++ b/drivers/gpu/drm/rcar-du/Kconfig @@ -1,6 +1,6 @@ config DRM_RCAR_DU tristate "DRM Support for R-Car Display Unit" - depends on DRM && ARM && HAVE_DMA_ATTRS + depends on DRM && ARM && HAVE_DMA_ATTRS && OF depends on ARCH_SHMOBILE || COMPILE_TEST select DRM_KMS_HELPER select DRM_KMS_CMA_HELPER diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index fb6709160a59..a9c445f1ebff 100644 --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c @@ -106,13 +106,6 @@ static const struct rcar_du_device_info rcar_du_r8a7791_info = { .num_lvds = 1, };
-static const struct platform_device_id rcar_du_id_table[] = { - { "rcar-du-r8a7779", (kernel_ulong_t)&rcar_du_r8a7779_info }, - { } -}; - -MODULE_DEVICE_TABLE(platform, rcar_du_id_table); - static const struct of_device_id rcar_du_of_table[] = { { .compatible = "renesas,du-r8a7779", .data = &rcar_du_r8a7779_info }, { .compatible = "renesas,du-r8a7790", .data = &rcar_du_r8a7790_info }, @@ -165,8 +158,7 @@ static int rcar_du_load(struct drm_device *dev, unsigned long flags) init_waitqueue_head(&rcdu->commit.wait);
rcdu->dev = &pdev->dev; - rcdu->info = np ? of_match_device(rcar_du_of_table, rcdu->dev)->data - : (void *)platform_get_device_id(pdev)->driver_data; + rcdu->info = of_match_device(rcar_du_of_table, rcdu->dev)->data; rcdu->ddev = dev; dev->dev_private = rcdu;
@@ -338,7 +330,6 @@ static struct platform_driver rcar_du_platform_driver = { .pm = &rcar_du_pm_ops, .of_match_table = rcar_du_of_table, }, - .id_table = rcar_du_id_table, };
module_platform_driver(rcar_du_platform_driver);
On Thu, Jul 16, 2015 at 10:44 AM, Laurent Pinchart laurent.pinchart+renesas@ideasonboard.com wrote:
The driver requires OF support, add a dependency in Kconfig and remove the platform_device_id table that isn't used anymore.
Signed-off-by: Laurent Pinchart laurent.pinchart+renesas@ideasonboard.com
Once Simon has queued up the removal of board-marzen.c:
Acked-by: Geert Uytterhoeven geert+renesas@glider.be
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert,
On Thursday 16 July 2015 11:08:58 Geert Uytterhoeven wrote:
On Thu, Jul 16, 2015 at 10:44 AM, Laurent Pinchart wrote:
The driver requires OF support, add a dependency in Kconfig and remove the platform_device_id table that isn't used anymore.
Signed-off-by: Laurent Pinchart laurent.pinchart+renesas@ideasonboard.com
Once Simon has queued up the removal of board-marzen.c:
Acked-by: Geert Uytterhoeven geert+renesas@glider.be
Thank you.
Note that support for platform data in the rcar-du driver has been dropped in v3.19, so I don't think we need to wait until Simon queues up the removal of board-marzen.c.
dri-devel@lists.freedesktop.org