This adds the HD version of Lenovo Ideapad D330 and FHD version of Lenovo Ideapad Miix 320.
This should work despite the dmi data is the same because the resolution checks.
Signed-off-by: David Santamaría Rogado howl.nsp@gmail.com --- drivers/gpu/drm/drm_panel_orientation_quirks.c | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c index ffd95bfeaa94..896c783ce135 100644 --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c @@ -191,14 +191,28 @@ static const struct dmi_system_id orientation_data[] = { DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "MIIX 310-10ICR"), }, .driver_data = (void *)&lcd800x1280_rightside_up, - }, { /* Lenovo Ideapad Miix 320 */ + }, { /* Lenovo Ideapad Miix 320 (HD) */ .matches = { DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"), DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80XF"), DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo MIIX 320-10ICR"), }, .driver_data = (void *)&lcd800x1280_rightside_up, - }, { /* Lenovo Ideapad D330 */ + }, { /* Lenovo Ideapad Miix 320 (FHD) */ + .matches = { + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"), + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80XF"), + DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo MIIX 320-10ICR"), + }, + .driver_data = (void *)&lcd1200x1920_rightside_up, + }, { /* Lenovo Ideapad D330 (HD) */ + .matches = { + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"), + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "81H3"), + DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad D330-10IGM"), + }, + .driver_data = (void *)&lcd800x1280_rightside_up, + }, { /* Lenovo Ideapad D330 (FHD) */ .matches = { DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"), DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "81H3"),
This patch is similar to the previous one but have found that Miix 320 also have FHD version, so include it while adding D330 HD.
El mar., 30 jul. 2019 a las 21:49, David Santamaría Rogado (howl.nsp@gmail.com) escribió:
This adds the HD version of Lenovo Ideapad D330 and FHD version of Lenovo Ideapad Miix 320.
This should work despite the dmi data is the same because the resolution checks.
Signed-off-by: David Santamaría Rogado howl.nsp@gmail.com
drivers/gpu/drm/drm_panel_orientation_quirks.c | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c index ffd95bfeaa94..896c783ce135 100644 --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c @@ -191,14 +191,28 @@ static const struct dmi_system_id orientation_data[] = { DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "MIIX 310-10ICR"), }, .driver_data = (void *)&lcd800x1280_rightside_up,
}, { /* Lenovo Ideapad Miix 320 */
}, { /* Lenovo Ideapad Miix 320 (HD) */ .matches = { DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"), DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80XF"), DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo MIIX 320-10ICR"), }, .driver_data = (void *)&lcd800x1280_rightside_up,
}, { /* Lenovo Ideapad D330 */
}, { /* Lenovo Ideapad Miix 320 (FHD) */.matches = {DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80XF"),DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo MIIX 320-10ICR"),},.driver_data = (void *)&lcd1200x1920_rightside_up,}, { /* Lenovo Ideapad D330 (HD) */.matches = {DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "81H3"),DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad D330-10IGM"),},.driver_data = (void *)&lcd800x1280_rightside_up,}, { /* Lenovo Ideapad D330 (FHD) */ .matches = { DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"), DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "81H3"),-- 2.21.0
This patch is still valid as no changes to panel orientation quirks have been done. Someone can review this to merge?
El mar., 30 jul. 2019 a las 21:49, David Santamaría Rogado (howl.nsp@gmail.com) escribió:
This adds the HD version of Lenovo Ideapad D330 and FHD version of Lenovo Ideapad Miix 320.
This should work despite the dmi data is the same because the resolution checks.
Signed-off-by: David Santamaría Rogado howl.nsp@gmail.com
drivers/gpu/drm/drm_panel_orientation_quirks.c | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c index ffd95bfeaa94..896c783ce135 100644 --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c @@ -191,14 +191,28 @@ static const struct dmi_system_id orientation_data[] = { DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "MIIX 310-10ICR"), }, .driver_data = (void *)&lcd800x1280_rightside_up,
}, { /* Lenovo Ideapad Miix 320 */
}, { /* Lenovo Ideapad Miix 320 (HD) */ .matches = { DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"), DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80XF"), DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo MIIX 320-10ICR"), }, .driver_data = (void *)&lcd800x1280_rightside_up,
}, { /* Lenovo Ideapad D330 */
}, { /* Lenovo Ideapad Miix 320 (FHD) */.matches = {DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80XF"),DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo MIIX 320-10ICR"),},.driver_data = (void *)&lcd1200x1920_rightside_up,}, { /* Lenovo Ideapad D330 (HD) */.matches = {DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "81H3"),DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad D330-10IGM"),},.driver_data = (void *)&lcd800x1280_rightside_up,}, { /* Lenovo Ideapad D330 (FHD) */ .matches = { DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"), DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "81H3"),-- 2.21.0
On Fri, 27 Mar 2020, David Santamaría Rogado howl.nsp@gmail.com wrote:
This patch is still valid as no changes to panel orientation quirks have been done. Someone can review this to merge?
Cc: Hans.
El mar., 30 jul. 2019 a las 21:49, David Santamaría Rogado (howl.nsp@gmail.com) escribió:
This adds the HD version of Lenovo Ideapad D330 and FHD version of Lenovo Ideapad Miix 320.
This should work despite the dmi data is the same because the resolution checks.
Signed-off-by: David Santamaría Rogado howl.nsp@gmail.com
drivers/gpu/drm/drm_panel_orientation_quirks.c | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c index ffd95bfeaa94..896c783ce135 100644 --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c @@ -191,14 +191,28 @@ static const struct dmi_system_id orientation_data[] = { DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "MIIX 310-10ICR"), }, .driver_data = (void *)&lcd800x1280_rightside_up,
}, { /* Lenovo Ideapad Miix 320 */
}, { /* Lenovo Ideapad Miix 320 (HD) */ .matches = { DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"), DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80XF"), DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo MIIX 320-10ICR"), }, .driver_data = (void *)&lcd800x1280_rightside_up,
}, { /* Lenovo Ideapad D330 */
}, { /* Lenovo Ideapad Miix 320 (FHD) */.matches = {DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80XF"),DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo MIIX 320-10ICR"),},.driver_data = (void *)&lcd1200x1920_rightside_up,}, { /* Lenovo Ideapad D330 (HD) */.matches = {DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "81H3"),DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad D330-10IGM"),},.driver_data = (void *)&lcd800x1280_rightside_up,}, { /* Lenovo Ideapad D330 (FHD) */ .matches = { DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"), DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "81H3"),-- 2.21.0
Hi,
On 3/31/20 6:44 PM, Jani Nikula wrote:
On Fri, 27 Mar 2020, David Santamaría Rogado howl.nsp@gmail.com wrote:
This patch is still valid as no changes to panel orientation quirks have been done. Someone can review this to merge?
Cc: Hans.
Looks good to me:
Reviewed-by: Hans de Goede hdegoede@redhat.com
Regards,
Hans
El mar., 30 jul. 2019 a las 21:49, David Santamaría Rogado (howl.nsp@gmail.com) escribió:
This adds the HD version of Lenovo Ideapad D330 and FHD version of Lenovo Ideapad Miix 320.
This should work despite the dmi data is the same because the resolution checks.
Signed-off-by: David Santamaría Rogado howl.nsp@gmail.com
drivers/gpu/drm/drm_panel_orientation_quirks.c | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c index ffd95bfeaa94..896c783ce135 100644 --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c @@ -191,14 +191,28 @@ static const struct dmi_system_id orientation_data[] = { DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "MIIX 310-10ICR"), }, .driver_data = (void *)&lcd800x1280_rightside_up,
}, { /* Lenovo Ideapad Miix 320 */
}, { /* Lenovo Ideapad Miix 320 (HD) */ .matches = { DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"), DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80XF"), DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo MIIX 320-10ICR"), }, .driver_data = (void *)&lcd800x1280_rightside_up,
}, { /* Lenovo Ideapad D330 */
}, { /* Lenovo Ideapad Miix 320 (FHD) */.matches = {DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80XF"),DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo MIIX 320-10ICR"),},.driver_data = (void *)&lcd1200x1920_rightside_up,}, { /* Lenovo Ideapad D330 (HD) */.matches = {DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "81H3"),DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad D330-10IGM"),},.driver_data = (void *)&lcd800x1280_rightside_up,}, { /* Lenovo Ideapad D330 (FHD) */ .matches = { DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"), DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "81H3"),-- 2.21.0
Hi, Jani don't forget about me, I have in mind to afford the 8 GB RAM version and will need more orientation inclusions :)
I have even looking at this issue with UEFI Shell, could be possible that the Intel video driver can get the correct panel location based in another thing? The UEFI Shell can get both orientations by just changing the mode, there are modes for portrait and landscape, but if there is no other way these quirks are the only way to get these machine properly for now.
El mar., 31 mar. 2020 a las 19:07, Hans de Goede (hdegoede@redhat.com) escribió:
Hi,
On 3/31/20 6:44 PM, Jani Nikula wrote:
On Fri, 27 Mar 2020, David Santamaría Rogado howl.nsp@gmail.com wrote:
This patch is still valid as no changes to panel orientation quirks have been done. Someone can review this to merge?
Cc: Hans.
Looks good to me:
Reviewed-by: Hans de Goede hdegoede@redhat.com
Regards,
Hans
El mar., 30 jul. 2019 a las 21:49, David Santamaría Rogado (howl.nsp@gmail.com) escribió:
This adds the HD version of Lenovo Ideapad D330 and FHD version of Lenovo Ideapad Miix 320.
This should work despite the dmi data is the same because the resolution checks.
Signed-off-by: David Santamaría Rogado howl.nsp@gmail.com
drivers/gpu/drm/drm_panel_orientation_quirks.c | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c index ffd95bfeaa94..896c783ce135 100644 --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c @@ -191,14 +191,28 @@ static const struct dmi_system_id orientation_data[] = { DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "MIIX 310-10ICR"), }, .driver_data = (void *)&lcd800x1280_rightside_up,
}, { /* Lenovo Ideapad Miix 320 */
}, { /* Lenovo Ideapad Miix 320 (HD) */ .matches = { DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"), DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80XF"), DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo MIIX 320-10ICR"), }, .driver_data = (void *)&lcd800x1280_rightside_up,
}, { /* Lenovo Ideapad D330 */
}, { /* Lenovo Ideapad Miix 320 (FHD) */.matches = {DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80XF"),DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo MIIX 320-10ICR"),},.driver_data = (void *)&lcd1200x1920_rightside_up,}, { /* Lenovo Ideapad D330 (HD) */.matches = {DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "81H3"),DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad D330-10IGM"),},.driver_data = (void *)&lcd800x1280_rightside_up,}, { /* Lenovo Ideapad D330 (FHD) */ .matches = { DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"), DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "81H3"),-- 2.21.0
Perhaps the Windows Intel video driver doesn't try the highest available mode reported by GOP in some circumstances? Seems that the right panel orientation appear as a less mode than the wrong one.
El dom., 26 abr. 2020 a las 21:35, David Santamaría Rogado (howl.nsp@gmail.com) escribió:
Hi, Jani don't forget about me, I have in mind to afford the 8 GB RAM version and will need more orientation inclusions :)
I have even looking at this issue with UEFI Shell, could be possible that the Intel video driver can get the correct panel location based in another thing? The UEFI Shell can get both orientations by just changing the mode, there are modes for portrait and landscape, but if there is no other way these quirks are the only way to get these machine properly for now.
El mar., 31 mar. 2020 a las 19:07, Hans de Goede (hdegoede@redhat.com) escribió:
Hi,
On 3/31/20 6:44 PM, Jani Nikula wrote:
On Fri, 27 Mar 2020, David Santamaría Rogado howl.nsp@gmail.com wrote:
This patch is still valid as no changes to panel orientation quirks have been done. Someone can review this to merge?
Cc: Hans.
Looks good to me:
Reviewed-by: Hans de Goede hdegoede@redhat.com
Regards,
Hans
El mar., 30 jul. 2019 a las 21:49, David Santamaría Rogado (howl.nsp@gmail.com) escribió:
This adds the HD version of Lenovo Ideapad D330 and FHD version of Lenovo Ideapad Miix 320.
This should work despite the dmi data is the same because the resolution checks.
Signed-off-by: David Santamaría Rogado howl.nsp@gmail.com
drivers/gpu/drm/drm_panel_orientation_quirks.c | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c index ffd95bfeaa94..896c783ce135 100644 --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c @@ -191,14 +191,28 @@ static const struct dmi_system_id orientation_data[] = { DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "MIIX 310-10ICR"), }, .driver_data = (void *)&lcd800x1280_rightside_up,
}, { /* Lenovo Ideapad Miix 320 */
}, { /* Lenovo Ideapad Miix 320 (HD) */ .matches = { DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"), DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80XF"), DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo MIIX 320-10ICR"), }, .driver_data = (void *)&lcd800x1280_rightside_up,
}, { /* Lenovo Ideapad D330 */
}, { /* Lenovo Ideapad Miix 320 (FHD) */.matches = {DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80XF"),DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo MIIX 320-10ICR"),},.driver_data = (void *)&lcd1200x1920_rightside_up,}, { /* Lenovo Ideapad D330 (HD) */.matches = {DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "81H3"),DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad D330-10IGM"),},.driver_data = (void *)&lcd800x1280_rightside_up,}, { /* Lenovo Ideapad D330 (FHD) */ .matches = { DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"), DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "81H3"),-- 2.21.0
dri-devel@lists.freedesktop.org
-
David Santamaría Rogado -
Hans de Goede -
Jani Nikula