The variables(bo_handles, pitches and offsets) are the array having 4 elementary of uint32_t type. The their memcpy size is sizeof(uint32_t) * 4.
Signed-off-by: Joonyoung Shim jy0922.shim@samsung.com --- xf86drmMode.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/xf86drmMode.c b/xf86drmMode.c index ffa6dc4..8065f20 100644 --- a/xf86drmMode.c +++ b/xf86drmMode.c @@ -267,9 +267,9 @@ int drmModeAddFB2(int fd, uint32_t width, uint32_t height, f.height = height; f.pixel_format = pixel_format; f.flags = flags; - memcpy(f.handles, bo_handles, sizeof(bo_handles)); - memcpy(f.pitches, pitches, sizeof(pitches)); - memcpy(f.offsets, offsets, sizeof(offsets)); + memcpy(f.handles, bo_handles, sizeof(uint32_t) * 4); + memcpy(f.pitches, pitches, sizeof(uint32_t) * 4); + memcpy(f.offsets, offsets, sizeof(uint32_t) * 4);
if ((ret = DRM_IOCTL(fd, DRM_IOCTL_MODE_ADDFB2, &f))) return ret;
On Wed, Dec 14, 2011 at 1:15 AM, Joonyoung Shim jy0922.shim@samsung.com wrote:
The variables(bo_handles, pitches and offsets) are the array having 4 elementary of uint32_t type. The their memcpy size is sizeof(uint32_t) * 4.
Signed-off-by: Joonyoung Shim jy0922.shim@samsung.com
Tested-by: Rob Clark rob.clark@linaro.org
xf86drmMode.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/xf86drmMode.c b/xf86drmMode.c index ffa6dc4..8065f20 100644 --- a/xf86drmMode.c +++ b/xf86drmMode.c @@ -267,9 +267,9 @@ int drmModeAddFB2(int fd, uint32_t width, uint32_t height, f.height = height; f.pixel_format = pixel_format; f.flags = flags;
- memcpy(f.handles, bo_handles, sizeof(bo_handles));
- memcpy(f.pitches, pitches, sizeof(pitches));
- memcpy(f.offsets, offsets, sizeof(offsets));
- memcpy(f.handles, bo_handles, sizeof(uint32_t) * 4);
- memcpy(f.pitches, pitches, sizeof(uint32_t) * 4);
- memcpy(f.offsets, offsets, sizeof(uint32_t) * 4);
if ((ret = DRM_IOCTL(fd, DRM_IOCTL_MODE_ADDFB2, &f))) return ret; -- 1.7.5.4
dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
dri-devel@lists.freedesktop.org
-
Joonyoung Shim -
Rob Clark