In line 24 "_AMDGPU_TRACE_H" is missing an underscore.
Signed-off-by: Chenyang Li lichenyang@loongson.cn --- drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h index ee9480d14cbc..86cfb3d55477 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h @@ -21,7 +21,7 @@ * */
-#if !defined(_AMDGPU_TRACE_H) || defined(TRACE_HEADER_MULTI_READ) +#if !defined(_AMDGPU_TRACE_H_) || defined(TRACE_HEADER_MULTI_READ) #define _AMDGPU_TRACE_H_
#include <linux/stringify.h>
[AMD Public Use]
Nice catch and the patch is:
Reviewed-by: Guchun Chen guchun.chen@amd.com
Regards, Guchun
-----Original Message----- From: amd-gfx amd-gfx-bounces@lists.freedesktop.org On Behalf Of Chenyang Li Sent: Wednesday, December 23, 2020 9:19 AM To: Deucher, Alexander Alexander.Deucher@amd.com; amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org Subject: [PATCH] drm/amdgpu:Fixed the wrong macro definition in amdgpu_trace.h
In line 24 "_AMDGPU_TRACE_H" is missing an underscore.
Signed-off-by: Chenyang Li lichenyang@loongson.cn --- drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h index ee9480d14cbc..86cfb3d55477 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h @@ -21,7 +21,7 @@ * */
-#if !defined(_AMDGPU_TRACE_H) || defined(TRACE_HEADER_MULTI_READ) +#if !defined(_AMDGPU_TRACE_H_) || defined(TRACE_HEADER_MULTI_READ) #define _AMDGPU_TRACE_H_
#include <linux/stringify.h>
Dear Chenyang,
Am 23.12.20 um 02:19 schrieb Chenyang Li:
In line 24 "_AMDGPU_TRACE_H" is missing an underscore.
Nice catch. Could you please update the commit message summary, by adding a space after the prefix (colon), and using imperative mood [1]?
drm/amdgpu: Fix macro name _AMDGPU_TRACE_H_ in preprocessor if condition
If you can also add a Fixes tag, that would be even better.
Fixes: d38ceaf99ed0 ("drm/amdgpu: add core driver (v4)")
Signed-off-by: Chenyang Li lichenyang@loongson.cn
drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[…]
Kind regards,
Paul
dri-devel@lists.freedesktop.org
-
Chen, Guchun -
Chenyang Li -
Paul Menzel