On Fri, Apr 3, 2015 at 10:39 PM, Nicholas Mc Guire hofrat@osadl.org wrote:

fix build warning when building edp/edp_aux.o due to missing prototype for edp_aux_transfer.

Signed-off-by: Nicholas Mc Guire hofrat@osadl.org

building drivers/gpu/drm/msm/msm.ko gives the following warning: drivers/gpu/drm/msm/edp/edp_aux.c:118:9: warning: no previous prototype for 'edp_aux_transfer' [-Wmissing-prototypes] ssize_t edp_aux_transfer(struct drm_dp_aux *drm_aux, struct drm_dp_aux_msg *msg) ^

thx.. fwiw, looks like edp_aux_transfer is only used in that one file.. so probably it actually wants to be static instead..

BR, -R

the fix is to simply add the missing prototype to drivers/gpu/drm/msm/edp/edp.h

This was compile tested with qcom_defconfig + CONFIG_DRM=m (implies CONFIG_DRM_MSM=m)

Patch is against 4.0-rc6 (localversion-next is -next-20150402)

drivers/gpu/drm/msm/edp/edp.h | 2 ++ 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/msm/edp/edp.h b/drivers/gpu/drm/msm/edp/edp.h index ba5bedd..93d819c 100644 --- a/drivers/gpu/drm/msm/edp/edp.h +++ b/drivers/gpu/drm/msm/edp/edp.h @@ -58,6 +58,8 @@ void *msm_edp_aux_init(struct device *dev, void __iomem *regbase, void msm_edp_aux_destroy(struct device *dev, struct edp_aux *aux); irqreturn_t msm_edp_aux_irq(struct edp_aux *aux, u32 isr); void msm_edp_aux_ctrl(struct edp_aux *aux, int enable); +ssize_t edp_aux_transfer(struct drm_dp_aux *drm_aux,

•                    struct drm_dp_aux_msg *msg);
  
  

/* Phy */ bool msm_edp_phy_ready(struct edp_phy *phy); -- 1.7.10.4