On Tue, Apr 14, 2020 at 03:13:40PM +0200, Christoph Hellwig wrote:
The pgprot argument to __vmalloc is always PROT_KERNEL now, so remove it.
Signed-off-by: Christoph Hellwig hch@lst.de Reviewed-by: Michael Kelley mikelley@microsoft.com [hyperv] Acked-by: Gao Xiang xiang@kernel.org [erofs] Acked-by: Peter Zijlstra (Intel) peterz@infradead.org
arch/x86/hyperv/hv_init.c | 3 +--
[...]
diff --git a/arch/x86/hyperv/hv_init.c b/arch/x86/hyperv/hv_init.c index 5a4b363ba67b..a3d689dfc745 100644 --- a/arch/x86/hyperv/hv_init.c +++ b/arch/x86/hyperv/hv_init.c @@ -95,8 +95,7 @@ static int hv_cpu_init(unsigned int cpu) * not be stopped in the case of CPU offlining and the VM will hang. */ if (!*hvp) {
*hvp = __vmalloc(PAGE_SIZE, GFP_KERNEL | __GFP_ZERO,PAGE_KERNEL);
*hvp = __vmalloc(PAGE_SIZE, GFP_KERNEL | __GFP_ZERO);
Acked-by: Wei Liu wei.liu@kernel.org
Greetings;
I recently noticed this change via the linux-next tree.
It may not be possible to edit at this late date, but the change description refers to PROT_KERNEL, which is a symbol which does not appear to exist; perhaps PAGE_KERNEL was meant? The mismatch caused me and a couple other folks some confusion briefly until we decided it was supposed to be PAGE_KERNEL; if it's not too late, editing the description to clarify so would be nice.
Many thanks.
John Dorminy
On Tue, Apr 14, 2020 at 11:15 AM Wei Liu wei.liu@kernel.org wrote:
On Tue, Apr 14, 2020 at 03:13:40PM +0200, Christoph Hellwig wrote:
The pgprot argument to __vmalloc is always PROT_KERNEL now, so remove it.
Signed-off-by: Christoph Hellwig hch@lst.de Reviewed-by: Michael Kelley mikelley@microsoft.com [hyperv] Acked-by: Gao Xiang xiang@kernel.org [erofs] Acked-by: Peter Zijlstra (Intel) peterz@infradead.org
arch/x86/hyperv/hv_init.c | 3 +--
[...]
diff --git a/arch/x86/hyperv/hv_init.c b/arch/x86/hyperv/hv_init.c index 5a4b363ba67b..a3d689dfc745 100644 --- a/arch/x86/hyperv/hv_init.c +++ b/arch/x86/hyperv/hv_init.c @@ -95,8 +95,7 @@ static int hv_cpu_init(unsigned int cpu) * not be stopped in the case of CPU offlining and the VM will
hang.
*/ if (!*hvp) {
*hvp = __vmalloc(PAGE_SIZE, GFP_KERNEL | __GFP_ZERO,PAGE_KERNEL);
*hvp = __vmalloc(PAGE_SIZE, GFP_KERNEL | __GFP_ZERO); }Acked-by: Wei Liu wei.liu@kernel.org
On Tue, Apr 14, 2020 at 03:13:40PM +0200, Christoph Hellwig wrote:
The pgprot argument to __vmalloc is always PROT_KERNEL now, so remove it.
Greetings;
I recently noticed this change via the linux-next tree.
It may not be possible to edit at this late date, but the change description refers to PROT_KERNEL, which is a symbol which does not appear to exist; perhaps PAGE_KERNEL was meant? The mismatch caused me and a couple other folks some confusion briefly until we decided it was supposed to be PAGE_KERNEL; if it's not too late, editing the description to clarify so would be nice.
Many thanks.
John Dorminy
On Thu, 30 Apr 2020 22:38:10 -0400 John Dorminy jdorminy@redhat.com wrote:
the change description refers to PROT_KERNEL, which is a symbol which does not appear to exist; perhaps PAGE_KERNEL was meant?
Yes, thanks, fixed.
dri-devel@lists.freedesktop.org
-
Andrew Morton -
John Dorminy -
Wei Liu