Hey,
So I notice we have two unreviewed drivers outstanding, the atmel hlcdc and the rockchips one, I'd like to suggest they you guys review each others work, they should be quite close in terms of functionality and you might spot some problems in your own code from reading the other driver.
I'm also hoping regular review will happen as well, but I think more cross-review is probably a good thing for new driver writers.
Dave.
Hi Dave,
On Wed, 17 Sep 2014 11:18:44 +1000 Dave Airlie airlied@gmail.com wrote:
Hey,
So I notice we have two unreviewed drivers outstanding, the atmel hlcdc and the rockchips one, I'd like to suggest they you guys review each others work, they should be quite close in terms of functionality and you might spot some problems in your own code from reading the other driver.
Sure, I'll review the rockchip driver.
I'm also hoping regular review will happen as well, but I think more cross-review is probably a good thing for new driver writers.
One more point, as stated in my cover letter, the HLCDC driver depends on 2 other series ([1] and [2]), which I proposed after discussing it with other KMS developers (Rob, Laurent and Thierry).
Could you take a look at these ones ?
Best Regards,
Boris
[1]http://lkml.iu.edu/hypermail/linux/kernel/1407.1/04171.html [2]http://www.spinics.net/lists/kernel/msg1791681.html
Hi Boris & Dave, I will update the rockchip drm driver soon, we have many change about it.
thanks. On 2014年09月17日 13:41, Boris BREZILLON wrote:
Hi Dave,
On Wed, 17 Sep 2014 11:18:44 +1000 Dave Airlie airlied@gmail.com wrote:
Hey,
So I notice we have two unreviewed drivers outstanding, the atmel hlcdc and the rockchips one, I'd like to suggest they you guys review each others work, they should be quite close in terms of functionality and you might spot some problems in your own code from reading the other driver.
Sure, I'll review the rockchip driver.
I'm also hoping regular review will happen as well, but I think more cross-review is probably a good thing for new driver writers.
One more point, as stated in my cover letter, the HLCDC driver depends on 2 other series ([1] and [2]), which I proposed after discussing it with other KMS developers (Rob, Laurent and Thierry).
Could you take a look at these ones ?
Best Regards,
Boris
[1]http://lkml.iu.edu/hypermail/linux/kernel/1407.1/04171.html [2]http://www.spinics.net/lists/kernel/msg1791681.html
Hi Yaozq,
On Wed, 17 Sep 2014 13:50:26 +0800 yaozq yzq@rock-chips.com wrote:
Hi Boris & Dave, I will update the rockchip drm driver soon, we have many change about it.
I'll wait for the new version then, just keep me in the loop when you send it.
Thanks,
Boris
Hi Boris, I have updated new version drm driver, you can review it.
Thanks. On 2014年09月18日 02:00, Boris BREZILLON wrote:
Hi Yaozq,
On Wed, 17 Sep 2014 13:50:26 +0800 yaozq yzq@rock-chips.com wrote:
Hi Boris & Dave, I will update the rockchip drm driver soon, we have many change about it.
I'll wait for the new version then, just keep me in the loop when you send it.
Thanks,
Boris
On Wed, Sep 17, 2014 at 1:41 AM, Boris BREZILLON boris.brezillon@free-electrons.com wrote:
Hi Dave,
On Wed, 17 Sep 2014 11:18:44 +1000 Dave Airlie airlied@gmail.com wrote:
Hey,
So I notice we have two unreviewed drivers outstanding, the atmel hlcdc and the rockchips one, I'd like to suggest they you guys review each others work, they should be quite close in terms of functionality and you might spot some problems in your own code from reading the other driver.
Sure, I'll review the rockchip driver.
I'm also hoping regular review will happen as well, but I think more cross-review is probably a good thing for new driver writers.
One more point, as stated in my cover letter, the HLCDC driver depends on 2 other series ([1] and [2]), which I proposed after discussing it with other KMS developers (Rob, Laurent and Thierry).
oh, I didn't notice that the flip-work patches hadn't landed yet.
Dave, [1] ("drm: rework flip-work framework") series has my r-b
BR, -R
Could you take a look at these ones ?
Best Regards,
Boris
[1]http://lkml.iu.edu/hypermail/linux/kernel/1407.1/04171.html [2]http://www.spinics.net/lists/kernel/msg1791681.html
-- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
dri-devel@lists.freedesktop.org