On Thu, Jan 21, 2021 at 9:28 AM Christoph Hellwig hch@lst.de wrote:

On Thu, Jan 21, 2021 at 09:25:40AM +0100, Daniel Vetter wrote:

...

On Thu, Jan 21, 2021 at 8:55 AM Christoph Hellwig hch@lst.de wrote:

...

drm_fb_helper_modinit has a lot of boilerplate for what is not very simple functionality. Just open code it in the only caller using IS_ENABLED and IS_MODULE.

Signed-off-by: Christoph Hellwig hch@lst.de

I didn't spot any dependencies with your series, should I just merge this through drm trees? Or do you want an ack?

I'd prefer an ACK - module_loaded() is only introduced earlier in this series.

I was looking for that but didn't find the hunk touching drm somehow ...

Acked-by: Daniel Vetter daniel.vetter@ffwll.ch

Cheers, Daniel