On Mon, Sep 1, 2014 at 3:20 AM, Randy Dunlap rdunlap@infradead.org wrote:

On 08/31/14 16:07, Max Filippov wrote:

...

Otherwise, if FB is not selected build fails at linking step: vmwgfx_fb.c:(.text+0x4098b): undefined reference to `register_framebuffer' vmwgfx_fb.c:(.text+0x409c0): undefined reference to `framebuffer_release' vmwgfx_fb.c:(.text+0x409f4): undefined reference to `unregister_framebuffer' vmwgfx_fb.c:(.text+0x40a0e): undefined reference to `framebuffer_release'

Patch ae6445ac7475ff05 drm/vmwgfx: depends on FB added dependency on FB that was subsequently removed in patch 04381b987292256d drm: Move plane helpers into drm_kms_helper.ko

Signed-off-by: Max Filippov jcmvbkbc@gmail.com

drivers/gpu/drm/vmwgfx/Kconfig | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/gpu/drm/vmwgfx/Kconfig b/drivers/gpu/drm/vmwgfx/Kconfig index 67720f7..4fba548 100644 --- a/drivers/gpu/drm/vmwgfx/Kconfig +++ b/drivers/gpu/drm/vmwgfx/Kconfig @@ -1,6 +1,7 @@ config DRM_VMWGFX tristate "DRM driver for VMware Virtual GPU" depends on DRM && PCI

• select FB
  select FB_DEFERRED_IO
  select FB_CFB_FILLRECT
  select FB_CFB_COPYAREA
  
  

My experience with these "select FB_*" things is that this symbol (DRM_VMWGFX) should still depend on FB. Has something changed recently to negate that?

I see the following if I replace 'select FB' with 'depends on FB':

drivers/video/fbdev/Kconfig:5:error: recursive dependency detected! drivers/video/fbdev/Kconfig:5: symbol FB is selected by DRM_KMS_FB_HELPER drivers/gpu/drm/Kconfig:39: symbol DRM_KMS_FB_HELPER depends on DRM_KMS_HELPER drivers/gpu/drm/Kconfig:33: symbol DRM_KMS_HELPER is selected by DRM_VMWGFX drivers/gpu/drm/vmwgfx/Kconfig:1: symbol DRM_VMWGFX depends on FB