If IOMMU_SUPPORT is not set, but IOMMU_IOVA is m and COMPILE_TEST is y, building fails:
drivers/gpu/host1x/dev.o: In function `host1x_remove': dev.c:(.text+0x624): undefined reference to `put_iova_domain' dev.c:(.text+0x624): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `put_iova_domain' dev.c:(.text+0x62c): undefined reference to `iova_cache_put' dev.c:(.text+0x62c): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `iova_cache_put'
Select IOMMU_IOVA while COMPILE_TEST is set to fix this.
Reported-by: Hulk Robot hulkci@huawei.com Fixes: 52499a6ad2ae ("gpu: host1x: select IOMMU_IOVA") Signed-off-by: YueHaibing yuehaibing@huawei.com --- drivers/gpu/host1x/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/host1x/Kconfig b/drivers/gpu/host1x/Kconfig index cf987a3..354232d 100644 --- a/drivers/gpu/host1x/Kconfig +++ b/drivers/gpu/host1x/Kconfig @@ -2,7 +2,7 @@ config TEGRA_HOST1X tristate "NVIDIA Tegra host1x driver" depends on ARCH_TEGRA || (ARM && COMPILE_TEST) - select IOMMU_IOVA if IOMMU_SUPPORT + select IOMMU_IOVA if (IOMMU_SUPPORT || COMPILE_TEST) help Driver for the NVIDIA Tegra host1x hardware.
30.10.2019 16:54, YueHaibing пишет:
If IOMMU_SUPPORT is not set, but IOMMU_IOVA is m and COMPILE_TEST is y, building fails:
drivers/gpu/host1x/dev.o: In function `host1x_remove': dev.c:(.text+0x624): undefined reference to `put_iova_domain' dev.c:(.text+0x624): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `put_iova_domain' dev.c:(.text+0x62c): undefined reference to `iova_cache_put' dev.c:(.text+0x62c): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `iova_cache_put'
Select IOMMU_IOVA while COMPILE_TEST is set to fix this.
Reported-by: Hulk Robot hulkci@huawei.com Fixes: 52499a6ad2ae ("gpu: host1x: select IOMMU_IOVA") Signed-off-by: YueHaibing yuehaibing@huawei.com
drivers/gpu/host1x/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/host1x/Kconfig b/drivers/gpu/host1x/Kconfig index cf987a3..354232d 100644 --- a/drivers/gpu/host1x/Kconfig +++ b/drivers/gpu/host1x/Kconfig @@ -2,7 +2,7 @@ config TEGRA_HOST1X tristate "NVIDIA Tegra host1x driver" depends on ARCH_TEGRA || (ARM && COMPILE_TEST)
- select IOMMU_IOVA if IOMMU_SUPPORT
- select IOMMU_IOVA if (IOMMU_SUPPORT || COMPILE_TEST) help Driver for the NVIDIA Tegra host1x hardware.
It should be better to unconditionally select IOMMU_IOVA here.
The same could be done for drivers/staging/media/tegra-vde/ and drivers/gpu/host1x/, please see [1].
[1] https://lore.kernel.org/linux-iommu/20190829154902.GC19842@ulmo/
On 2019/10/31 6:26, Dmitry Osipenko wrote:
30.10.2019 16:54, YueHaibing пишет:
If IOMMU_SUPPORT is not set, but IOMMU_IOVA is m and COMPILE_TEST is y, building fails:
drivers/gpu/host1x/dev.o: In function `host1x_remove': dev.c:(.text+0x624): undefined reference to `put_iova_domain' dev.c:(.text+0x624): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `put_iova_domain' dev.c:(.text+0x62c): undefined reference to `iova_cache_put' dev.c:(.text+0x62c): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `iova_cache_put'
Select IOMMU_IOVA while COMPILE_TEST is set to fix this.
Reported-by: Hulk Robot hulkci@huawei.com Fixes: 52499a6ad2ae ("gpu: host1x: select IOMMU_IOVA") Signed-off-by: YueHaibing yuehaibing@huawei.com
drivers/gpu/host1x/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/host1x/Kconfig b/drivers/gpu/host1x/Kconfig index cf987a3..354232d 100644 --- a/drivers/gpu/host1x/Kconfig +++ b/drivers/gpu/host1x/Kconfig @@ -2,7 +2,7 @@ config TEGRA_HOST1X tristate "NVIDIA Tegra host1x driver" depends on ARCH_TEGRA || (ARM && COMPILE_TEST)
- select IOMMU_IOVA if IOMMU_SUPPORT
- select IOMMU_IOVA if (IOMMU_SUPPORT || COMPILE_TEST) help Driver for the NVIDIA Tegra host1x hardware.
It should be better to unconditionally select IOMMU_IOVA here.
The same could be done for drivers/staging/media/tegra-vde/ and drivers/gpu/host1x/, please see [1].
Yep, I will repost, thanks!
[1] https://lore.kernel.org/linux-iommu/20190829154902.GC19842@ulmo/
.
31.10.2019 16:33, Yuehaibing пишет:
On 2019/10/31 6:26, Dmitry Osipenko wrote:
30.10.2019 16:54, YueHaibing пишет:
If IOMMU_SUPPORT is not set, but IOMMU_IOVA is m and COMPILE_TEST is y, building fails:
drivers/gpu/host1x/dev.o: In function `host1x_remove': dev.c:(.text+0x624): undefined reference to `put_iova_domain' dev.c:(.text+0x624): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `put_iova_domain' dev.c:(.text+0x62c): undefined reference to `iova_cache_put' dev.c:(.text+0x62c): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `iova_cache_put'
Select IOMMU_IOVA while COMPILE_TEST is set to fix this.
Reported-by: Hulk Robot hulkci@huawei.com Fixes: 52499a6ad2ae ("gpu: host1x: select IOMMU_IOVA") Signed-off-by: YueHaibing yuehaibing@huawei.com
drivers/gpu/host1x/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/host1x/Kconfig b/drivers/gpu/host1x/Kconfig index cf987a3..354232d 100644 --- a/drivers/gpu/host1x/Kconfig +++ b/drivers/gpu/host1x/Kconfig @@ -2,7 +2,7 @@ config TEGRA_HOST1X tristate "NVIDIA Tegra host1x driver" depends on ARCH_TEGRA || (ARM && COMPILE_TEST)
- select IOMMU_IOVA if IOMMU_SUPPORT
- select IOMMU_IOVA if (IOMMU_SUPPORT || COMPILE_TEST) help Driver for the NVIDIA Tegra host1x hardware.
It should be better to unconditionally select IOMMU_IOVA here.
The same could be done for drivers/staging/media/tegra-vde/ and drivers/gpu/host1x/, please see [1].
Yep, I will repost, thanks!
Oh, I missed that you made a patch for host1x and not for drm. Thus drivers/gpu/drm/tegra/ also needs the same change.
[1] https://lore.kernel.org/linux-iommu/20190829154902.GC19842@ulmo/
On Thu, Oct 31, 2019 at 09:33:38PM +0800, Yuehaibing wrote:
On 2019/10/31 6:26, Dmitry Osipenko wrote:
30.10.2019 16:54, YueHaibing пишет:
If IOMMU_SUPPORT is not set, but IOMMU_IOVA is m and COMPILE_TEST is y, building fails:
drivers/gpu/host1x/dev.o: In function `host1x_remove': dev.c:(.text+0x624): undefined reference to `put_iova_domain' dev.c:(.text+0x624): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `put_iova_domain' dev.c:(.text+0x62c): undefined reference to `iova_cache_put' dev.c:(.text+0x62c): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `iova_cache_put'
Select IOMMU_IOVA while COMPILE_TEST is set to fix this.
Reported-by: Hulk Robot hulkci@huawei.com Fixes: 52499a6ad2ae ("gpu: host1x: select IOMMU_IOVA") Signed-off-by: YueHaibing yuehaibing@huawei.com
drivers/gpu/host1x/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/host1x/Kconfig b/drivers/gpu/host1x/Kconfig index cf987a3..354232d 100644 --- a/drivers/gpu/host1x/Kconfig +++ b/drivers/gpu/host1x/Kconfig @@ -2,7 +2,7 @@ config TEGRA_HOST1X tristate "NVIDIA Tegra host1x driver" depends on ARCH_TEGRA || (ARM && COMPILE_TEST)
- select IOMMU_IOVA if IOMMU_SUPPORT
- select IOMMU_IOVA if (IOMMU_SUPPORT || COMPILE_TEST) help Driver for the NVIDIA Tegra host1x hardware.
It should be better to unconditionally select IOMMU_IOVA here.
The same could be done for drivers/staging/media/tegra-vde/ and drivers/gpu/host1x/, please see [1].
Yep, I will repost, thanks!
No need to resend, I already have patches for that.
Thierry
On 2019/11/1 17:47, Thierry Reding wrote:
On Thu, Oct 31, 2019 at 09:33:38PM +0800, Yuehaibing wrote:
On 2019/10/31 6:26, Dmitry Osipenko wrote:
30.10.2019 16:54, YueHaibing пишет:
If IOMMU_SUPPORT is not set, but IOMMU_IOVA is m and COMPILE_TEST is y, building fails:
drivers/gpu/host1x/dev.o: In function `host1x_remove': dev.c:(.text+0x624): undefined reference to `put_iova_domain' dev.c:(.text+0x624): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `put_iova_domain' dev.c:(.text+0x62c): undefined reference to `iova_cache_put' dev.c:(.text+0x62c): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `iova_cache_put'
Select IOMMU_IOVA while COMPILE_TEST is set to fix this.
Reported-by: Hulk Robot hulkci@huawei.com Fixes: 52499a6ad2ae ("gpu: host1x: select IOMMU_IOVA") Signed-off-by: YueHaibing yuehaibing@huawei.com
drivers/gpu/host1x/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/host1x/Kconfig b/drivers/gpu/host1x/Kconfig index cf987a3..354232d 100644 --- a/drivers/gpu/host1x/Kconfig +++ b/drivers/gpu/host1x/Kconfig @@ -2,7 +2,7 @@ config TEGRA_HOST1X tristate "NVIDIA Tegra host1x driver" depends on ARCH_TEGRA || (ARM && COMPILE_TEST)
- select IOMMU_IOVA if IOMMU_SUPPORT
- select IOMMU_IOVA if (IOMMU_SUPPORT || COMPILE_TEST) help Driver for the NVIDIA Tegra host1x hardware.
It should be better to unconditionally select IOMMU_IOVA here.
The same could be done for drivers/staging/media/tegra-vde/ and drivers/gpu/host1x/, please see [1].
Yep, I will repost, thanks!
No need to resend, I already have patches for that.
Ok, thanks!
Thierry
dri-devel@lists.freedesktop.org
-
Dmitry Osipenko -
Thierry Reding -
YueHaibing -
Yuehaibing