From: Xuezhi Zhang zhangxuezhi1@yulong.com
show() must not use snprintf() when formatting the value to be returned to user space.
Signed-off-by: Xuezhi Zhang zhangxuezhi1@yulong.com --- drivers/staging/fbtft/fbtft-sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fbtft/fbtft-sysfs.c b/drivers/staging/fbtft/fbtft-sysfs.c index 26e52cc2de64..7df92db648d6 100644 --- a/drivers/staging/fbtft/fbtft-sysfs.c +++ b/drivers/staging/fbtft/fbtft-sysfs.c @@ -199,7 +199,7 @@ static ssize_t show_debug(struct device *device, struct fb_info *fb_info = dev_get_drvdata(device); struct fbtft_par *par = fb_info->par;
- return snprintf(buf, PAGE_SIZE, "%lu\n", par->debug); + return scnprintf(buf, PAGE_SIZE, "%lu\n", par->debug); }
static struct device_attribute debug_device_attr =
On Fri, Apr 02, 2021 at 09:05:01AM +0000, Carlis wrote:
From: Xuezhi Zhang zhangxuezhi1@yulong.com
show() must not use snprintf() when formatting the value to be returned to user space.
Why not? The code is just fine as-is.
Signed-off-by: Xuezhi Zhang zhangxuezhi1@yulong.com
drivers/staging/fbtft/fbtft-sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fbtft/fbtft-sysfs.c b/drivers/staging/fbtft/fbtft-sysfs.c index 26e52cc2de64..7df92db648d6 100644 --- a/drivers/staging/fbtft/fbtft-sysfs.c +++ b/drivers/staging/fbtft/fbtft-sysfs.c @@ -199,7 +199,7 @@ static ssize_t show_debug(struct device *device, struct fb_info *fb_info = dev_get_drvdata(device); struct fbtft_par *par = fb_info->par;
- return snprintf(buf, PAGE_SIZE, "%lu\n", par->debug);
- return scnprintf(buf, PAGE_SIZE, "%lu\n", par->debug);
If you really want to "fix" this, please just use sysfs_emit(). This change as-is, does nothing.
thanks,
greg k-h
dri-devel@lists.freedesktop.org
-
Carlis -
Greg KH