By Vesa's DP 1.2 Spec this counter has 4 bits [3:0].
This mask is wrong since when the counter was introduced by myself on commit ad9dc91b6e21266bfc6f466db4b95e10211f31ee Author: Rodrigo Vivi rodrigo.vivi@gmail.com Date: Tue Sep 16 19:18:12 2014 -0400
drm/i915: Fix Sink CRC
Signed-off-by: Rodrigo Vivi rodrigo.vivi@intel.com --- include/drm/drm_dp_helper.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h index 2e86f64..94898f6 100644 --- a/include/drm/drm_dp_helper.h +++ b/include/drm/drm_dp_helper.h @@ -420,7 +420,7 @@
#define DP_TEST_SINK_MISC 0x246 # define DP_TEST_CRC_SUPPORTED (1 << 5) -# define DP_TEST_COUNT_MASK 0x7 +# define DP_TEST_COUNT_MASK 0xf
#define DP_TEST_RESPONSE 0x260 # define DP_TEST_ACK (1 << 0)
Reviewed-by: Sivakumar Thulasimani sivakumar.thulasimani@intel.com
On 7/24/2015 5:04 AM, Rodrigo Vivi wrote:
By Vesa's DP 1.2 Spec this counter has 4 bits [3:0].
This mask is wrong since when the counter was introduced by myself on commit ad9dc91b6e21266bfc6f466db4b95e10211f31ee Author: Rodrigo Vivi rodrigo.vivi@gmail.com Date: Tue Sep 16 19:18:12 2014 -0400
drm/i915: Fix Sink CRCSigned-off-by: Rodrigo Vivi rodrigo.vivi@intel.com
include/drm/drm_dp_helper.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h index 2e86f64..94898f6 100644 --- a/include/drm/drm_dp_helper.h +++ b/include/drm/drm_dp_helper.h @@ -420,7 +420,7 @@
#define DP_TEST_SINK_MISC 0x246 # define DP_TEST_CRC_SUPPORTED (1 << 5) -# define DP_TEST_COUNT_MASK 0x7 +# define DP_TEST_COUNT_MASK 0xf
#define DP_TEST_RESPONSE 0x260 # define DP_TEST_ACK (1 << 0)
On Thu, Jul 23, 2015 at 04:34:58PM -0700, Rodrigo Vivi wrote:
By Vesa's DP 1.2 Spec this counter has 4 bits [3:0].
This mask is wrong since when the counter was introduced by myself on commit ad9dc91b6e21266bfc6f466db4b95e10211f31ee Author: Rodrigo Vivi rodrigo.vivi@gmail.com Date: Tue Sep 16 19:18:12 2014 -0400
drm/i915: Fix Sink CRCSigned-off-by: Rodrigo Vivi rodrigo.vivi@intel.com
include/drm/drm_dp_helper.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h index 2e86f64..94898f6 100644 --- a/include/drm/drm_dp_helper.h +++ b/include/drm/drm_dp_helper.h @@ -420,7 +420,7 @@
#define DP_TEST_SINK_MISC 0x246 # define DP_TEST_CRC_SUPPORTED (1 << 5) -# define DP_TEST_COUNT_MASK 0x7 +# define DP_TEST_COUNT_MASK 0xf
According to the specification this field should really be called DP_TEST_CRC_COUNT_MASK, because it counts the number of times that the TEST_CRC_* registers are updated. That could be a separate patch, though.
Thierry
dri-devel@lists.freedesktop.org
-
Rodrigo Vivi -
Sivakumar Thulasimani -
Thierry Reding