drm_helper_probe_single_connector_modes() can be used to implement ->fill_modes(), not ->probe().
Signed-off-by: Damien Lespiau damien.lespiau@intel.com --- drivers/gpu/drm/drm_crtc_helper.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c index 4280e37..5fcb9d4 100644 --- a/drivers/gpu/drm/drm_crtc_helper.c +++ b/drivers/gpu/drm/drm_crtc_helper.c @@ -109,9 +109,9 @@ static void drm_mode_validate_flag(struct drm_connector *connector, * then culled (based on validity and the @maxX, @maxY parameters) and put into * the normal modes list. * - * Intended to be use as a generic implementation of the ->probe() @connector - * callback for drivers that use the crtc helpers for output mode filtering and - * detection. + * Intended to be use as a generic implementation of the ->fill_modes() + * @connector vfunc for drivers that use the crtc helpers for output mode + * filtering and detection. * * RETURNS: * Number of modes found on @connector.
On Mon, Sep 23, 2013 at 02:48:09PM +0100, Damien Lespiau wrote:
drm_helper_probe_single_connector_modes() can be used to implement ->fill_modes(), not ->probe().
Signed-off-by: Damien Lespiau damien.lespiau@intel.com
Reviewed-by: Daniel Vetter daniel.vetter@ffwll.ch
drivers/gpu/drm/drm_crtc_helper.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c index 4280e37..5fcb9d4 100644 --- a/drivers/gpu/drm/drm_crtc_helper.c +++ b/drivers/gpu/drm/drm_crtc_helper.c @@ -109,9 +109,9 @@ static void drm_mode_validate_flag(struct drm_connector *connector,
- then culled (based on validity and the @maxX, @maxY parameters) and put into
- the normal modes list.
- Intended to be use as a generic implementation of the ->probe() @connector
- callback for drivers that use the crtc helpers for output mode filtering and
- detection.
- Intended to be use as a generic implementation of the ->fill_modes()
- @connector vfunc for drivers that use the crtc helpers for output mode
- filtering and detection.
- RETURNS:
- Number of modes found on @connector.
-- 1.8.3.1
dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
dri-devel@lists.freedesktop.org
-
Damien Lespiau -
Daniel Vetter