The timings issue is still here, this version is just some modifications in dts file.
Randy Li (2): ARM: dts: samsung: add rga-lvds panel in itop elite drm/panel: Add support for Chunghwa CLAA070WP03XG panel
.../display/panel/chunghwa,claa070wp03xg.txt | 7 +++ arch/arm/boot/dts/exynos4412-itop-elite.dts | 54 +++++++++++++++++++++- drivers/gpu/drm/panel/panel-simple.c | 27 +++++++++++ 3 files changed, 86 insertions(+), 2 deletions(-) create mode 100644 Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt
It is actually a lvds panel connected through a rga-lvds bridge. The touchscreen is communicated with i2c bus but the driver is not support now.
Signed-off-by: Randy Li ayaka@soulik.info --- arch/arm/boot/dts/exynos4412-itop-elite.dts | 54 +++++++++++++++++++++++++++-- 1 file changed, 52 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/exynos4412-itop-elite.dts b/arch/arm/boot/dts/exynos4412-itop-elite.dts index b08705e..5153522 100644 --- a/arch/arm/boot/dts/exynos4412-itop-elite.dts +++ b/arch/arm/boot/dts/exynos4412-itop-elite.dts @@ -138,6 +138,36 @@ assigned-clocks = <&clock CLK_MOUT_CAM0>; assigned-clock-parents = <&clock CLK_XUSBXTI>; }; + + vcc_sys_lcd: sys-lcd { + compatible = "regulator-fixed"; + regulator-name = "vcc_5v"; + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + gpio = <&gpl0 4 GPIO_ACTIVE_HIGH>; + }; + + panel: panel@0 { + compatible = "chunghwa,claa070wp03xg"; + + power-supply = <&vcc_sys_lcd>; + enable-gpios = <&gpl0 2 GPIO_ACTIVE_HIGH>; + backlight = <&bl>; + + port { + lcd_ep: endpoint { + remote-endpoint = <&rga_lvds>; + }; + }; + }; + + bl: backlight { + compatible = "pwm-backlight"; + pwms = <&pwm 1 5000000 PWM_POLARITY_INVERTED>; + brightness-levels = <0 5 12 16 32 64 128 255>; + default-brightness-level = <5>; + power-supply = <&vcc_sys_lcd>; + }; };
&adc { @@ -171,11 +201,31 @@ assigned-clock-rates = <0>, <176000000>; };
+&fimd { + pinctrl-0 = <&lcd_clk &lcd_data24>; + pinctrl-names = "default"; + status = "okay"; + ports { + #address-cells = <1>; + #size-cells = <0>; + port@3 { + reg = <3>; + rga_lvds: endpoint { + remote-endpoint = <&lcd_ep>; + }; + }; + }; +}; + &hsotg { dr_mode = "peripheral"; status = "okay"; };
+&i2c_3 { + status = "okay"; +}; + &i2c_4 { samsung,i2c-sda-delay = <100>; samsung,i2c-slave-addr = <0x10>; @@ -215,9 +265,9 @@
&pwm { status = "okay"; - pinctrl-0 = <&pwm0_out>; + pinctrl-0 = <&pwm0_out &pwm1_out>; pinctrl-names = "default"; - samsung,pwm-outputs = <0>; + samsung,pwm-outputs = <0>, <1>; };
&sdhci_2 {
On Mon, Sep 19, 2016 at 4:02 PM, Randy Li ayaka@soulik.info wrote:
vcc_sys_lcd: sys-lcd {compatible = "regulator-fixed";regulator-name = "vcc_5v";regulator-min-microvolt = <5000000>;regulator-max-microvolt = <5000000>;gpio = <&gpl0 4 GPIO_ACTIVE_HIGH>;
Is this really active high? If so, you should add the 'enable-active-high' property.
On 09/20/2016 03:12 AM, Fabio Estevam wrote:
On Mon, Sep 19, 2016 at 4:02 PM, Randy Li ayaka@soulik.info wrote:
vcc_sys_lcd: sys-lcd {compatible = "regulator-fixed";regulator-name = "vcc_5v";regulator-min-microvolt = <5000000>;regulator-max-microvolt = <5000000>;gpio = <&gpl0 4 GPIO_ACTIVE_HIGH>;Is this really active high? If so, you should add the 'enable-active-high' property.
I see, thank you. Btw, let me make it clearly, it is really an independentTransistor, not be controlled by PMIC.
The Chunghwa CLAA070WP03XG is a 7" 1280x800 panel, which can be supported by the simple panel driver.
Signed-off-by: Randy Li ayaka@soulik.info --- .../display/panel/chunghwa,claa070wp03xg.txt | 7 ++++++ drivers/gpu/drm/panel/panel-simple.c | 27 ++++++++++++++++++++++ 2 files changed, 34 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt
diff --git a/Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt b/Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt new file mode 100644 index 0000000..dd22685 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt @@ -0,0 +1,7 @@ +Chunghwa Picture Tubes Ltd. 7" WXGA TFT LCD panel + +Required properties: +- compatible: should be "chunghwa,claa070wp03xg" + +This binding is compatible with the simple-panel binding, which is specified +in simple-panel.txt in this directory. diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index f178998..3204e6b 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -583,6 +583,30 @@ static const struct panel_desc avic_tm070ddh03 = { }, };
+static const struct drm_display_mode chunghwa_claa070wp03xg_mode = { + .clock = 66770, + .hdisplay = 800, + .hsync_start = 800 + 49, + .hsync_end = 800 + 49 + 33, + .htotal = 800 + 49 + 33 + 17, + .vdisplay = 1280, + .vsync_start = 1280 + 1, + .vsync_end = 1280 + 1 + 7, + .vtotal = 1280 + 1 + 7 + 15, + .vrefresh = 60, + .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC, +}; + +static const struct panel_desc chunghwa_claa070wp03xg = { + .modes = &chunghwa_claa070wp03xg_mode, + .num_modes = 1, + .bpc = 6, + .size = { + .width = 94, + .height = 150, + }, +}; + static const struct drm_display_mode chunghwa_claa101wa01a_mode = { .clock = 72070, .hdisplay = 1366, @@ -1544,6 +1568,9 @@ static const struct of_device_id platform_of_match[] = { .compatible = "avic,tm070ddh03", .data = &avic_tm070ddh03, }, { + .compatible = "chunghwa,claa070wp03xg", + .data = &chunghwa_claa070wp03xg, + }, { .compatible = "chunghwa,claa101wa01a", .data = &chunghwa_claa101wa01a }, {
On Tue, Sep 20, 2016 at 03:02:51AM +0800, Randy Li wrote:
The Chunghwa CLAA070WP03XG is a 7" 1280x800 panel, which can be supported by the simple panel driver.
Signed-off-by: Randy Li ayaka@soulik.info
.../display/panel/chunghwa,claa070wp03xg.txt | 7 ++++++ drivers/gpu/drm/panel/panel-simple.c | 27 ++++++++++++++++++++++ 2 files changed, 34 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt
diff --git a/Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt b/Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt new file mode 100644 index 0000000..dd22685 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt @@ -0,0 +1,7 @@ +Chunghwa Picture Tubes Ltd. 7" WXGA TFT LCD panel
+Required properties: +- compatible: should be "chunghwa,claa070wp03xg"
What about VCC, VLED, LED_EN (PWM), LVBIT, LVFMT, DITHER signals?
+This binding is compatible with the simple-panel binding, which is specified +in simple-panel.txt in this directory.
On 09/24/2016 02:00 AM, Rob Herring wrote:
On Tue, Sep 20, 2016 at 03:02:51AM +0800, Randy Li wrote:
The Chunghwa CLAA070WP03XG is a 7" 1280x800 panel, which can be supported by the simple panel driver.
Signed-off-by: Randy Li ayaka@soulik.info
.../display/panel/chunghwa,claa070wp03xg.txt | 7 ++++++ drivers/gpu/drm/panel/panel-simple.c | 27 ++++++++++++++++++++++ 2 files changed, 34 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt
diff --git a/Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt b/Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt new file mode 100644 index 0000000..dd22685 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt @@ -0,0 +1,7 @@ +Chunghwa Picture Tubes Ltd. 7" WXGA TFT LCD panel
+Required properties: +- compatible: should be "chunghwa,claa070wp03xg"
What about VCC, VLED, LED_EN (PWM), LVBIT, LVFMT, DITHER signals?
I didn't see the other simple-panel has that, so I didn't neither. And I think it would only have VCC and LED_EN(PWM).
+This binding is compatible with the simple-panel binding, which is specified +in simple-panel.txt in this directory.
On Tue, Sep 20, 2016 at 03:02:51AM +0800, Randy Li wrote:
The Chunghwa CLAA070WP03XG is a 7" 1280x800 panel, which can be supported by the simple panel driver.
Signed-off-by: Randy Li ayaka@soulik.info
.../display/panel/chunghwa,claa070wp03xg.txt | 7 ++++++ drivers/gpu/drm/panel/panel-simple.c | 27 ++++++++++++++++++++++ 2 files changed, 34 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt
Applied, thanks.
Thierry
從我的 iPad 傳送
Thierry Reding thierry.reding@gmail.com 於 2016年12月6日 下午11:46 寫道：
On Tue, Sep 20, 2016 at 03:02:51AM +0800, Randy Li wrote: The Chunghwa CLAA070WP03XG is a 7" 1280x800 panel, which can be supported by the simple panel driver.
Signed-off-by: Randy Li ayaka@soulik.info
.../display/panel/chunghwa,claa070wp03xg.txt | 7 ++++++ drivers/gpu/drm/panel/panel-simple.c | 27 ++++++++++++++++++++++ 2 files changed, 34 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt
Applied, thanks.
Wait, it is RFC, not pass the test.
Thierry
On Wed, Dec 07, 2016 at 08:57:23AM +0800, Ayaka wrote:
從我的 iPad 傳送
Thierry Reding thierry.reding@gmail.com 於 2016年12月6日 下午11:46 寫道：
On Tue, Sep 20, 2016 at 03:02:51AM +0800, Randy Li wrote: The Chunghwa CLAA070WP03XG is a 7" 1280x800 panel, which can be supported by the simple panel driver.
Signed-off-by: Randy Li ayaka@soulik.info
.../display/panel/chunghwa,claa070wp03xg.txt | 7 ++++++ drivers/gpu/drm/panel/panel-simple.c | 27 ++++++++++++++++++++++ 2 files changed, 34 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt
Applied, thanks.
Wait, it is RFC, not pass the test.
Well 2 months of silence, it's reasonable to assume that this works for you ... I guess you need to supply a fixup patch asap ;-) -Daniel
On 12/07/2016 10:55 PM, Daniel Vetter wrote:
On Wed, Dec 07, 2016 at 08:57:23AM +0800, Ayaka wrote:
從我的 iPad 傳送
Thierry Reding thierry.reding@gmail.com 於 2016年12月6日 下午11:46 寫道：
On Tue, Sep 20, 2016 at 03:02:51AM +0800, Randy Li wrote: The Chunghwa CLAA070WP03XG is a 7" 1280x800 panel, which can be supported by the simple panel driver.
Signed-off-by: Randy Li ayaka@soulik.info
.../display/panel/chunghwa,claa070wp03xg.txt | 7 ++++++ drivers/gpu/drm/panel/panel-simple.c | 27 ++++++++++++++++++++++ 2 files changed, 34 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt
Applied, thanks.
Wait, it is RFC, not pass the test.
Well 2 months of silence, it's reasonable to assume that this works for you ... I guess you need to supply a fixup patch asap ;-)
Sorry, my exynos 4412 board is broken, I will order one and fix this problem, please don't merge this patch until somebody confirm that it is adjusted to correct parameter.
-Daniel
dri-devel@lists.freedesktop.org
-
ayaka -
Ayaka
-
Daniel Vetter -
Fabio Estevam -
Randy Li
-
Rob Herring -
Thierry Reding