There is a mistake here so it returns PTR_ERR(NULL) which is success instead of -ENOMEM.
Signed-off-by: Dan Carpenter dan.carpenter@oracle.com --- I can't compile this.
diff --git a/drivers/gpu/host1x/job.c b/drivers/gpu/host1x/job.c index cc80766..6cf41da 100644 --- a/drivers/gpu/host1x/job.c +++ b/drivers/gpu/host1x/job.c @@ -466,9 +466,8 @@ static inline int copy_gathers(struct host1x_job *job, struct device *dev) &job->gather_copy, GFP_KERNEL); if (!job->gather_copy_mapped) { - int err = PTR_ERR(job->gather_copy_mapped); job->gather_copy_mapped = NULL; - return err; + return -ENOMEM; }
job->gather_copy_size = size;
On 08/23/2013 04:19 AM, Dan Carpenter wrote:
There is a mistake here so it returns PTR_ERR(NULL) which is success instead of -ENOMEM.
Signed-off-by: Dan Carpenter dan.carpenter@oracle.com
I can't compile this.
For the record, just do:
export CROSS_COMPILE=xxx make ARCH=arm tegra_defconfig make ARCH=arm zImage
The only slightly difficult part is getting a CROSS_COMPILE value. Many distros ship at least some ARM cross-compiler in their standard package-set these days, and if not, you can download the Linaro compilers or go to ftp://ftp.kernel.org/pub/tools/crosstool/index.html.
On Fri, Aug 23, 2013 at 01:19:11PM +0300, Dan Carpenter wrote:
There is a mistake here so it returns PTR_ERR(NULL) which is success instead of -ENOMEM.
Signed-off-by: Dan Carpenter dan.carpenter@oracle.com
I can't compile this.
Good catch! Applied, thanks.
Thierry
dri-devel@lists.freedesktop.org
-
Dan Carpenter -
Stephen Warren -
Thierry Reding