Sorry for the mistake, i made a typo when correcting the indentation issue i had. here is the correct patch and also the dmidecode from the thin client.

--- linux-3.2.0/drivers/gpu/drm/i915/intel_lvds.c 2011-12-24 10:23:08.000000000 -0500 +++ intel_lvds.c 2012-01-04 14:03:49.134573275 -0500 @@ -723,6 +723,14 @@ DMI_MATCH(DMI_BOARD_NAME, "AT5NM10T-I"), }, }, + { + .callback = intel_no_lvds_dmi_callback, + .ident = "Hewlett-Packard t5745", + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "Hewlett-Packard"), + DMI_MATCH(DMI_BOARD_NAME, "hp t5745"), + }, + },

{ } /* terminating entry */ };

On Wed, Jan 4, 2012 at 2:58 PM, Adam Jackson ajax@redhat.com wrote:

On Wed, 2012-01-04 at 14:08 -0500, Marc Gariépy wrote:

...

Hello,

I've been directed here by Stephane Graber. I need to blacklist the LVDS port on some hp t5745 thin client.

Here is the bug link: https://bugs.launchpad.net/bugs/911916

Does this actually work? The bug above doesn't include the dmidecode output, and...

...

•       DMI_MATCH(DMI_BOARD_VENDOR, "Hewlett-Packard"),
  

•       DMI_MATCH(DMI_BOARD_NAME, "hp st5745"),
  

I would normally expect HP to capitalize their own name correctly.

• ajax

Hello,

Here is the patch made from the git git:// git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git

The dmidecode for hp t5745 and hp st5747 are attached to their respective bugs: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/911916 https://bugs.launchpad.net/ubuntu/+source/linux/+bug/911920

This patch disable the LVDS on hp t5745 and hp st5747 thin client.

diff --git a/drivers/gpu/drm/i915/intel_lvds.c b/drivers/gpu/drm/i915/intel_lvds.c index 798f6e1..069f9ba 100644 --- a/drivers/gpu/drm/i915/intel_lvds.c +++ b/drivers/gpu/drm/i915/intel_lvds.c @@ -731,6 +731,22 @@ static const struct dmi_system_id intel_no_lvds[] = { DMI_MATCH(DMI_BOARD_NAME, "AT5NM10T-I"), }, }, + { + .callback = intel_no_lvds_dmi_callback, + .ident = "Hewlett-Packard t5745", + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "Hewlett-Packard"), + DMI_MATCH(DMI_BOARD_NAME, "hp t5745"), + }, + }, + { + .callback = intel_no_lvds_dmi_callback, + .ident = "Hewlett-Packard st5747", + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "Hewlett-Packard"), + DMI_MATCH(DMI_BOARD_NAME, "hp st5747"), + }, + },

{ } /* terminating entry */ };

Signed-off-by: Marc Gariépy mgariepy@ubuntu.com

On Thu, Jan 26, 2012 at 8:38 AM, Marc Gariépy mgariepy@ubuntu.com wrote:

Hello,

I attached the dmidecode on launchpad bug.

Here is what i have in dmidecode for the hp t5745.

System Information Manufacturer: Hewlett-Packard Product Name: hp t5745

Marc

On Mon, Jan 23, 2012 at 11:32 AM, Adam Jackson ajax@redhat.com wrote:

...

On Tue, 2012-01-17 at 17:31 +0100, Daniel Vetter wrote:

...

On Wed, Jan 04, 2012 at 05:50:36PM -0500, Marc Gariépy wrote:

...

Sorry for the mistake, i made a typo when correcting the indentation

issue

...

...

i had. here is the correct patch and also the dmidecode from the thin client.

Signed-Off-by is misssing, see Documentation/SubmittingPatches. Also please combine this with the other no-lvds patch. I'd also like Adam to ack it, so put him on cc when resubmitting.

I would like to see my question addressed before acking. Pretty sure dmi matching is case sensitive.

• ajax