drm: include missing types header to drm_mode.h
Signed-off-by: Davidlohr Bueso dave@gnu.org --- include/drm/drm_mode.h | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/include/drm/drm_mode.h b/include/drm/drm_mode.h index 0fc7397..eddd7f4 100644 --- a/include/drm/drm_mode.h +++ b/include/drm/drm_mode.h @@ -24,6 +24,8 @@ * IN THE SOFTWARE. */
+#include <linux/types.h> + #ifndef _DRM_MODE_H #define _DRM_MODE_H
On Fri, 22 Oct 2010 10:13:19 -0300 Davidlohr Bueso dave@gnu.org wrote:
drm: include missing types header to drm_mode.h
Signed-off-by: Davidlohr Bueso dave@gnu.org
include/drm/drm_mode.h | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/include/drm/drm_mode.h b/include/drm/drm_mode.h index 0fc7397..eddd7f4 100644 --- a/include/drm/drm_mode.h +++ b/include/drm/drm_mode.h @@ -24,6 +24,8 @@
- IN THE SOFTWARE.
*/
+#include <linux/types.h>
#ifndef _DRM_MODE_H #define _DRM_MODE_H
Does this fix a build error? If so, please send along the compiler error output.
On Fri, 22 Oct 2010 16:55:17 -0700 Andrew Morton wrote:
On Fri, 22 Oct 2010 10:13:19 -0300 Davidlohr Bueso dave@gnu.org wrote:
drm: include missing types header to drm_mode.h
Signed-off-by: Davidlohr Bueso dave@gnu.org
include/drm/drm_mode.h | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/include/drm/drm_mode.h b/include/drm/drm_mode.h index 0fc7397..eddd7f4 100644 --- a/include/drm/drm_mode.h +++ b/include/drm/drm_mode.h @@ -24,6 +24,8 @@
- IN THE SOFTWARE.
*/
+#include <linux/types.h>
#ifndef _DRM_MODE_H #define _DRM_MODE_H
Does this fix a build error? If so, please send along the compiler error output.
Every build that has CONFIG_HEADERS_CHECK=y reports the following:
linux-next-20101022/X64/usr/include/drm/drm_mode.h:85: found __[us]{8,16,32,64} type without #include <linux/types.h> linux-next-20101022/X64/usr/include/drm/i915_drm.h:120: found __[us]{8,16,32,64} type without #include <linux/types.h> linux-next-20101022/X64/usr/include/drm/mga_drm.h:260: found __[us]{8,16,32,64} type without #include <linux/types.h> linux-next-20101022/X64/usr/include/drm/radeon_drm.h:758: found __[us]{8,16,32,64} type without #include <linux/types.h> linux-next-20101022/X64/usr/include/drm/via_drm.h:117: found __[us]{8,16,32,64} type without #include <linux/types.h> linux-next-20101022/X64/usr/include/scsi/scsi_netlink.h:108: found __[us]{8,16,32,64} type without #include <linux/types.h> linux-next-20101022/X64/usr/include/linux/resource.h:49: found __[us]{8,16,32,64} type without #include <linux/types.h>
--- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***
On Sat, Oct 23, 2010 at 10:02 AM, Randy Dunlap rdunlap@xenotime.net wrote:
On Fri, 22 Oct 2010 16:55:17 -0700 Andrew Morton wrote:
On Fri, 22 Oct 2010 10:13:19 -0300 Davidlohr Bueso dave@gnu.org wrote:
drm: include missing types header to drm_mode.h
Signed-off-by: Davidlohr Bueso dave@gnu.org
include/drm/drm_mode.h | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/include/drm/drm_mode.h b/include/drm/drm_mode.h index 0fc7397..eddd7f4 100644 --- a/include/drm/drm_mode.h +++ b/include/drm/drm_mode.h @@ -24,6 +24,8 @@ * IN THE SOFTWARE. */
+#include <linux/types.h>
#ifndef _DRM_MODE_H #define _DRM_MODE_H
Does this fix a build error? If so, please send along the compiler error output.
Every build that has CONFIG_HEADERS_CHECK=y reports the following:
linux-next-20101022/X64/usr/include/drm/drm_mode.h:85: found __[us]{8,16,32,64} type without #include <linux/types.h> linux-next-20101022/X64/usr/include/drm/i915_drm.h:120: found __[us]{8,16,32,64} type without #include <linux/types.h> linux-next-20101022/X64/usr/include/drm/mga_drm.h:260: found __[us]{8,16,32,64} type without #include <linux/types.h> linux-next-20101022/X64/usr/include/drm/radeon_drm.h:758: found __[us]{8,16,32,64} type without #include <linux/types.h> linux-next-20101022/X64/usr/include/drm/via_drm.h:117: found __[us]{8,16,32,64} type without #include <linux/types.h> linux-next-20101022/X64/usr/include/scsi/scsi_netlink.h:108: found __[us]{8,16,32,64} type without #include <linux/types.h> linux-next-20101022/X64/usr/include/linux/resource.h:49: found __[us]{8,16,32,64} type without #include <linux/types.h>
Why doesn't the tool understand header recursion? drm_mode.h needs to include drm.h but the rest already include drm.h.
Including drm.h includes linux/types.h if defined(__linux__)
So really I've said this a few times now, its the stupid tool that is broken for most of these, fix the tool and I'll fix drm_mode.h
Dave.
On Fri, 2010-10-22 at 17:02 -0700, Randy Dunlap wrote:
On Fri, 22 Oct 2010 16:55:17 -0700 Andrew Morton wrote:
On Fri, 22 Oct 2010 10:13:19 -0300 Davidlohr Bueso dave@gnu.org wrote:
drm: include missing types header to drm_mode.h
Signed-off-by: Davidlohr Bueso dave@gnu.org
include/drm/drm_mode.h | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/include/drm/drm_mode.h b/include/drm/drm_mode.h index 0fc7397..eddd7f4 100644 --- a/include/drm/drm_mode.h +++ b/include/drm/drm_mode.h @@ -24,6 +24,8 @@
- IN THE SOFTWARE.
*/
+#include <linux/types.h>
#ifndef _DRM_MODE_H #define _DRM_MODE_H
Does this fix a build error? If so, please send along the compiler error output.
Every build that has CONFIG_HEADERS_CHECK=y reports the following:
linux-next-20101022/X64/usr/include/drm/drm_mode.h:85: found __[us]{8,16,32,64} type without #include <linux/types.h> linux-next-20101022/X64/usr/include/drm/i915_drm.h:120: found __[us]{8,16,32,64} type without #include <linux/types.h> linux-next-20101022/X64/usr/include/drm/mga_drm.h:260: found __[us]{8,16,32,64} type without #include <linux/types.h> linux-next-20101022/X64/usr/include/drm/radeon_drm.h:758: found __[us]{8,16,32,64} type without #include <linux/types.h> linux-next-20101022/X64/usr/include/drm/via_drm.h:117: found __[us]{8,16,32,64} type without #include <linux/types.h> linux-next-20101022/X64/usr/include/scsi/scsi_netlink.h:108: found __[us]{8,16,32,64} type without #include <linux/types.h> linux-next-20101022/X64/usr/include/linux/resource.h:49: found __[us]{8,16,32,64} type without #include <linux/types.h>
Yeah that's what made me send the patch.
Thanks, Davidlohr
dri-devel@lists.freedesktop.org
-
Andrew Morton -
Dave Airlie -
Davidlohr Bueso -
Randy Dunlap