https://bugs.freedesktop.org/show_bug.cgi?id=105379
Bug ID: 105379 Summary: The Witcher: Enhanced Edition under Wine fails to launch Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/radeonsi Assignee: dri-devel@lists.freedesktop.org Reporter: asheldon55@gmail.com QA Contact: dri-devel@lists.freedesktop.org
Created attachment 137850 --> https://bugs.freedesktop.org/attachment.cgi?id=137850&action=edit Wine log with Mesa git
The Witcher run under Wine fails to launch. Essentially, it hangs indefinitely before any video output but the game can be closed with Ctrl-C, and no ill effects are seen otherwise. Reverting commit b650fc09c3a35ca624aad5fe4b5c34867708f116 in Mesa works around the issue. The game also works fine with a Nvidia 980ti and 390.25 binary drivers.
Hardware: Radeon RX 550 Software: 4.15.6 kernel [DC=0], Mesa git, Wine 3.3
Commit message:
commit b650fc09c3a35ca624aad5fe4b5c34867708f116 Author: Nicolai Hähnle nicolai.haehnle@amd.com Date: Sun Oct 22 17:38:42 2017 +0200
radeonsi: fix potential use-after-free of debug callbacks
Found by inspection.
Reviewed-by: Marek Olšák marek.olsak@amd.com
https://bugs.freedesktop.org/show_bug.cgi?id=105379
--- Comment #1 from Andrew Sheldon asheldon55@gmail.com --- Created attachment 137851 --> https://bugs.freedesktop.org/attachment.cgi?id=137851&action=edit Wine log with mesa git and reverted commit
https://bugs.freedesktop.org/show_bug.cgi?id=105379
--- Comment #2 from Matias N. Goldberg dark_sylinc@yahoo.com.ar --- I'm no mesa dev but could you test with and before bc65dcab3bc48673ff6180afb036561a4b8b1119 ?
This might be a dupe of https://bugs.freedesktop.org/show_bug.cgi?id=105339
Unless you're sure your error started happening since b650fc09c3a35ca624aad5fe4b5c34867708f116
https://bugs.freedesktop.org/show_bug.cgi?id=105379
--- Comment #3 from Andrew Sheldon asheldon55@gmail.com --- (In reply to Matias N. Goldberg from comment #2)
I'm no mesa dev but could you test with and before bc65dcab3bc48673ff6180afb036561a4b8b1119 ?
This might be a dupe of https://bugs.freedesktop.org/show_bug.cgi?id=105339
Unless you're sure your error started happening since b650fc09c3a35ca624aad5fe4b5c34867708f116
I'm certain it's that particular commit since I've been using a reverted patch of that commit with my system Mesa for the last few days.
I.e. this:
diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c index 7c50ffae6a..7940fc8d5b 100644 --- a/src/gallium/drivers/radeonsi/si_pipe.c +++ b/src/gallium/drivers/radeonsi/si_pipe.c @@ -158,10 +158,6 @@ static void si_set_debug_callback(struct pipe_context *ctx, const struct pipe_debug_callback *cb) { struct si_context *sctx = (struct si_context *)ctx; - struct si_screen *screen = sctx->screen; - - util_queue_finish(&screen->shader_compiler_queue); - util_queue_finish(&screen->shader_compiler_queue_low_priority);
if (cb) sctx->debug = *cb;
https://bugs.freedesktop.org/show_bug.cgi?id=105379
Timothy Arceri t_arceri@yahoo.com.au changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO
--- Comment #4 from Timothy Arceri t_arceri@yahoo.com.au --- The game launches fine for me with mesa from git are you still having issues?
https://bugs.freedesktop.org/show_bug.cgi?id=105379
Timothy Arceri t_arceri@yahoo.com.au changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |RESOLVED Resolution|--- |FIXED
--- Comment #5 from Timothy Arceri t_arceri@yahoo.com.au --- Yeah I suspect the following commit fixed it:
commit 7083ac7290a0c37a45494437a45441112f3cc36c Author: Marek Olšák marek.olsak@amd.com Date: Tue Apr 24 17:01:35 2018 -0400
util/u_queue: fix a deadlock in util_queue_finish
Cc: 18.0 18.1 mesa-stable@lists.freedesktop.org Reviewed-by: Nicolai Hähnle nicolai.haehnle@amd.com
Feel free to reopen if you are still having problems.
https://bugs.freedesktop.org/show_bug.cgi?id=105379
--- Comment #6 from Andrew Sheldon asheldon55@gmail.com --- It's still broken for me actually, and reverting the commit original commit works around the issue. Maybe there is something that is specific to my system that is causing the problem.
https://bugs.freedesktop.org/show_bug.cgi?id=105379
--- Comment #7 from Andrew Sheldon asheldon55@gmail.com --- Scratch that; looks like a manual git build works, but not mesa-9999 in the Gentoo repository. I've tested with minimal cflags too and the problem remains, so I'm not sure what the difference is.
dri-devel@lists.freedesktop.org
-
bugzilla-daemon＠freedesktop.org