We get 1 warning when building kernel with W=1: drivers/gpu/drm/i2c/tda998x_drv.c:1292:5: warning: no previous prototype for 'tda998x_audio_digital_mute' [-Wmissing-prototypes]
In fact, this function is only used in the file in which it is declared and don't need a declaration, but can be made static. So this patch marks this function with 'static'.
Signed-off-by: Baoyou Xie baoyou.xie@linaro.org --- drivers/gpu/drm/i2c/tda998x_drv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c index 9798d40..af8683e 100644 --- a/drivers/gpu/drm/i2c/tda998x_drv.c +++ b/drivers/gpu/drm/i2c/tda998x_drv.c @@ -1289,7 +1289,8 @@ static void tda998x_audio_shutdown(struct device *dev, void *data) mutex_unlock(&priv->audio_mutex); }
-int tda998x_audio_digital_mute(struct device *dev, void *data, bool enable) +static int +tda998x_audio_digital_mute(struct device *dev, void *data, bool enable) { struct tda998x_priv *priv = dev_get_drvdata(dev);
On Saturday, October 22, 2016 5:14:42 PM CEST Baoyou Xie wrote:
We get 1 warning when building kernel with W=1: drivers/gpu/drm/i2c/tda998x_drv.c:1292:5: warning: no previous prototype for 'tda998x_audio_digital_mute' [-Wmissing-prototypes]
In fact, this function is only used in the file in which it is declared and don't need a declaration, but can be made static. So this patch marks this function with 'static'.
Signed-off-by: Baoyou Xie baoyou.xie@linaro.org
Reviewed-by: Arnd Bergmann arnd@arndb.de
On Mon, Oct 24, 2016 at 12:14:14PM +0200, Arnd Bergmann wrote:
On Saturday, October 22, 2016 5:14:42 PM CEST Baoyou Xie wrote:
We get 1 warning when building kernel with W=1: drivers/gpu/drm/i2c/tda998x_drv.c:1292:5: warning: no previous prototype for 'tda998x_audio_digital_mute' [-Wmissing-prototypes]
In fact, this function is only used in the file in which it is declared and don't need a declaration, but can be made static. So this patch marks this function with 'static'.
Signed-off-by: Baoyou Xie baoyou.xie@linaro.org
Reviewed-by: Arnd Bergmann arnd@arndb.de
Applied to drm-misc, thanks. -Daniel
On Mon, Oct 24, 2016 at 04:27:45PM +0200, Daniel Vetter wrote:
On Mon, Oct 24, 2016 at 12:14:14PM +0200, Arnd Bergmann wrote:
On Saturday, October 22, 2016 5:14:42 PM CEST Baoyou Xie wrote:
We get 1 warning when building kernel with W=1: drivers/gpu/drm/i2c/tda998x_drv.c:1292:5: warning: no previous prototype for 'tda998x_audio_digital_mute' [-Wmissing-prototypes]
In fact, this function is only used in the file in which it is declared and don't need a declaration, but can be made static. So this patch marks this function with 'static'.
Signed-off-by: Baoyou Xie baoyou.xie@linaro.org
Reviewed-by: Arnd Bergmann arnd@arndb.de
Applied to drm-misc, thanks.
Argh. This conflicts with my patch series posted before I went away, so now we're going to end up with merge conflicts... I suppose you're happy to handle the conflict as you've bypassed waiting for an ack from the driver maintainer...
dri-devel@lists.freedesktop.org