This patch unifies the naming of DRM functions for reference counting of struct drm_device. The resulting code is more aligned with the rest of the Linux kernel interfaces.
Signed-off-by: Thomas Zimmermann tzimmermann@suse.de --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c index a2ca90fc403c..5d024a154e1a 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c @@ -341,7 +341,7 @@ static int mtk_drm_bind(struct device *dev) err_deinit: mtk_drm_kms_deinit(drm); err_free: - drm_dev_unref(drm); + drm_dev_put(drm); return ret; }
@@ -350,7 +350,7 @@ static void mtk_drm_unbind(struct device *dev) struct mtk_drm_private *private = dev_get_drvdata(dev);
drm_dev_unregister(private->drm); - drm_dev_unref(private->drm); + drm_dev_put(private->drm); private->drm = NULL; }
@@ -504,7 +504,7 @@ static int mtk_drm_remove(struct platform_device *pdev)
drm_dev_unregister(drm); mtk_drm_kms_deinit(drm); - drm_dev_unref(drm); + drm_dev_put(drm);
component_master_del(&pdev->dev, &mtk_drm_ops); pm_runtime_disable(&pdev->dev);
On Tue, 2018-07-17 at 10:35 +0200, Thomas Zimmermann wrote:
This patch unifies the naming of DRM functions for reference counting of struct drm_device. The resulting code is more aligned with the rest of the Linux kernel interfaces.
Signed-off-by: Thomas Zimmermann tzimmermann@suse.de
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c index a2ca90fc403c..5d024a154e1a 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c @@ -341,7 +341,7 @@ static int mtk_drm_bind(struct device *dev) err_deinit: mtk_drm_kms_deinit(drm); err_free:
- drm_dev_unref(drm);
- drm_dev_put(drm); return ret;
}
@@ -350,7 +350,7 @@ static void mtk_drm_unbind(struct device *dev) struct mtk_drm_private *private = dev_get_drvdata(dev);
drm_dev_unregister(private->drm);
- drm_dev_unref(private->drm);
- drm_dev_put(private->drm); private->drm = NULL;
}
@@ -504,7 +504,7 @@ static int mtk_drm_remove(struct platform_device *pdev)
drm_dev_unregister(drm); mtk_drm_kms_deinit(drm);
- drm_dev_unref(drm);
drm_dev_put(drm);
component_master_del(&pdev->dev, &mtk_drm_ops); pm_runtime_disable(&pdev->dev);
Reviewed-by: Philipp Zabel p.zabel@pengutronix.de
regards Philipp
Hi, Thomas:
On Tue, 2018-07-17 at 12:21 +0200, Philipp Zabel wrote:
On Tue, 2018-07-17 at 10:35 +0200, Thomas Zimmermann wrote:
This patch unifies the naming of DRM functions for reference counting of struct drm_device. The resulting code is more aligned with the rest of the Linux kernel interfaces.
Signed-off-by: Thomas Zimmermann tzimmermann@suse.de
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c index a2ca90fc403c..5d024a154e1a 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c @@ -341,7 +341,7 @@ static int mtk_drm_bind(struct device *dev) err_deinit: mtk_drm_kms_deinit(drm); err_free:
- drm_dev_unref(drm);
- drm_dev_put(drm); return ret;
}
@@ -350,7 +350,7 @@ static void mtk_drm_unbind(struct device *dev) struct mtk_drm_private *private = dev_get_drvdata(dev);
drm_dev_unregister(private->drm);
- drm_dev_unref(private->drm);
- drm_dev_put(private->drm); private->drm = NULL;
}
@@ -504,7 +504,7 @@ static int mtk_drm_remove(struct platform_device *pdev)
drm_dev_unregister(drm); mtk_drm_kms_deinit(drm);
- drm_dev_unref(drm);
drm_dev_put(drm);
component_master_del(&pdev->dev, &mtk_drm_ops); pm_runtime_disable(&pdev->dev);
Reviewed-by: Philipp Zabel p.zabel@pengutronix.de
regards Philipp
Applied to mediatek-drm-fixes-4.19 [1], thanks.
[1] https://github.com/ckhu-mediatek/linux.git-tags/commits/mediatek-drm-fixes-4...
Regards, CK
dri-devel@lists.freedesktop.org