Old values are of no interest to the user, so let's reduce the spam a bit by hiding those.
Signed-off-by: Eric Engestrom eric.engestrom@imgtec.com --- autogen.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/autogen.sh b/autogen.sh index d82ab180..d0030969 100755 --- a/autogen.sh +++ b/autogen.sh @@ -9,10 +9,10 @@ cd "$srcdir" autoreconf --force --verbose --install || exit 1 cd "$ORIGDIR" || exit $?
-git config --local --get format.subjectPrefix || +git config --local --get format.subjectPrefix >/dev/null || git config --local format.subjectPrefix "PATCH libdrm" 2>/dev/null
-git config --local --get sendemail.to || +git config --local --get sendemail.to >/dev/null || git config --local sendemail.to "dri-devel@lists.freedesktop.org" 2>/dev/null
if test -z "$NOCONFIGURE"; then
If the build dir is outside of the git dir, the order matters :)
Signed-off-by: Eric Engestrom eric.engestrom@imgtec.com --- autogen.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/autogen.sh b/autogen.sh index d0030969..13d6991e 100755 --- a/autogen.sh +++ b/autogen.sh @@ -6,15 +6,15 @@ test -z "$srcdir" && srcdir=. ORIGDIR=`pwd` cd "$srcdir"
-autoreconf --force --verbose --install || exit 1 -cd "$ORIGDIR" || exit $? - git config --local --get format.subjectPrefix >/dev/null || git config --local format.subjectPrefix "PATCH libdrm" 2>/dev/null
git config --local --get sendemail.to >/dev/null || git config --local sendemail.to "dri-devel@lists.freedesktop.org" 2>/dev/null
+autoreconf --force --verbose --install || exit 1 +cd "$ORIGDIR" || exit $? + if test -z "$NOCONFIGURE"; then "$srcdir"/configure "$@" fi
On 3 February 2017 at 18:21, Eric Engestrom eric.engestrom@imgtec.com wrote:
If the build dir is outside of the git dir, the order matters :)
Signed-off-by: Eric Engestrom eric.engestrom@imgtec.com
Wondering if you've got hit by this or you noticed my identical patch on xorg-devel ;-)
Either way, for both Reviewed-by: Emil Velikov emil.velikov@collabora.com
-Emi
On Friday, 2017-02-03 19:07:08 +0000, Emil Velikov wrote:
On 3 February 2017 at 18:21, Eric Engestrom eric.engestrom@imgtec.com wrote:
If the build dir is outside of the git dir, the order matters :)
Signed-off-by: Eric Engestrom eric.engestrom@imgtec.com
Wondering if you've got hit by this or you noticed my identical patch on xorg-devel ;-)
Both, actually: I noticed the unnecessary output I fixed in the first patch, and while in there I saw that the git commands were in the wrong place (probably because I remembered your patches).
Either way, for both Reviewed-by: Emil Velikov emil.velikov@collabora.com
-Emi
Thanks; I don't have commit access on this repo, can you push them for me?
Cheers, Eric
On Fri 03 Feb 2017, Eric Engestrom wrote:
Old values are of no interest to the user, so let's reduce the spam a bit by hiding those.
Signed-off-by: Eric Engestrom eric.engestrom@imgtec.com
autogen.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
The subject should say "print". Otherwise, the series is Reviewed-by: Chad Versace chadversary@chromium.org
dri-devel@lists.freedesktop.org
-
Chad Versace -
Emil Velikov -
Eric Engestrom -
Eric Engestrom