From: Thierry Reding treding@nvidia.com

The error messages generated by the SCDC helpers are somewhat inconsistent with other DRM errors and even with other errors in the same file. Fix them all up to use a common format.

Signed-off-by: Thierry Reding treding@nvidia.com --- drivers/gpu/drm/drm_scdc_helper.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/drm_scdc_helper.c b/drivers/gpu/drm/drm_scdc_helper.c index d66c436a829e..5e6f0709df49 100644 --- a/drivers/gpu/drm/drm_scdc_helper.c +++ b/drivers/gpu/drm/drm_scdc_helper.c @@ -141,7 +141,7 @@ bool drm_scdc_get_scrambling_status(struct i2c_adapter *adapter)

ret = drm_scdc_readb(adapter, SCDC_SCRAMBLER_STATUS, &status); if (ret < 0) { - DRM_ERROR("Failed to read scrambling status, error %d\n", ret); + DRM_ERROR("Failed to read scrambling status: %d\n", ret); return false; }

@@ -168,7 +168,7 @@ bool drm_scdc_set_scrambling(struct i2c_adapter *adapter, bool enable)

ret = drm_scdc_readb(adapter, SCDC_TMDS_CONFIG, &config); if (ret < 0) { - DRM_ERROR("Failed to read tmds config, err=%d\n", ret); + DRM_ERROR("Failed to read tmds config: %d\n", ret); return false; }

@@ -179,7 +179,7 @@ bool drm_scdc_set_scrambling(struct i2c_adapter *adapter, bool enable)

ret = drm_scdc_writeb(adapter, SCDC_TMDS_CONFIG, config); if (ret < 0) { - DRM_ERROR("Failed to enable scrambling, error %d\n", ret); + DRM_ERROR("Failed to enable scrambling: %d\n", ret); return false; }

@@ -223,7 +223,7 @@ bool drm_scdc_set_high_tmds_clock_ratio(struct i2c_adapter *adapter, bool set)

ret = drm_scdc_readb(adapter, SCDC_TMDS_CONFIG, &config); if (ret < 0) { - DRM_ERROR("Failed to read tmds config, err=%d\n", ret); + DRM_ERROR("Failed to read tmds config: %d\n", ret); return false; }

@@ -234,7 +234,7 @@ bool drm_scdc_set_high_tmds_clock_ratio(struct i2c_adapter *adapter, bool set)

ret = drm_scdc_writeb(adapter, SCDC_TMDS_CONFIG, config); if (ret < 0) { - DRM_ERROR("Failed to set TMDS clock ratio, error %d\n", ret); + DRM_ERROR("Failed to set TMDS clock ratio: %d\n", ret); return false; }

From: Thierry Reding treding@nvidia.com

The file uses inconsistent capitalization for TMDS. Since it is an abbreviation, all uppercase is correct.

Signed-off-by: Thierry Reding treding@nvidia.com --- drivers/gpu/drm/drm_scdc_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_scdc_helper.c b/drivers/gpu/drm/drm_scdc_helper.c index 5e6f0709df49..657ea5ab6c3f 100644 --- a/drivers/gpu/drm/drm_scdc_helper.c +++ b/drivers/gpu/drm/drm_scdc_helper.c @@ -168,7 +168,7 @@ bool drm_scdc_set_scrambling(struct i2c_adapter *adapter, bool enable)

ret = drm_scdc_readb(adapter, SCDC_TMDS_CONFIG, &config); if (ret < 0) { - DRM_ERROR("Failed to read tmds config: %d\n", ret); + DRM_ERROR("Failed to read TMDS config: %d\n", ret); return false; }

@@ -223,7 +223,7 @@ bool drm_scdc_set_high_tmds_clock_ratio(struct i2c_adapter *adapter, bool set)

ret = drm_scdc_readb(adapter, SCDC_TMDS_CONFIG, &config); if (ret < 0) { - DRM_ERROR("Failed to read tmds config: %d\n", ret); + DRM_ERROR("Failed to read TMDS config: %d\n", ret); return false; }

On Fri, Sep 01, 2017 at 04:44:28PM +0200, Thierry Reding wrote:

From: Thierry Reding treding@nvidia.com

It's unusual to separate kerneldoc comments from the functions that they describe by a blank line. Remove them.

Signed-off-by: Thierry Reding treding@nvidia.com

Series lgtm Reviewed-by: Ville Syrjälä ville.syrjala@linux.intel.com

---

drivers/gpu/drm/drm_scdc_helper.c | 2 -- 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_scdc_helper.c b/drivers/gpu/drm/drm_scdc_helper.c index 935653eb3616..d66c436a829e 100644 --- a/drivers/gpu/drm/drm_scdc_helper.c +++ b/drivers/gpu/drm/drm_scdc_helper.c @@ -134,7 +134,6 @@ EXPORT_SYMBOL(drm_scdc_write);

• Returns:
• True if the scrambling is enabled, false otherwise.

*/

bool drm_scdc_get_scrambling_status(struct i2c_adapter *adapter) { u8 status; @@ -162,7 +161,6 @@ EXPORT_SYMBOL(drm_scdc_get_scrambling_status);

• Returns:
• True if scrambling is set/reset successfully, false otherwise.

*/

bool drm_scdc_set_scrambling(struct i2c_adapter *adapter, bool enable) { u8 config; -- 2.13.3

---

dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Regards

Shashank

On 9/1/2017 8:14 PM, Thierry Reding wrote:

From: Thierry Reding treding@nvidia.com

It's unusual to separate kerneldoc comments from the functions that they describe by a blank line. Remove them.

Signed-off-by: Thierry Reding treding@nvidia.com

drivers/gpu/drm/drm_scdc_helper.c | 2 -- 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_scdc_helper.c b/drivers/gpu/drm/drm_scdc_helper.c index 935653eb3616..d66c436a829e 100644 --- a/drivers/gpu/drm/drm_scdc_helper.c +++ b/drivers/gpu/drm/drm_scdc_helper.c @@ -134,7 +134,6 @@ EXPORT_SYMBOL(drm_scdc_write);

• Returns:
• True if the scrambling is enabled, false otherwise.

*/

• bool drm_scdc_get_scrambling_status(struct i2c_adapter *adapter) { u8 status;

@@ -162,7 +161,6 @@ EXPORT_SYMBOL(drm_scdc_get_scrambling_status);

• Returns:
• True if scrambling is set/reset successfully, false otherwise.

*/

• bool drm_scdc_set_scrambling(struct i2c_adapter *adapter, bool enable) { u8 config;

Thanks for the fix Reviewed-by: Shashank Sharma shashank.sharma@intel.com