On Mon, Feb 19, 2018 at 04:04:42PM +0100, Daniel Vetter wrote:

On Wed, Feb 14, 2018 at 09:23:20PM +0200, Ville Syrjala wrote:

...

From: Jyri Sarha jsarha@ti.com

Add a standard optional properties to support different non RGB color encodings in DRM planes. COLOR_ENCODING select the supported non RGB color encoding, for instance ITU-R BT.709 YCbCr. COLOR_RANGE selects the value ranges within the selected color encoding. The properties are stored to drm_plane object to allow different set of supported encoding for different planes on the device.

Cc: Harry Wentland harry.wentland@amd.com Cc: Daniel Vetter daniel@ffwll.ch Cc: Daniel Stone daniel@fooishbar.org Cc: Russell King - ARM Linux linux@armlinux.org.uk Cc: Ilia Mirkin imirkin@alum.mit.edu Cc: Hans Verkuil hverkuil@xs4all.nl Cc: Uma Shankar uma.shankar@intel.com Cc: Shashank Sharma shashank.sharma@intel.com Reviewed-by: Ville Syrjälä ville.syrjala@linux.intel.com Signed-off-by: Jyri Sarha jsarha@ti.com

---

drivers/gpu/drm/drm_atomic.c | 8 ++++ drivers/gpu/drm/drm_color_mgmt.c | 91 ++++++++++++++++++++++++++++++++++++++++ include/drm/drm_color_mgmt.h | 19 +++++++++ include/drm/drm_plane.h | 8 ++++ 4 files changed, 126 insertions(+)

diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c index 46733d534587..452a0b0bafbc 100644 --- a/drivers/gpu/drm/drm_atomic.c +++ b/drivers/gpu/drm/drm_atomic.c @@ -759,6 +759,10 @@ static int drm_atomic_plane_set_property(struct drm_plane *plane, state->rotation = val; } else if (property == plane->zpos_property) { state->zpos = val;

• } else if (property == plane->color_encoding_property) {

• state->color_encoding = val;
  

• } else if (property == plane->color_range_property) {

• state->color_range = val;
  

  } else if (plane->funcs->atomic_set_property) { return plane->funcs->atomic_set_property(plane, state, property, val);

@@ -818,6 +822,10 @@ drm_atomic_plane_get_property(struct drm_plane *plane, *val = state->rotation; } else if (property == plane->zpos_property) { *val = state->zpos;

• } else if (property == plane->color_encoding_property) {

• *val = state->color_encoding;
  

• } else if (property == plane->color_range_property) {

• *val = state->color_range;
  

  } else if (plane->funcs->atomic_get_property) { return plane->funcs->atomic_get_property(plane, state, property, val); } else {

diff --git a/drivers/gpu/drm/drm_color_mgmt.c b/drivers/gpu/drm/drm_color_mgmt.c index 0d002b045bd2..a84fc861e406 100644 --- a/drivers/gpu/drm/drm_color_mgmt.c +++ b/drivers/gpu/drm/drm_color_mgmt.c @@ -88,6 +88,19 @@

• drm_mode_crtc_set_gamma_size(). Drivers which support both should use
• drm_atomic_helper_legacy_gamma_set() to alias the legacy gamma ramp with the
• "GAMMA_LUT" property above.

• • Support for different non RGB color encodings is controlled through
• • &drm_plane specific COLOR_ENCODING and COLOR_RANGE properties:
• • "COLOR_ENCODING"
• • Optional plane enum property to support different non RGB
• • color encodings. The driver can provide a subset of standard
• • enum values supported by the DRM plane.

Please also mention the function to setup/register them, like we try to do with the other optional properties.

ack

...

• • "COLOR_RANGE"
• • Optional plane enum property to support different non RGB
• • color parameter ranges. The driver can provide a subset of
• • standard enum values supported by the DRM plane.
  */

/** @@ -339,3 +352,81 @@ int drm_mode_gamma_get_ioctl(struct drm_device *dev, drm_modeset_unlock(&crtc->mutex); return ret; }

+static const char * const color_encoding_name[] = {

• [DRM_COLOR_YCBCR_BT601] = "ITU-R BT.601 YCbCr",
• [DRM_COLOR_YCBCR_BT709] = "ITU-R BT.709 YCbCr",
• [DRM_COLOR_YCBCR_BT2020] = "ITU-R BT.2020 YCbCr",

+};

+static const char * const color_range_name[] = {

• [DRM_COLOR_YCBCR_FULL_RANGE] = "YCbCr full range",
• [DRM_COLOR_YCBCR_LIMITED_RANGE] = "YCbCr limited range",

+};

+/**

• • drm_plane_create_color_properties - color encoding related plane properties
• • @supported_encodings: bitfield indicating supported color encodings
• • @supported_ranges: bitfileld indicating supported color ranges
• • @default_encoding: default color encoding
• • @default_range: default color range
• • Create and attach plane specific COLOR_ENCODING and COLOR_RANGE
• • properties to to the drm_plane object. The supported encodings and
• • ranges should be provided in supported_encodings and
• • supported_ranges bitmasks. Each bit set in the bitmask indicates
• • the its number as enum value being supported.
• */

+int drm_plane_create_color_properties(struct drm_plane *plane,

• 		      u32 supported_encodings,
  

• 		      u32 supported_ranges,
  

Is 0 in the above two supported_ masks a valid value? If yes, should we still register the prop in that case? If no, please add a WARN_ON early exit case to catch this.

I guess if we go for that we should also check that the supported bitmasks don't contain undefined enum values, and that the default enum values are included in the bitmasks.

Jyri said he's not looked at this in a while, so I'll just go ahead and respin this myself.

Similar, if there's only 1 possible value I guess we should make the prop immutable?

I wonder if we should put that logic into drm_property_create_enum() & co. actually?

...

• 		      enum drm_color_encoding default_encoding,
  

• 		      enum drm_color_range default_range)
  

+{

• struct drm_device *dev = plane->dev;
• struct drm_property *prop;
• struct drm_prop_enum_list enum_list[max(DRM_COLOR_ENCODING_MAX,

• 				DRM_COLOR_RANGE_MAX)];
  

• int i, len;
• len = 0;
• for (i = 0; i < DRM_COLOR_ENCODING_MAX; i++) {

• if ((supported_encodings & BIT(i)) == 0)
  

• 	continue;
  

• enum_list[len].type = i;
  

• enum_list[len].name = color_encoding_name[i];
  

• len++;
  

• }
• prop = drm_property_create_enum(dev, 0, "COLOR_ENCODING",

• 			enum_list, len);
  

• if (!prop)

• return -ENOMEM;
  

• plane->color_encoding_property = prop;
• drm_object_attach_property(&plane->base, prop, default_encoding);
• if (plane->state)

• plane->state->color_encoding = default_encoding;
  

• len = 0;
• for (i = 0; i < DRM_COLOR_RANGE_MAX; i++) {

• if ((supported_ranges & BIT(i)) == 0)
  

• 	continue;
  

• enum_list[len].type = i;
  

• enum_list[len].name = color_range_name[i];
  

• len++;
  

• }
• prop = drm_property_create_enum(dev, 0, "COLOR_RANGE",

• 			enum_list, len);
  

• if (!prop)

• return -ENOMEM;
  

• plane->color_range_property = prop;
• drm_object_attach_property(&plane->base, prop, default_range);
• if (plane->state)

• plane->state->color_range = default_range;
  

• return 0;

+} +EXPORT_SYMBOL(drm_plane_create_color_properties); diff --git a/include/drm/drm_color_mgmt.h b/include/drm/drm_color_mgmt.h index 03a59cbce621..b3b6d302ca8c 100644 --- a/include/drm/drm_color_mgmt.h +++ b/include/drm/drm_color_mgmt.h @@ -26,6 +26,7 @@ #include <linux/ctype.h>

struct drm_crtc; +struct drm_plane;

uint32_t drm_color_lut_extract(uint32_t user_input, uint32_t bit_precision);

@@ -37,4 +38,22 @@ void drm_crtc_enable_color_mgmt(struct drm_crtc *crtc, int drm_mode_crtc_set_gamma_size(struct drm_crtc *crtc, int gamma_size);

+enum drm_color_encoding {

• DRM_COLOR_YCBCR_BT601,
• DRM_COLOR_YCBCR_BT709,
• DRM_COLOR_YCBCR_BT2020,
• DRM_COLOR_ENCODING_MAX,

+};

+enum drm_color_range {

• DRM_COLOR_YCBCR_LIMITED_RANGE,
• DRM_COLOR_YCBCR_FULL_RANGE,
• DRM_COLOR_RANGE_MAX,

+};

+int drm_plane_create_color_properties(struct drm_plane *plane,

• 		      u32 supported_encodings,
  

• 		      u32 supported_ranges,
  

• 		      enum drm_color_encoding default_encoding,
  

• 		      enum drm_color_range default_range);
  

#endif diff --git a/include/drm/drm_plane.h b/include/drm/drm_plane.h index 8185e3468a23..c0a242dcda44 100644 --- a/include/drm/drm_plane.h +++ b/include/drm/drm_plane.h @@ -26,6 +26,7 @@ #include <linux/list.h> #include <linux/ctype.h> #include <drm/drm_mode_object.h> +#include <drm/drm_color_mgmt.h>

struct drm_crtc; struct drm_printer; @@ -112,6 +113,10 @@ struct drm_plane_state { unsigned int zpos; unsigned int normalized_zpos;

• /* Color encoding for non RGB formats */
• enum drm_color_encoding color_encoding;
• enum drm_color_range color_range;

Needs kerneldoc.

ack

...

• /* Clipped coordinates */ struct drm_rect src, dst;

@@ -558,6 +563,9 @@ struct drm_plane {

struct drm_property *zpos_property; struct drm_property *rotation_property;

• struct drm_property *color_encoding_property;
• struct drm_property *color_range_property;

Dito.

ack

...

};

#define obj_to_plane(x) container_of(x, struct drm_plane, base)

2.13.6

-- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

On Mon, Feb 19, 2018 at 10:28:23PM +0200, Ville Syrjala wrote:

From: Jyri Sarha jsarha@ti.com

Add a standard optional properties to support different non RGB color encodings in DRM planes. COLOR_ENCODING select the supported non RGB color encoding, for instance ITU-R BT.709 YCbCr. COLOR_RANGE selects the value ranges within the selected color encoding. The properties are stored to drm_plane object to allow different set of supported encoding for different planes on the device.

v2: Add/fix kerneldocs, verify bitmasks (danvet)

Cc: Harry Wentland harry.wentland@amd.com Cc: Daniel Vetter daniel@ffwll.ch Cc: Daniel Stone daniel@fooishbar.org Cc: Russell King - ARM Linux linux@armlinux.org.uk Cc: Ilia Mirkin imirkin@alum.mit.edu Cc: Hans Verkuil hverkuil@xs4all.nl Cc: Uma Shankar uma.shankar@intel.com Cc: Shashank Sharma shashank.sharma@intel.com Reviewed-by: Ville Syrjälä ville.syrjala@linux.intel.com Signed-off-by: Jyri Sarha jsarha@ti.com [vsyrjala v2: Add/fix kerneldocs, verify bitmasks] Signed-off-by: Ville Syrjälä ville.syrjala@linux.intel.com

Reviewed-by: Daniel Vetter daniel.vetter@ffwll.ch

---

drivers/gpu/drm/drm_atomic.c | 8 +++ drivers/gpu/drm/drm_color_mgmt.c | 103 +++++++++++++++++++++++++++++++++++++++ include/drm/drm_color_mgmt.h | 19 ++++++++ include/drm/drm_plane.h | 32 ++++++++++++ 4 files changed, 162 insertions(+)

diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c index 46733d534587..452a0b0bafbc 100644 --- a/drivers/gpu/drm/drm_atomic.c +++ b/drivers/gpu/drm/drm_atomic.c @@ -759,6 +759,10 @@ static int drm_atomic_plane_set_property(struct drm_plane *plane, state->rotation = val; } else if (property == plane->zpos_property) { state->zpos = val;

• } else if (property == plane->color_encoding_property) {

• state->color_encoding = val;
  

• } else if (property == plane->color_range_property) {

• state->color_range = val;
  

  } else if (plane->funcs->atomic_set_property) { return plane->funcs->atomic_set_property(plane, state, property, val);

@@ -818,6 +822,10 @@ drm_atomic_plane_get_property(struct drm_plane *plane, *val = state->rotation; } else if (property == plane->zpos_property) { *val = state->zpos;

• } else if (property == plane->color_encoding_property) {

• *val = state->color_encoding;
  

• } else if (property == plane->color_range_property) {

• *val = state->color_range;
  

  } else if (plane->funcs->atomic_get_property) { return plane->funcs->atomic_get_property(plane, state, property, val); } else {

diff --git a/drivers/gpu/drm/drm_color_mgmt.c b/drivers/gpu/drm/drm_color_mgmt.c index 0d002b045bd2..4b83e078d3e9 100644 --- a/drivers/gpu/drm/drm_color_mgmt.c +++ b/drivers/gpu/drm/drm_color_mgmt.c @@ -88,6 +88,20 @@

• drm_mode_crtc_set_gamma_size(). Drivers which support both should use
• drm_atomic_helper_legacy_gamma_set() to alias the legacy gamma ramp with the
• "GAMMA_LUT" property above.

• • Support for different non RGB color encodings is controlled through
• • &drm_plane specific COLOR_ENCODING and COLOR_RANGE properties. They
• • are set up by calling drm_plane_create_color_properties().
• • "COLOR_ENCODING"
• • Optional plane enum property to support different non RGB
• • color encodings. The driver can provide a subset of standard
• • enum values supported by the DRM plane.
• • "COLOR_RANGE"
• • Optional plane enum property to support different non RGB
• • color parameter ranges. The driver can provide a subset of
• • standard enum values supported by the DRM plane.
  */

/** @@ -339,3 +353,92 @@ int drm_mode_gamma_get_ioctl(struct drm_device *dev, drm_modeset_unlock(&crtc->mutex); return ret; }

+static const char * const color_encoding_name[] = {

• [DRM_COLOR_YCBCR_BT601] = "ITU-R BT.601 YCbCr",
• [DRM_COLOR_YCBCR_BT709] = "ITU-R BT.709 YCbCr",
• [DRM_COLOR_YCBCR_BT2020] = "ITU-R BT.2020 YCbCr",

+};

+static const char * const color_range_name[] = {

• [DRM_COLOR_YCBCR_FULL_RANGE] = "YCbCr full range",
• [DRM_COLOR_YCBCR_LIMITED_RANGE] = "YCbCr limited range",

+};

+/**

• • drm_plane_create_color_properties - color encoding related plane properties
• • @plane: plane object
• • @supported_encodings: bitfield indicating supported color encodings
• • @supported_ranges: bitfileld indicating supported color ranges
• • @default_encoding: default color encoding
• • @default_range: default color range
• • Create and attach plane specific COLOR_ENCODING and COLOR_RANGE
• • properties to @plane. The supported encodings and ranges should
• • be provided in supported_encodings and supported_ranges bitmasks.
• • Each bit set in the bitmask indicates that its number as enum
• • value is supported.
• */

+int drm_plane_create_color_properties(struct drm_plane *plane,

• 		      u32 supported_encodings,
  

• 		      u32 supported_ranges,
  

• 		      enum drm_color_encoding default_encoding,
  

• 		      enum drm_color_range default_range)
  

+{

• struct drm_device *dev = plane->dev;
• struct drm_property *prop;
• struct drm_prop_enum_list enum_list[max(DRM_COLOR_ENCODING_MAX,

• 				DRM_COLOR_RANGE_MAX)];
  

• int i, len;
• if (WARN_ON(supported_encodings == 0 ||

•     (supported_encodings & -BIT(DRM_COLOR_ENCODING_MAX)) != 0 ||
  

•     (supported_encodings & BIT(default_encoding)) == 0))
  

• return -EINVAL;
  

• if (WARN_ON(supported_ranges == 0 ||

•     (supported_ranges & -BIT(DRM_COLOR_RANGE_MAX)) != 0 ||
  

•     (supported_ranges & BIT(default_range)) == 0))
  

• return -EINVAL;
  

• len = 0;
• for (i = 0; i < DRM_COLOR_ENCODING_MAX; i++) {

• if ((supported_encodings & BIT(i)) == 0)
  

• 	continue;
  

• enum_list[len].type = i;
  

• enum_list[len].name = color_encoding_name[i];
  

• len++;
  

• }
• prop = drm_property_create_enum(dev, 0, "COLOR_ENCODING",

• 			enum_list, len);
  

• if (!prop)

• return -ENOMEM;
  

• plane->color_encoding_property = prop;
• drm_object_attach_property(&plane->base, prop, default_encoding);
• if (plane->state)

• plane->state->color_encoding = default_encoding;
  

• len = 0;
• for (i = 0; i < DRM_COLOR_RANGE_MAX; i++) {

• if ((supported_ranges & BIT(i)) == 0)
  

• 	continue;
  

• enum_list[len].type = i;
  

• enum_list[len].name = color_range_name[i];
  

• len++;
  

• }
• prop = drm_property_create_enum(dev, 0, "COLOR_RANGE",

• 			enum_list, len);
  

• if (!prop)

• return -ENOMEM;
  

• plane->color_range_property = prop;
• drm_object_attach_property(&plane->base, prop, default_range);
• if (plane->state)

• plane->state->color_range = default_range;
  

• return 0;

+} +EXPORT_SYMBOL(drm_plane_create_color_properties); diff --git a/include/drm/drm_color_mgmt.h b/include/drm/drm_color_mgmt.h index 03a59cbce621..b3b6d302ca8c 100644 --- a/include/drm/drm_color_mgmt.h +++ b/include/drm/drm_color_mgmt.h @@ -26,6 +26,7 @@ #include <linux/ctype.h>

struct drm_crtc; +struct drm_plane;

uint32_t drm_color_lut_extract(uint32_t user_input, uint32_t bit_precision);

@@ -37,4 +38,22 @@ void drm_crtc_enable_color_mgmt(struct drm_crtc *crtc, int drm_mode_crtc_set_gamma_size(struct drm_crtc *crtc, int gamma_size);

+enum drm_color_encoding {

• DRM_COLOR_YCBCR_BT601,
• DRM_COLOR_YCBCR_BT709,
• DRM_COLOR_YCBCR_BT2020,
• DRM_COLOR_ENCODING_MAX,

+};

+enum drm_color_range {

• DRM_COLOR_YCBCR_LIMITED_RANGE,
• DRM_COLOR_YCBCR_FULL_RANGE,
• DRM_COLOR_RANGE_MAX,

+};

+int drm_plane_create_color_properties(struct drm_plane *plane,

• 		      u32 supported_encodings,
  

• 		      u32 supported_ranges,
  

• 		      enum drm_color_encoding default_encoding,
  

• 		      enum drm_color_range default_range);
  

#endif diff --git a/include/drm/drm_plane.h b/include/drm/drm_plane.h index 8185e3468a23..f7bf4a48b1c3 100644 --- a/include/drm/drm_plane.h +++ b/include/drm/drm_plane.h @@ -26,6 +26,7 @@ #include <linux/list.h> #include <linux/ctype.h> #include <drm/drm_mode_object.h> +#include <drm/drm_color_mgmt.h>

struct drm_crtc; struct drm_printer; @@ -112,6 +113,20 @@ struct drm_plane_state { unsigned int zpos; unsigned int normalized_zpos;

• /**

• * @color_encoding:
  

• *
  

• * Color encoding for non RGB formats
  

• */
  

• enum drm_color_encoding color_encoding;
• /**

• * @color_range:
  

• *
  

• * Color range for non RGB formats
  

• */
  

• enum drm_color_range color_range;
• /* Clipped coordinates */ struct drm_rect src, dst;

@@ -558,6 +573,23 @@ struct drm_plane {

struct drm_property *zpos_property; struct drm_property *rotation_property;

• /**

• * @color_encoding_property:
  

• *
  

• * Optional "COLOR_ENCODING" enum property for specifying
  

• * color encoding for non RGB formats.
  

• * See drm_plane_create_color_properties().
  

• */
  

• struct drm_property *color_encoding_property;
• /**

• * @color_range_property:
  

• *
  

• * Optional "COLOR_RANGE" enum property for specifying
  

• * color range for non RGB formats.
  

• * See drm_plane_create_color_properties().
  

• */
  

• struct drm_property *color_range_property;

};

#define obj_to_plane(x) container_of(x, struct drm_plane, base)

2.13.6

On Fri, Nov 30, 2018 at 02:08:11PM +0100, Christoph Manszewski wrote:

Hi,

I am looking for a way to export the color encoding and range selection to user space. I came across those properties and am wondering, why they are meant only for non RGB color encodings. Would it be okay, to modify them and use with RGB formats as well?

What you trying to do? Input limited range RGB data and expand to full range?

Regards, Chris

On 02/19/2018 09:28 PM, Ville Syrjala wrote:

...

From: Jyri Sarha jsarha@ti.com

Add a standard optional properties to support different non RGB color encodings in DRM planes. COLOR_ENCODING select the supported non RGB color encoding, for instance ITU-R BT.709 YCbCr. COLOR_RANGE selects the value ranges within the selected color encoding. The properties are stored to drm_plane object to allow different set of supported encoding for different planes on the device.

v2: Add/fix kerneldocs, verify bitmasks (danvet)

Cc: Harry Wentland harry.wentland@amd.com Cc: Daniel Vetter daniel@ffwll.ch Cc: Daniel Stone daniel@fooishbar.org Cc: Russell King - ARM Linux linux@armlinux.org.uk Cc: Ilia Mirkin imirkin@alum.mit.edu Cc: Hans Verkuil hverkuil@xs4all.nl Cc: Uma Shankar uma.shankar@intel.com Cc: Shashank Sharma shashank.sharma@intel.com Reviewed-by: Ville Syrjälä ville.syrjala@linux.intel.com Signed-off-by: Jyri Sarha jsarha@ti.com [vsyrjala v2: Add/fix kerneldocs, verify bitmasks] Signed-off-by: Ville Syrjälä ville.syrjala@linux.intel.com Reviewed-by: Daniel Vetter daniel.vetter@ffwll.ch

---

drivers/gpu/drm/drm_atomic.c | 8 +++ drivers/gpu/drm/drm_color_mgmt.c | 103 +++++++++++++++++++++++++++++++++++++++ include/drm/drm_color_mgmt.h | 19 ++++++++ include/drm/drm_plane.h | 32 ++++++++++++ 4 files changed, 162 insertions(+)

diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c index 46733d534587..452a0b0bafbc 100644 --- a/drivers/gpu/drm/drm_atomic.c +++ b/drivers/gpu/drm/drm_atomic.c @@ -759,6 +759,10 @@ static int drm_atomic_plane_set_property(struct drm_plane *plane, state->rotation = val; } else if (property == plane->zpos_property) { state->zpos = val;

• } else if (property == plane->color_encoding_property) {

• state->color_encoding = val;
  

• } else if (property == plane->color_range_property) {

• state->color_range = val;
  

  } else if (plane->funcs->atomic_set_property) { return plane->funcs->atomic_set_property(plane, state, property, val);

@@ -818,6 +822,10 @@ drm_atomic_plane_get_property(struct drm_plane *plane, *val = state->rotation; } else if (property == plane->zpos_property) { *val = state->zpos;

• } else if (property == plane->color_encoding_property) {

• *val = state->color_encoding;
  

• } else if (property == plane->color_range_property) {

• *val = state->color_range;
  

  } else if (plane->funcs->atomic_get_property) { return plane->funcs->atomic_get_property(plane, state, property, val); } else {

diff --git a/drivers/gpu/drm/drm_color_mgmt.c b/drivers/gpu/drm/drm_color_mgmt.c index 0d002b045bd2..4b83e078d3e9 100644 --- a/drivers/gpu/drm/drm_color_mgmt.c +++ b/drivers/gpu/drm/drm_color_mgmt.c @@ -88,6 +88,20 @@

• drm_mode_crtc_set_gamma_size(). Drivers which support both should use
• drm_atomic_helper_legacy_gamma_set() to alias the legacy gamma ramp with the
• "GAMMA_LUT" property above.

• • Support for different non RGB color encodings is controlled through
• • &drm_plane specific COLOR_ENCODING and COLOR_RANGE properties. They
• • are set up by calling drm_plane_create_color_properties().
• • "COLOR_ENCODING"
• • Optional plane enum property to support different non RGB
• • color encodings. The driver can provide a subset of standard
• • enum values supported by the DRM plane.
• • "COLOR_RANGE"
• • Optional plane enum property to support different non RGB
• • color parameter ranges. The driver can provide a subset of
• • standard enum values supported by the DRM plane.

  */

  /**

@@ -339,3 +353,92 @@ int drm_mode_gamma_get_ioctl(struct drm_device *dev, drm_modeset_unlock(&crtc->mutex); return ret; }

+static const char * const color_encoding_name[] = {

• [DRM_COLOR_YCBCR_BT601] = "ITU-R BT.601 YCbCr",
• [DRM_COLOR_YCBCR_BT709] = "ITU-R BT.709 YCbCr",
• [DRM_COLOR_YCBCR_BT2020] = "ITU-R BT.2020 YCbCr",

+};

+static const char * const color_range_name[] = {

• [DRM_COLOR_YCBCR_FULL_RANGE] = "YCbCr full range",
• [DRM_COLOR_YCBCR_LIMITED_RANGE] = "YCbCr limited range",

+};

+/**

• • drm_plane_create_color_properties - color encoding related plane properties
• • @plane: plane object
• • @supported_encodings: bitfield indicating supported color encodings
• • @supported_ranges: bitfileld indicating supported color ranges
• • @default_encoding: default color encoding
• • @default_range: default color range
• • Create and attach plane specific COLOR_ENCODING and COLOR_RANGE
• • properties to @plane. The supported encodings and ranges should
• • be provided in supported_encodings and supported_ranges bitmasks.
• • Each bit set in the bitmask indicates that its number as enum
• • value is supported.
• */

+int drm_plane_create_color_properties(struct drm_plane *plane,

• 		      u32 supported_encodings,
  

• 		      u32 supported_ranges,
  

• 		      enum drm_color_encoding default_encoding,
  

• 		      enum drm_color_range default_range)
  

+{

• struct drm_device *dev = plane->dev;
• struct drm_property *prop;
• struct drm_prop_enum_list enum_list[max(DRM_COLOR_ENCODING_MAX,

• 				DRM_COLOR_RANGE_MAX)];
  

• int i, len;
• if (WARN_ON(supported_encodings == 0 ||

•     (supported_encodings & -BIT(DRM_COLOR_ENCODING_MAX)) != 0 ||
  

•     (supported_encodings & BIT(default_encoding)) == 0))
  

• return -EINVAL;
  

• if (WARN_ON(supported_ranges == 0 ||

•     (supported_ranges & -BIT(DRM_COLOR_RANGE_MAX)) != 0 ||
  

•     (supported_ranges & BIT(default_range)) == 0))
  

• return -EINVAL;
  

• len = 0;
• for (i = 0; i < DRM_COLOR_ENCODING_MAX; i++) {

• if ((supported_encodings & BIT(i)) == 0)
  

• 	continue;
  

• enum_list[len].type = i;
  

• enum_list[len].name = color_encoding_name[i];
  

• len++;
  

• }
• prop = drm_property_create_enum(dev, 0, "COLOR_ENCODING",

• 			enum_list, len);
  

• if (!prop)

• return -ENOMEM;
  

• plane->color_encoding_property = prop;
• drm_object_attach_property(&plane->base, prop, default_encoding);
• if (plane->state)

• plane->state->color_encoding = default_encoding;
  

• len = 0;
• for (i = 0; i < DRM_COLOR_RANGE_MAX; i++) {

• if ((supported_ranges & BIT(i)) == 0)
  

• 	continue;
  

• enum_list[len].type = i;
  

• enum_list[len].name = color_range_name[i];
  

• len++;
  

• }
• prop = drm_property_create_enum(dev, 0, "COLOR_RANGE",

• 			enum_list, len);
  

• if (!prop)

• return -ENOMEM;
  

• plane->color_range_property = prop;
• drm_object_attach_property(&plane->base, prop, default_range);
• if (plane->state)

• plane->state->color_range = default_range;
  

• return 0;

+} +EXPORT_SYMBOL(drm_plane_create_color_properties); diff --git a/include/drm/drm_color_mgmt.h b/include/drm/drm_color_mgmt.h index 03a59cbce621..b3b6d302ca8c 100644 --- a/include/drm/drm_color_mgmt.h +++ b/include/drm/drm_color_mgmt.h @@ -26,6 +26,7 @@ #include <linux/ctype.h>

struct drm_crtc; +struct drm_plane;

uint32_t drm_color_lut_extract(uint32_t user_input, uint32_t bit_precision);

@@ -37,4 +38,22 @@ void drm_crtc_enable_color_mgmt(struct drm_crtc *crtc, int drm_mode_crtc_set_gamma_size(struct drm_crtc *crtc, int gamma_size);

+enum drm_color_encoding {

• DRM_COLOR_YCBCR_BT601,
• DRM_COLOR_YCBCR_BT709,
• DRM_COLOR_YCBCR_BT2020,
• DRM_COLOR_ENCODING_MAX,

+};

+enum drm_color_range {

• DRM_COLOR_YCBCR_LIMITED_RANGE,
• DRM_COLOR_YCBCR_FULL_RANGE,
• DRM_COLOR_RANGE_MAX,

+};

+int drm_plane_create_color_properties(struct drm_plane *plane,

• 		      u32 supported_encodings,
  

• 		      u32 supported_ranges,
  

• 		      enum drm_color_encoding default_encoding,
  

• 		      enum drm_color_range default_range);
  

  #endif

diff --git a/include/drm/drm_plane.h b/include/drm/drm_plane.h index 8185e3468a23..f7bf4a48b1c3 100644 --- a/include/drm/drm_plane.h +++ b/include/drm/drm_plane.h @@ -26,6 +26,7 @@ #include <linux/list.h> #include <linux/ctype.h> #include <drm/drm_mode_object.h> +#include <drm/drm_color_mgmt.h>

struct drm_crtc; struct drm_printer; @@ -112,6 +113,20 @@ struct drm_plane_state { unsigned int zpos; unsigned int normalized_zpos;

• /**

• * @color_encoding:
  

• *
  

• * Color encoding for non RGB formats
  

• */
  

• enum drm_color_encoding color_encoding;
• /**

• * @color_range:
  

• *
  

• * Color range for non RGB formats
  

• */
  

• enum drm_color_range color_range;
• /* Clipped coordinates */ struct drm_rect src, dst;

@@ -558,6 +573,23 @@ struct drm_plane {

struct drm_property *zpos_property; struct drm_property *rotation_property;

• /**

• * @color_encoding_property:
  

• *
  

• * Optional "COLOR_ENCODING" enum property for specifying
  

• * color encoding for non RGB formats.
  

• * See drm_plane_create_color_properties().
  

• */
  

• struct drm_property *color_encoding_property;

• /**

• * @color_range_property:
  

• *
  

• * Optional "COLOR_RANGE" enum property for specifying
  

• * color range for non RGB formats.
  

• * See drm_plane_create_color_properties().
  

• */
  

• struct drm_property *color_range_property; };

  #define obj_to_plane(x) container_of(x, struct drm_plane, base)

On Fri, Nov 30, 2018 at 03:20:59PM +0100, Andrzej Hajda wrote:

Hi Ville,

As Christoph cannot respond till middle next week I can try to respond in his absence, as I am familiar with the subject.

On 30.11.2018 14:25, Ville Syrjälä wrote:

...

On Fri, Nov 30, 2018 at 02:08:11PM +0100, Christoph Manszewski wrote:

...

Hi,

I am looking for a way to export the color encoding and range selection to user space. I came across those properties and am wondering, why they are meant only for non RGB color encodings. Would it be okay, to modify them and use with RGB formats as well?

What you trying to do? Input limited range RGB data and expand to full range?

For example. But there are two more general questions, which surprisingly we have not found answer for.

1. What color encoding and range drm should expect on its input RGB

buffers by default?

RGB is just RGB. There is no encoding. It's assumed to be full range because no one really uses anything else.

2. How userspace should inform drm that given buffer has specified

non-default color encoding and range?

Hopefully this patch introduces such properties but only for YCbCr formats, the question is what should be the best way to expand it to RGB formats:

A. Add another enums: DRM_COLOR_RGB_BT601 and friends.

BT.601 specifies how to encoder RGB data as YCbCr. So without YCbCr BT.601 does not mean anything. Well, the standard does contain other things as well I suppose, but for the purposes of the color encoding prop only that one part is relevant.

B. Reuse current enums, but remove format information from them: DRM_COLOR_YCBCR_BT601 => DRM_COLOR_BT601.

Regards

Andrzej

...

...

Regards, Chris

On 02/19/2018 09:28 PM, Ville Syrjala wrote:

...

From: Jyri Sarha jsarha@ti.com

Add a standard optional properties to support different non RGB color encodings in DRM planes. COLOR_ENCODING select the supported non RGB color encoding, for instance ITU-R BT.709 YCbCr. COLOR_RANGE selects the value ranges within the selected color encoding. The properties are stored to drm_plane object to allow different set of supported encoding for different planes on the device.

v2: Add/fix kerneldocs, verify bitmasks (danvet)

Cc: Harry Wentland harry.wentland@amd.com Cc: Daniel Vetter daniel@ffwll.ch Cc: Daniel Stone daniel@fooishbar.org Cc: Russell King - ARM Linux linux@armlinux.org.uk Cc: Ilia Mirkin imirkin@alum.mit.edu Cc: Hans Verkuil hverkuil@xs4all.nl Cc: Uma Shankar uma.shankar@intel.com Cc: Shashank Sharma shashank.sharma@intel.com Reviewed-by: Ville Syrjälä ville.syrjala@linux.intel.com Signed-off-by: Jyri Sarha jsarha@ti.com [vsyrjala v2: Add/fix kerneldocs, verify bitmasks] Signed-off-by: Ville Syrjälä ville.syrjala@linux.intel.com Reviewed-by: Daniel Vetter daniel.vetter@ffwll.ch

---

drivers/gpu/drm/drm_atomic.c | 8 +++ drivers/gpu/drm/drm_color_mgmt.c | 103 +++++++++++++++++++++++++++++++++++++++ include/drm/drm_color_mgmt.h | 19 ++++++++ include/drm/drm_plane.h | 32 ++++++++++++ 4 files changed, 162 insertions(+)

diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c index 46733d534587..452a0b0bafbc 100644 --- a/drivers/gpu/drm/drm_atomic.c +++ b/drivers/gpu/drm/drm_atomic.c @@ -759,6 +759,10 @@ static int drm_atomic_plane_set_property(struct drm_plane *plane, state->rotation = val; } else if (property == plane->zpos_property) { state->zpos = val;

• } else if (property == plane->color_encoding_property) {

• state->color_encoding = val;
  

• } else if (property == plane->color_range_property) {

• state->color_range = val;
  

  } else if (plane->funcs->atomic_set_property) { return plane->funcs->atomic_set_property(plane, state, property, val);

@@ -818,6 +822,10 @@ drm_atomic_plane_get_property(struct drm_plane *plane, *val = state->rotation; } else if (property == plane->zpos_property) { *val = state->zpos;

• } else if (property == plane->color_encoding_property) {

• *val = state->color_encoding;
  

• } else if (property == plane->color_range_property) {

• *val = state->color_range;
  

  } else if (plane->funcs->atomic_get_property) { return plane->funcs->atomic_get_property(plane, state, property, val); } else {

diff --git a/drivers/gpu/drm/drm_color_mgmt.c b/drivers/gpu/drm/drm_color_mgmt.c index 0d002b045bd2..4b83e078d3e9 100644 --- a/drivers/gpu/drm/drm_color_mgmt.c +++ b/drivers/gpu/drm/drm_color_mgmt.c @@ -88,6 +88,20 @@

• drm_mode_crtc_set_gamma_size(). Drivers which support both should use
• drm_atomic_helper_legacy_gamma_set() to alias the legacy gamma ramp with the
• "GAMMA_LUT" property above.

• • Support for different non RGB color encodings is controlled through
• • &drm_plane specific COLOR_ENCODING and COLOR_RANGE properties. They
• • are set up by calling drm_plane_create_color_properties().
• • "COLOR_ENCODING"
• • Optional plane enum property to support different non RGB
• • color encodings. The driver can provide a subset of standard
• • enum values supported by the DRM plane.
• • "COLOR_RANGE"
• • Optional plane enum property to support different non RGB
• • color parameter ranges. The driver can provide a subset of
• • standard enum values supported by the DRM plane.

  */

  /**

@@ -339,3 +353,92 @@ int drm_mode_gamma_get_ioctl(struct drm_device *dev, drm_modeset_unlock(&crtc->mutex); return ret; }

+static const char * const color_encoding_name[] = {

• [DRM_COLOR_YCBCR_BT601] = "ITU-R BT.601 YCbCr",
• [DRM_COLOR_YCBCR_BT709] = "ITU-R BT.709 YCbCr",
• [DRM_COLOR_YCBCR_BT2020] = "ITU-R BT.2020 YCbCr",

+};

+static const char * const color_range_name[] = {

• [DRM_COLOR_YCBCR_FULL_RANGE] = "YCbCr full range",
• [DRM_COLOR_YCBCR_LIMITED_RANGE] = "YCbCr limited range",

+};

+/**

• • drm_plane_create_color_properties - color encoding related plane properties
• • @plane: plane object
• • @supported_encodings: bitfield indicating supported color encodings
• • @supported_ranges: bitfileld indicating supported color ranges
• • @default_encoding: default color encoding
• • @default_range: default color range
• • Create and attach plane specific COLOR_ENCODING and COLOR_RANGE
• • properties to @plane. The supported encodings and ranges should
• • be provided in supported_encodings and supported_ranges bitmasks.
• • Each bit set in the bitmask indicates that its number as enum
• • value is supported.
• */

+int drm_plane_create_color_properties(struct drm_plane *plane,

• 		      u32 supported_encodings,
  

• 		      u32 supported_ranges,
  

• 		      enum drm_color_encoding default_encoding,
  

• 		      enum drm_color_range default_range)
  

+{

• struct drm_device *dev = plane->dev;
• struct drm_property *prop;
• struct drm_prop_enum_list enum_list[max(DRM_COLOR_ENCODING_MAX,

• 				DRM_COLOR_RANGE_MAX)];
  

• int i, len;
• if (WARN_ON(supported_encodings == 0 ||

•     (supported_encodings & -BIT(DRM_COLOR_ENCODING_MAX)) != 0 ||
  

•     (supported_encodings & BIT(default_encoding)) == 0))
  

• return -EINVAL;
  

• if (WARN_ON(supported_ranges == 0 ||

•     (supported_ranges & -BIT(DRM_COLOR_RANGE_MAX)) != 0 ||
  

•     (supported_ranges & BIT(default_range)) == 0))
  

• return -EINVAL;
  

• len = 0;
• for (i = 0; i < DRM_COLOR_ENCODING_MAX; i++) {

• if ((supported_encodings & BIT(i)) == 0)
  

• 	continue;
  

• enum_list[len].type = i;
  

• enum_list[len].name = color_encoding_name[i];
  

• len++;
  

• }
• prop = drm_property_create_enum(dev, 0, "COLOR_ENCODING",

• 			enum_list, len);
  

• if (!prop)

• return -ENOMEM;
  

• plane->color_encoding_property = prop;
• drm_object_attach_property(&plane->base, prop, default_encoding);
• if (plane->state)

• plane->state->color_encoding = default_encoding;
  

• len = 0;
• for (i = 0; i < DRM_COLOR_RANGE_MAX; i++) {

• if ((supported_ranges & BIT(i)) == 0)
  

• 	continue;
  

• enum_list[len].type = i;
  

• enum_list[len].name = color_range_name[i];
  

• len++;
  

• }
• prop = drm_property_create_enum(dev, 0, "COLOR_RANGE",

• 			enum_list, len);
  

• if (!prop)

• return -ENOMEM;
  

• plane->color_range_property = prop;
• drm_object_attach_property(&plane->base, prop, default_range);
• if (plane->state)

• plane->state->color_range = default_range;
  

• return 0;

+} +EXPORT_SYMBOL(drm_plane_create_color_properties); diff --git a/include/drm/drm_color_mgmt.h b/include/drm/drm_color_mgmt.h index 03a59cbce621..b3b6d302ca8c 100644 --- a/include/drm/drm_color_mgmt.h +++ b/include/drm/drm_color_mgmt.h @@ -26,6 +26,7 @@ #include <linux/ctype.h>

struct drm_crtc; +struct drm_plane;

uint32_t drm_color_lut_extract(uint32_t user_input, uint32_t bit_precision);

@@ -37,4 +38,22 @@ void drm_crtc_enable_color_mgmt(struct drm_crtc *crtc, int drm_mode_crtc_set_gamma_size(struct drm_crtc *crtc, int gamma_size);

+enum drm_color_encoding {

• DRM_COLOR_YCBCR_BT601,
• DRM_COLOR_YCBCR_BT709,
• DRM_COLOR_YCBCR_BT2020,
• DRM_COLOR_ENCODING_MAX,

+};

+enum drm_color_range {

• DRM_COLOR_YCBCR_LIMITED_RANGE,
• DRM_COLOR_YCBCR_FULL_RANGE,
• DRM_COLOR_RANGE_MAX,

+};

+int drm_plane_create_color_properties(struct drm_plane *plane,

• 		      u32 supported_encodings,
  

• 		      u32 supported_ranges,
  

• 		      enum drm_color_encoding default_encoding,
  

• 		      enum drm_color_range default_range);
  

  #endif

diff --git a/include/drm/drm_plane.h b/include/drm/drm_plane.h index 8185e3468a23..f7bf4a48b1c3 100644 --- a/include/drm/drm_plane.h +++ b/include/drm/drm_plane.h @@ -26,6 +26,7 @@ #include <linux/list.h> #include <linux/ctype.h> #include <drm/drm_mode_object.h> +#include <drm/drm_color_mgmt.h>

struct drm_crtc; struct drm_printer; @@ -112,6 +113,20 @@ struct drm_plane_state { unsigned int zpos; unsigned int normalized_zpos;

• /**

• * @color_encoding:
  

• *
  

• * Color encoding for non RGB formats
  

• */
  

• enum drm_color_encoding color_encoding;
• /**

• * @color_range:
  

• *
  

• * Color range for non RGB formats
  

• */
  

• enum drm_color_range color_range;
• /* Clipped coordinates */ struct drm_rect src, dst;

@@ -558,6 +573,23 @@ struct drm_plane {

struct drm_property *zpos_property; struct drm_property *rotation_property;

• /**

• * @color_encoding_property:
  

• *
  

• * Optional "COLOR_ENCODING" enum property for specifying
  

• * color encoding for non RGB formats.
  

• * See drm_plane_create_color_properties().
  

• */
  

• struct drm_property *color_encoding_property;

• /**

• * @color_range_property:
  

• *
  

• * Optional "COLOR_RANGE" enum property for specifying
  

• * color range for non RGB formats.
  

• * See drm_plane_create_color_properties().
  

• */
  

• struct drm_property *color_range_property; };

  #define obj_to_plane(x) container_of(x, struct drm_plane, base)

On 11/30/18 15:20, Andrzej Hajda wrote:

Hi Ville,

As Christoph cannot respond till middle next week I can try to respond in his absence, as I am familiar with the subject.

On 30.11.2018 14:25, Ville Syrjälä wrote:

...

On Fri, Nov 30, 2018 at 02:08:11PM +0100, Christoph Manszewski wrote:

...

Hi,

I am looking for a way to export the color encoding and range selection to user space. I came across those properties and am wondering, why they are meant only for non RGB color encodings. Would it be okay, to modify them and use with RGB formats as well?

What you trying to do? Input limited range RGB data and expand to full range?

For example. But there are two more general questions, which surprisingly we have not found answer for.

1. What color encoding and range drm should expect on its input RGB

buffers by default?

While I am not a drm expert, I am pretty certain it always expects full range RGB.

There is a real use-case for being able to give drm limited range RGB: if the image was filled from an HDMI receiver and that receiver got limited range RGB. That said, most (but not all) receivers can expand it to full range before writing to memory.

2. How userspace should inform drm that given buffer has specified

non-default color encoding and range?

Hopefully this patch introduces such properties but only for YCbCr formats, the question is what should be the best way to expand it to RGB formats:

A. Add another enums: DRM_COLOR_RGB_BT601 and friends.

B. Reuse current enums, but remove format information from them: DRM_COLOR_YCBCR_BT601 => DRM_COLOR_BT601.

The colorspace (BT601, REC709, BT2020) is independent of the quantization range (full/limited) and of the color encoding (YCbCr, RGB). There is also the transfer function, another independent setting.

More background info is here:

https://hverkuil.home.xs4all.nl/spec/uapi/v4l/colorspaces.html

If all you use is a desktop, then it is all simple: full range sRGB. But if you start mixing video captured from an HDMI receiver, then it can become much more complex.

Regards,

Hans

Regards

Andrzej

...

...

Regards, Chris

On 02/19/2018 09:28 PM, Ville Syrjala wrote:

...

From: Jyri Sarha jsarha@ti.com

Add a standard optional properties to support different non RGB color encodings in DRM planes. COLOR_ENCODING select the supported non RGB color encoding, for instance ITU-R BT.709 YCbCr. COLOR_RANGE selects the value ranges within the selected color encoding. The properties are stored to drm_plane object to allow different set of supported encoding for different planes on the device.

v2: Add/fix kerneldocs, verify bitmasks (danvet)

Cc: Harry Wentland harry.wentland@amd.com Cc: Daniel Vetter daniel@ffwll.ch Cc: Daniel Stone daniel@fooishbar.org Cc: Russell King - ARM Linux linux@armlinux.org.uk Cc: Ilia Mirkin imirkin@alum.mit.edu Cc: Hans Verkuil hverkuil@xs4all.nl Cc: Uma Shankar uma.shankar@intel.com Cc: Shashank Sharma shashank.sharma@intel.com Reviewed-by: Ville Syrjälä ville.syrjala@linux.intel.com Signed-off-by: Jyri Sarha jsarha@ti.com [vsyrjala v2: Add/fix kerneldocs, verify bitmasks] Signed-off-by: Ville Syrjälä ville.syrjala@linux.intel.com Reviewed-by: Daniel Vetter daniel.vetter@ffwll.ch

---

drivers/gpu/drm/drm_atomic.c | 8 +++ drivers/gpu/drm/drm_color_mgmt.c | 103 +++++++++++++++++++++++++++++++++++++++ include/drm/drm_color_mgmt.h | 19 ++++++++ include/drm/drm_plane.h | 32 ++++++++++++ 4 files changed, 162 insertions(+)

diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c index 46733d534587..452a0b0bafbc 100644 --- a/drivers/gpu/drm/drm_atomic.c +++ b/drivers/gpu/drm/drm_atomic.c @@ -759,6 +759,10 @@ static int drm_atomic_plane_set_property(struct drm_plane *plane, state->rotation = val; } else if (property == plane->zpos_property) { state->zpos = val;

• } else if (property == plane->color_encoding_property) {

• state->color_encoding = val;
  

• } else if (property == plane->color_range_property) {

• state->color_range = val;
  

  } else if (plane->funcs->atomic_set_property) { return plane->funcs->atomic_set_property(plane, state, property, val);

@@ -818,6 +822,10 @@ drm_atomic_plane_get_property(struct drm_plane *plane, *val = state->rotation; } else if (property == plane->zpos_property) { *val = state->zpos;

• } else if (property == plane->color_encoding_property) {

• *val = state->color_encoding;
  

• } else if (property == plane->color_range_property) {

• *val = state->color_range;
  

  } else if (plane->funcs->atomic_get_property) { return plane->funcs->atomic_get_property(plane, state, property, val); } else {

diff --git a/drivers/gpu/drm/drm_color_mgmt.c b/drivers/gpu/drm/drm_color_mgmt.c index 0d002b045bd2..4b83e078d3e9 100644 --- a/drivers/gpu/drm/drm_color_mgmt.c +++ b/drivers/gpu/drm/drm_color_mgmt.c @@ -88,6 +88,20 @@

• drm_mode_crtc_set_gamma_size(). Drivers which support both should use
• drm_atomic_helper_legacy_gamma_set() to alias the legacy gamma ramp with the
• "GAMMA_LUT" property above.

• • Support for different non RGB color encodings is controlled through
• • &drm_plane specific COLOR_ENCODING and COLOR_RANGE properties. They
• • are set up by calling drm_plane_create_color_properties().
• • "COLOR_ENCODING"
• • Optional plane enum property to support different non RGB
• • color encodings. The driver can provide a subset of standard
• • enum values supported by the DRM plane.
• • "COLOR_RANGE"
• • Optional plane enum property to support different non RGB
• • color parameter ranges. The driver can provide a subset of
• • standard enum values supported by the DRM plane.

  */

  /**

@@ -339,3 +353,92 @@ int drm_mode_gamma_get_ioctl(struct drm_device *dev, drm_modeset_unlock(&crtc->mutex); return ret; }

+static const char * const color_encoding_name[] = {

• [DRM_COLOR_YCBCR_BT601] = "ITU-R BT.601 YCbCr",
• [DRM_COLOR_YCBCR_BT709] = "ITU-R BT.709 YCbCr",
• [DRM_COLOR_YCBCR_BT2020] = "ITU-R BT.2020 YCbCr",

+};

+static const char * const color_range_name[] = {

• [DRM_COLOR_YCBCR_FULL_RANGE] = "YCbCr full range",
• [DRM_COLOR_YCBCR_LIMITED_RANGE] = "YCbCr limited range",

+};

+/**

• • drm_plane_create_color_properties - color encoding related plane properties
• • @plane: plane object
• • @supported_encodings: bitfield indicating supported color encodings
• • @supported_ranges: bitfileld indicating supported color ranges
• • @default_encoding: default color encoding
• • @default_range: default color range
• • Create and attach plane specific COLOR_ENCODING and COLOR_RANGE
• • properties to @plane. The supported encodings and ranges should
• • be provided in supported_encodings and supported_ranges bitmasks.
• • Each bit set in the bitmask indicates that its number as enum
• • value is supported.
• */

+int drm_plane_create_color_properties(struct drm_plane *plane,

• 		      u32 supported_encodings,
  

• 		      u32 supported_ranges,
  

• 		      enum drm_color_encoding default_encoding,
  

• 		      enum drm_color_range default_range)
  

+{

• struct drm_device *dev = plane->dev;
• struct drm_property *prop;
• struct drm_prop_enum_list enum_list[max(DRM_COLOR_ENCODING_MAX,

• 				DRM_COLOR_RANGE_MAX)];
  

• int i, len;
• if (WARN_ON(supported_encodings == 0 ||

•     (supported_encodings & -BIT(DRM_COLOR_ENCODING_MAX)) != 0 ||
  

•     (supported_encodings & BIT(default_encoding)) == 0))
  

• return -EINVAL;
  

• if (WARN_ON(supported_ranges == 0 ||

•     (supported_ranges & -BIT(DRM_COLOR_RANGE_MAX)) != 0 ||
  

•     (supported_ranges & BIT(default_range)) == 0))
  

• return -EINVAL;
  

• len = 0;
• for (i = 0; i < DRM_COLOR_ENCODING_MAX; i++) {

• if ((supported_encodings & BIT(i)) == 0)
  

• 	continue;
  

• enum_list[len].type = i;
  

• enum_list[len].name = color_encoding_name[i];
  

• len++;
  

• }
• prop = drm_property_create_enum(dev, 0, "COLOR_ENCODING",

• 			enum_list, len);
  

• if (!prop)

• return -ENOMEM;
  

• plane->color_encoding_property = prop;
• drm_object_attach_property(&plane->base, prop, default_encoding);
• if (plane->state)

• plane->state->color_encoding = default_encoding;
  

• len = 0;
• for (i = 0; i < DRM_COLOR_RANGE_MAX; i++) {

• if ((supported_ranges & BIT(i)) == 0)
  

• 	continue;
  

• enum_list[len].type = i;
  

• enum_list[len].name = color_range_name[i];
  

• len++;
  

• }
• prop = drm_property_create_enum(dev, 0, "COLOR_RANGE",

• 			enum_list, len);
  

• if (!prop)

• return -ENOMEM;
  

• plane->color_range_property = prop;
• drm_object_attach_property(&plane->base, prop, default_range);
• if (plane->state)

• plane->state->color_range = default_range;
  

• return 0;

+} +EXPORT_SYMBOL(drm_plane_create_color_properties); diff --git a/include/drm/drm_color_mgmt.h b/include/drm/drm_color_mgmt.h index 03a59cbce621..b3b6d302ca8c 100644 --- a/include/drm/drm_color_mgmt.h +++ b/include/drm/drm_color_mgmt.h @@ -26,6 +26,7 @@ #include <linux/ctype.h>

struct drm_crtc; +struct drm_plane;

uint32_t drm_color_lut_extract(uint32_t user_input, uint32_t bit_precision);

@@ -37,4 +38,22 @@ void drm_crtc_enable_color_mgmt(struct drm_crtc *crtc, int drm_mode_crtc_set_gamma_size(struct drm_crtc *crtc, int gamma_size);

+enum drm_color_encoding {

• DRM_COLOR_YCBCR_BT601,
• DRM_COLOR_YCBCR_BT709,
• DRM_COLOR_YCBCR_BT2020,
• DRM_COLOR_ENCODING_MAX,

+};

+enum drm_color_range {

• DRM_COLOR_YCBCR_LIMITED_RANGE,
• DRM_COLOR_YCBCR_FULL_RANGE,
• DRM_COLOR_RANGE_MAX,

+};

+int drm_plane_create_color_properties(struct drm_plane *plane,

• 		      u32 supported_encodings,
  

• 		      u32 supported_ranges,
  

• 		      enum drm_color_encoding default_encoding,
  

• 		      enum drm_color_range default_range);
  

  #endif

diff --git a/include/drm/drm_plane.h b/include/drm/drm_plane.h index 8185e3468a23..f7bf4a48b1c3 100644 --- a/include/drm/drm_plane.h +++ b/include/drm/drm_plane.h @@ -26,6 +26,7 @@ #include <linux/list.h> #include <linux/ctype.h> #include <drm/drm_mode_object.h> +#include <drm/drm_color_mgmt.h>

struct drm_crtc; struct drm_printer; @@ -112,6 +113,20 @@ struct drm_plane_state { unsigned int zpos; unsigned int normalized_zpos;

• /**

• * @color_encoding:
  

• *
  

• * Color encoding for non RGB formats
  

• */
  

• enum drm_color_encoding color_encoding;
• /**

• * @color_range:
  

• *
  

• * Color range for non RGB formats
  

• */
  

• enum drm_color_range color_range;
• /* Clipped coordinates */ struct drm_rect src, dst;

@@ -558,6 +573,23 @@ struct drm_plane {

struct drm_property *zpos_property; struct drm_property *rotation_property;

• /**

• * @color_encoding_property:
  

• *
  

• * Optional "COLOR_ENCODING" enum property for specifying
  

• * color encoding for non RGB formats.
  

• * See drm_plane_create_color_properties().
  

• */
  

• struct drm_property *color_encoding_property;

• /**

• * @color_range_property:
  

• *
  

• * Optional "COLOR_RANGE" enum property for specifying
  

• * color range for non RGB formats.
  

• * See drm_plane_create_color_properties().
  

• */
  

• struct drm_property *color_range_property; };

  #define obj_to_plane(x) container_of(x, struct drm_plane, base)

On Wed, Feb 14, 2018 at 09:23:21PM +0200, Ville Syrjala wrote:

From: Ville Syrjälä ville.syrjala@linux.intel.com

BT.2020 specifies two YCbCr<->RGB conversion formulas. The more traditional non-constant luminance and a more complicate one constant luminance one. Add an enum value for the constant luminance variant as well in case someone has hardware supporting it.

Cc: Harry Wentland harry.wentland@amd.com Cc: Daniel Vetter daniel@ffwll.ch Cc: Daniel Stone daniel@fooishbar.org Cc: Russell King - ARM Linux linux@armlinux.org.uk Cc: Ilia Mirkin imirkin@alum.mit.edu Cc: Hans Verkuil hverkuil@xs4all.nl CC: Uma Shankar uma.shankar@intel.com Cc: Shashank Sharma shashank.sharma@intel.com Cc: Jyri Sarha jsarha@ti.com Signed-off-by: Ville Syrjälä ville.syrjala@linux.intel.com

---

drivers/gpu/drm/drm_color_mgmt.c | 1 + include/drm/drm_color_mgmt.h | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_color_mgmt.c b/drivers/gpu/drm/drm_color_mgmt.c index a84fc861e406..061d342f9d96 100644 --- a/drivers/gpu/drm/drm_color_mgmt.c +++ b/drivers/gpu/drm/drm_color_mgmt.c @@ -357,6 +357,7 @@ static const char * const color_encoding_name[] = { [DRM_COLOR_YCBCR_BT601] = "ITU-R BT.601 YCbCr", [DRM_COLOR_YCBCR_BT709] = "ITU-R BT.709 YCbCr", [DRM_COLOR_YCBCR_BT2020] = "ITU-R BT.2020 YCbCr",

• [DRM_COLOR_YCBCR_BT2020_CONST] = "ITU-R BT.2020 YCbCr constant luminance",

I just realized that this exceeds the max prop enum name length of 31 characters. I guess we'll just have to truncate it to something like "ITU-R BT.2020 YCbCr const". Any better suggestions?

/me goes add some WARN_ON()s for invalid prop/enum names...

};

static const char * const color_range_name[] = { diff --git a/include/drm/drm_color_mgmt.h b/include/drm/drm_color_mgmt.h index b3b6d302ca8c..175943c87d5b 100644 --- a/include/drm/drm_color_mgmt.h +++ b/include/drm/drm_color_mgmt.h @@ -41,7 +41,8 @@ int drm_mode_crtc_set_gamma_size(struct drm_crtc *crtc, enum drm_color_encoding { DRM_COLOR_YCBCR_BT601, DRM_COLOR_YCBCR_BT709,

• DRM_COLOR_YCBCR_BT2020,

• DRM_COLOR_YCBCR_BT2020, /* non-constant luminance */
• DRM_COLOR_YCBCR_BT2020_CONST, /* constant luminance */ DRM_COLOR_ENCODING_MAX,

};

-- 2.13.6

On Wed, Feb 14, 2018 at 09:23:22PM +0200, Ville Syrjala wrote:

From: Ville Syrjälä ville.syrjala@linux.intel.com

Include color_enconding and color_range in the plane state dump.

Cc: Harry Wentland harry.wentland@amd.com Cc: Daniel Vetter daniel@ffwll.ch Cc: Daniel Stone daniel@fooishbar.org Cc: Russell King - ARM Linux linux@armlinux.org.uk Cc: Ilia Mirkin imirkin@alum.mit.edu Cc: Hans Verkuil hverkuil@xs4all.nl Cc: Uma Shankar uma.shankar@intel.com Cc: Shashank Sharma shashank.sharma@intel.com Cc: Jyri Sarha jsarha@ti.com Signed-off-by: Ville Syrjälä ville.syrjala@linux.intel.com

---

drivers/gpu/drm/drm_atomic.c | 4 ++++ drivers/gpu/drm/drm_color_mgmt.c | 16 ++++++++++++++++ drivers/gpu/drm/drm_crtc_internal.h | 2 ++ 3 files changed, 22 insertions(+)

diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c index 452a0b0bafbc..9552052ed31a 100644 --- a/drivers/gpu/drm/drm_atomic.c +++ b/drivers/gpu/drm/drm_atomic.c @@ -952,6 +952,10 @@ static void drm_atomic_plane_print_state(struct drm_printer *p, drm_printf(p, "\tcrtc-pos=" DRM_RECT_FMT "\n", DRM_RECT_ARG(&dest)); drm_printf(p, "\tsrc-pos=" DRM_RECT_FP_FMT "\n", DRM_RECT_FP_ARG(&src)); drm_printf(p, "\trotation=%x\n", state->rotation);

• drm_printf(p, "\tcolor-encoding=%s\n",

•    drm_get_color_encoding_name(state->color_encoding));
  

• drm_printf(p, "\tcolor-range=%s\n",

•    drm_get_color_range_name(state->color_range));
  
  

  if (plane->funcs->atomic_print_state) plane->funcs->atomic_print_state(p, state);

diff --git a/drivers/gpu/drm/drm_color_mgmt.c b/drivers/gpu/drm/drm_color_mgmt.c index 061d342f9d96..06851d575f14 100644 --- a/drivers/gpu/drm/drm_color_mgmt.c +++ b/drivers/gpu/drm/drm_color_mgmt.c @@ -365,6 +365,22 @@ static const char * const color_range_name[] = { [DRM_COLOR_YCBCR_LIMITED_RANGE] = "YCbCr limited range", };

kerneldoc would be neat here ... -Daniel

+const char *drm_get_color_encoding_name(enum drm_color_encoding encoding) +{

• if (WARN_ON(encoding >= ARRAY_SIZE(color_encoding_name)))

• return "unknown";
  

• return color_encoding_name[encoding];

+}

+const char *drm_get_color_range_name(enum drm_color_range range) +{

• if (WARN_ON(range >= ARRAY_SIZE(color_range_name)))

• return "unknown";
  

• return color_range_name[range];

+}

/**

• drm_plane_create_color_properties - color encoding related plane properties
• @supported_encodings: bitfield indicating supported color encodings

diff --git a/drivers/gpu/drm/drm_crtc_internal.h b/drivers/gpu/drm/drm_crtc_internal.h index af00f42ba269..8ca2ffef6231 100644 --- a/drivers/gpu/drm/drm_crtc_internal.h +++ b/drivers/gpu/drm/drm_crtc_internal.h @@ -71,6 +71,8 @@ int drm_mode_destroy_dumb_ioctl(struct drm_device *dev, void *data, struct drm_file *file_priv);

/* drm_color_mgmt.c */ +const char *drm_get_color_encoding_name(enum drm_color_encoding encoding); +const char *drm_get_color_range_name(enum drm_color_range range);

/* IOCTLs */ int drm_mode_gamma_get_ioctl(struct drm_device *dev, -- 2.13.6

On Mon, Feb 19, 2018 at 10:28:46PM +0200, Ville Syrjala wrote:

From: Ville Syrjälä ville.syrjala@linux.intel.com

Include color_enconding and color_range in the plane state dump.

v2: Add kerneldoc (danvet)

Cc: Harry Wentland harry.wentland@amd.com Cc: Daniel Vetter daniel@ffwll.ch Cc: Daniel Stone daniel@fooishbar.org Cc: Russell King - ARM Linux linux@armlinux.org.uk Cc: Ilia Mirkin imirkin@alum.mit.edu Cc: Hans Verkuil hverkuil@xs4all.nl Cc: Uma Shankar uma.shankar@intel.com Cc: Shashank Sharma shashank.sharma@intel.com Cc: Jyri Sarha jsarha@ti.com Signed-off-by: Ville Syrjälä ville.syrjala@linux.intel.com

Reviewed-by: Daniel Vetter daniel.vetter@ffwll.ch

---

drivers/gpu/drm/drm_atomic.c | 4 ++++ drivers/gpu/drm/drm_color_mgmt.c | 30 ++++++++++++++++++++++++++++++ drivers/gpu/drm/drm_crtc_internal.h | 2 ++ 3 files changed, 36 insertions(+)

diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c index 452a0b0bafbc..9552052ed31a 100644 --- a/drivers/gpu/drm/drm_atomic.c +++ b/drivers/gpu/drm/drm_atomic.c @@ -952,6 +952,10 @@ static void drm_atomic_plane_print_state(struct drm_printer *p, drm_printf(p, "\tcrtc-pos=" DRM_RECT_FMT "\n", DRM_RECT_ARG(&dest)); drm_printf(p, "\tsrc-pos=" DRM_RECT_FP_FMT "\n", DRM_RECT_FP_ARG(&src)); drm_printf(p, "\trotation=%x\n", state->rotation);

• drm_printf(p, "\tcolor-encoding=%s\n",

•    drm_get_color_encoding_name(state->color_encoding));
  

• drm_printf(p, "\tcolor-range=%s\n",

•    drm_get_color_range_name(state->color_range));
  
  

  if (plane->funcs->atomic_print_state) plane->funcs->atomic_print_state(p, state);

diff --git a/drivers/gpu/drm/drm_color_mgmt.c b/drivers/gpu/drm/drm_color_mgmt.c index 7b0f1c2d9190..a11a838741c2 100644 --- a/drivers/gpu/drm/drm_color_mgmt.c +++ b/drivers/gpu/drm/drm_color_mgmt.c @@ -367,6 +367,36 @@ static const char * const color_range_name[] = { };

/**

• • drm_get_color_encoding_name - return a string for color encoding
• • @encoding: color encoding to compute name of
• • In contrast to the other drm_get_*_name functions this one here returns a
• • const pointer and hence is threadsafe.
• */

+const char *drm_get_color_encoding_name(enum drm_color_encoding encoding) +{

• if (WARN_ON(encoding >= ARRAY_SIZE(color_encoding_name)))

• return "unknown";
  

• return color_encoding_name[encoding];

+}

+/**

• • drm_get_color_range_name - return a string for color range
• • @range: color range to compute name of
• • In contrast to the other drm_get_*_name functions this one here returns a
• • const pointer and hence is threadsafe.
• */

+const char *drm_get_color_range_name(enum drm_color_range range) +{

• if (WARN_ON(range >= ARRAY_SIZE(color_range_name)))

• return "unknown";
  

• return color_range_name[range];

+}

+/**

• drm_plane_create_color_properties - color encoding related plane properties
• @plane: plane object
• @supported_encodings: bitfield indicating supported color encodings

diff --git a/drivers/gpu/drm/drm_crtc_internal.h b/drivers/gpu/drm/drm_crtc_internal.h index af00f42ba269..8ca2ffef6231 100644 --- a/drivers/gpu/drm/drm_crtc_internal.h +++ b/drivers/gpu/drm/drm_crtc_internal.h @@ -71,6 +71,8 @@ int drm_mode_destroy_dumb_ioctl(struct drm_device *dev, void *data, struct drm_file *file_priv);

/* drm_color_mgmt.c */ +const char *drm_get_color_encoding_name(enum drm_color_encoding encoding); +const char *drm_get_color_range_name(enum drm_color_range range);

/* IOCTLs */ int drm_mode_gamma_get_ioctl(struct drm_device *dev, -- 2.13.6

On Wed, Feb 14, 2018 at 09:23:24PM +0200, Ville Syrjala wrote:

From: Ville Syrjälä ville.syrjala@linux.intel.com

On GLK the plane CSC controls moved into the COLOR_CTL register. Update the code to progam the YCbCr->RGB CSC mode correctly when faced with an YCbCr framebuffer.

The spec is rather confusing as it calls the mode "YUV601 to RGB709". I'm going to assume that just means it's going to use the YCbCr->RGB matrix as specified in BT.601 and doesn't actually change the gamut.

Cc: Harry Wentland harry.wentland@amd.com Cc: Daniel Vetter daniel@ffwll.ch Cc: Daniel Stone daniel@fooishbar.org Cc: Russell King - ARM Linux linux@armlinux.org.uk Cc: Ilia Mirkin imirkin@alum.mit.edu Cc: Hans Verkuil hverkuil@xs4all.nl Cc: Uma Shankar uma.shankar@intel.com Cc: Shashank Sharma shashank.sharma@intel.com Signed-off-by: Ville Syrjälä ville.syrjala@linux.intel.com

Matches the spec, so: Reviewed-by: Imre Deak imre.deak@intel.com

I asked for clarification in the spec about the BT.601 vs. 709 oddity you noticed.

---

drivers/gpu/drm/i915/i915_reg.h | 5 +++++ drivers/gpu/drm/i915/intel_display.c | 3 +++ drivers/gpu/drm/i915/intel_drv.h | 2 ++ drivers/gpu/drm/i915/intel_sprite.c | 10 +++++----- 4 files changed, 15 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index 28b36eac064e..6abeaf64c2d2 100644 --- a/drivers/gpu/drm/i915/i915_reg.h +++ b/drivers/gpu/drm/i915/i915_reg.h @@ -6463,6 +6463,11 @@ enum { #define _PLANE_COLOR_CTL_3_A 0x703CC /* GLK+ */ #define PLANE_COLOR_PIPE_GAMMA_ENABLE (1 << 30) #define PLANE_COLOR_PIPE_CSC_ENABLE (1 << 23) +#define PLANE_COLOR_CSC_MODE_BYPASS (0 << 17) +#define PLANE_COLOR_CSC_MODE_YUV601_TO_RGB709 (1 << 17) +#define PLANE_COLOR_CSC_MODE_YUV709_TO_RGB709 (2 << 17) +#define PLANE_COLOR_CSC_MODE_YUV2020_TO_RGB2020 (3 << 17) +#define PLANE_COLOR_CSC_MODE_RGB709_TO_RGB2020 (4 << 17) #define PLANE_COLOR_PLANE_GAMMA_DISABLE (1 << 13) #define PLANE_COLOR_ALPHA_MASK (0x3 << 4) #define PLANE_COLOR_ALPHA_DISABLE (0 << 4) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 286a9591d179..a22b583838f7 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -3573,6 +3573,9 @@ u32 glk_plane_color_ctl(const struct intel_crtc_state *crtc_state, plane_color_ctl |= PLANE_COLOR_PLANE_GAMMA_DISABLE; plane_color_ctl |= glk_plane_color_ctl_alpha(fb->format->format);

• if (intel_format_is_yuv(fb->format->format))

• plane_color_ctl |= PLANE_COLOR_CSC_MODE_YUV601_TO_RGB709;
  

• return plane_color_ctl;

}

diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h index 898064e8bea7..6e43da40c859 100644 --- a/drivers/gpu/drm/i915/intel_drv.h +++ b/drivers/gpu/drm/i915/intel_drv.h @@ -1591,6 +1591,7 @@ u32 glk_plane_color_ctl(const struct intel_crtc_state *crtc_state, const struct intel_plane_state *plane_state); u32 skl_plane_ctl(const struct intel_crtc_state *crtc_state, const struct intel_plane_state *plane_state); +u32 glk_color_ctl(const struct intel_plane_state *plane_state); u32 skl_plane_stride(const struct drm_framebuffer *fb, int plane, unsigned int rotation); int skl_check_plane_surface(const struct intel_crtc_state *crtc_state, @@ -2016,6 +2017,7 @@ bool intel_sdvo_init(struct drm_i915_private *dev_priv,

/* intel_sprite.c */ +bool intel_format_is_yuv(u32 format); int intel_usecs_to_scanlines(const struct drm_display_mode *adjusted_mode, int usecs); struct intel_plane *intel_sprite_plane_create(struct drm_i915_private *dev_priv, diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c index fac9e01b4795..b4acde2058fe 100644 --- a/drivers/gpu/drm/i915/intel_sprite.c +++ b/drivers/gpu/drm/i915/intel_sprite.c @@ -41,8 +41,7 @@ #include <drm/i915_drm.h> #include "i915_drv.h"

-static bool -format_is_yuv(uint32_t format) +bool intel_format_is_yuv(u32 format) { switch (format) { case DRM_FORMAT_YUYV: @@ -266,6 +265,7 @@ skl_update_plane(struct intel_plane *plane, if (INTEL_GEN(dev_priv) >= 10 || IS_GEMINILAKE(dev_priv)) I915_WRITE_FW(PLANE_COLOR_CTL(pipe, plane_id), plane_state->color_ctl);

• if (key->flags) { I915_WRITE_FW(PLANE_KEYVAL(pipe, plane_id), key->min_value); I915_WRITE_FW(PLANE_KEYMAX(pipe, plane_id), key->max_value);

@@ -354,7 +354,7 @@ chv_update_csc(const struct intel_plane_state *plane_state) enum plane_id plane_id = plane->id;

/* Seems RGB data bypasses the CSC always */

• if (!format_is_yuv(fb->format->format))

• if (!intel_format_is_yuv(fb->format->format)) return;

  /*

@@ -399,7 +399,7 @@ vlv_update_clrc(const struct intel_plane_state *plane_state) enum plane_id plane_id = plane->id; int contrast, brightness, sh_scale, sh_sin, sh_cos;

• if (format_is_yuv(fb->format->format)) {

• if (intel_format_is_yuv(fb->format->format)) { /*
  • Expand limited range to full range:
  • Contrast is applied first and is used to expand Y range.

@@ -1024,7 +1024,7 @@ intel_check_sprite_plane(struct intel_plane *plane, src_y = src->y1 >> 16; src_h = drm_rect_height(src) >> 16;

• if (format_is_yuv(fb->format->format)) {
  

• if (intel_format_is_yuv(fb->format->format)) {
  src_x &= ~1;
  src_w &= ~1;
  
  

-- 2.13.6

---

Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx