This patch declares the function of_get_tve_mode as a static one to fix this sparse warning: drivers/staging/imx-drm/imx-tve.c:563:11: warning: \ symbol 'of_get_tve_mode' was not declared. \ Should it be static?
Acked-by: Shawn Guo shawn.guo@linaro.org Signed-off-by: Liu Ying Ying.Liu@freescale.com --- Changes from v2: -Just added Shawn Guo's ack.
drivers/staging/imx-drm/imx-tve.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/imx-drm/imx-tve.c b/drivers/staging/imx-drm/imx-tve.c index 2c44fef..9abc7ca 100644 --- a/drivers/staging/imx-drm/imx-tve.c +++ b/drivers/staging/imx-drm/imx-tve.c @@ -560,7 +560,7 @@ static const char *imx_tve_modes[] = { [TVE_MODE_VGA] = "vga", };
-const int of_get_tve_mode(struct device_node *np) +static const int of_get_tve_mode(struct device_node *np) { const char *bm; int ret, i;
On Tue, Dec 24, 2013 at 10:17:44AM +0800, Liu Ying wrote:
This patch declares the function of_get_tve_mode as a static one to fix this sparse warning: drivers/staging/imx-drm/imx-tve.c:563:11: warning: \ symbol 'of_get_tve_mode' was not declared. \ Should it be static?
Acked-by: Shawn Guo shawn.guo@linaro.org Signed-off-by: Liu Ying Ying.Liu@freescale.com
Changes from v2: -Just added Shawn Guo's ack.
No need to do that.
regards, dan carpenter
dri-devel@lists.freedesktop.org