Applied. Strangely I can't seem to find this patch in my inbox or in the dri-devel or amd-gfx archives.

Alex

On Tue, Jan 18, 2022 at 9:03 AM Lazar, Lijo lijo.lazar@amd.com wrote:

On 1/18/2022 5:31 PM, Yongzhi Liu wrote:

...

pm_runtime_get_sync() increments the runtime PM usage counter even when it returns an error code, thus a matching decrement is needed on the error handling path to keep the counter balanced.

Signed-off-by: Yongzhi Liu lyz_cs@pku.edu.cn

Thanks!

Reviewed-by: Lijo Lazar lijo.lazar@amd.com

...

---

drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c index 9aea1cc..4b950de 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c @@ -1120,8 +1120,10 @@ static ssize_t amdgpu_debugfs_gfxoff_read(struct file *f, char __user *buf, return -EINVAL;

  r = pm_runtime_get_sync(adev_to_drm(adev)->dev);

• if (r < 0)
  

• if (r < 0) {
  

•         pm_runtime_put_autosuspend(adev_to_drm(adev)->dev);
          return r;
  

• }
  
  while (size) {
          uint32_t value;