Fixed wrong register shift for single/dual link LVDS output.
Signed-off-by: Jiri Vanek jirivanek1@gmail.com --- drivers/gpu/drm/bridge/tc358775.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/tc358775.c b/drivers/gpu/drm/bridge/tc358775.c index 2272adcc5b4a..1d6ec1baeff2 100644 --- a/drivers/gpu/drm/bridge/tc358775.c +++ b/drivers/gpu/drm/bridge/tc358775.c @@ -241,7 +241,7 @@ static inline u32 TC358775_LVCFG_PCLKDIV(uint32_t val) }
#define TC358775_LVCFG_LVDLINK__MASK 0x00000002 -#define TC358775_LVCFG_LVDLINK__SHIFT 0 +#define TC358775_LVCFG_LVDLINK__SHIFT 1 static inline u32 TC358775_LVCFG_LVDLINK(uint32_t val) { return ((val) << TC358775_LVCFG_LVDLINK__SHIFT) &
+ Zhen & Vinay
This patch looks good in itself, but I would like to see a tested by tag. At the very least testing for regression in single-link LVDS but ideally some third party verification of this patch.
On Wed, 10 Nov 2021 at 23:01, Jiri Vanek jirivanek1@gmail.com wrote:
Fixed wrong register shift for single/dual link LVDS output.
Signed-off-by: Jiri Vanek jirivanek1@gmail.com
drivers/gpu/drm/bridge/tc358775.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/tc358775.c b/drivers/gpu/drm/bridge/tc358775.c index 2272adcc5b4a..1d6ec1baeff2 100644 --- a/drivers/gpu/drm/bridge/tc358775.c +++ b/drivers/gpu/drm/bridge/tc358775.c @@ -241,7 +241,7 @@ static inline u32 TC358775_LVCFG_PCLKDIV(uint32_t val) }
#define TC358775_LVCFG_LVDLINK__MASK 0x00000002 -#define TC358775_LVCFG_LVDLINK__SHIFT 0 +#define TC358775_LVCFG_LVDLINK__SHIFT 1 static inline u32 TC358775_LVCFG_LVDLINK(uint32_t val) { return ((val) << TC358775_LVCFG_LVDLINK__SHIFT) & -- 2.30.2
Robert, I do not have the hardware to test this feature. Sorry for the late response.
On Thu, Nov 18, 2021 at 8:20 PM Robert Foss robert.foss@linaro.org wrote:
- Zhen & Vinay
This patch looks good in itself, but I would like to see a tested by tag. At the very least testing for regression in single-link LVDS but ideally some third party verification of this patch.
On Wed, 10 Nov 2021 at 23:01, Jiri Vanek jirivanek1@gmail.com wrote:
Fixed wrong register shift for single/dual link LVDS output.
Signed-off-by: Jiri Vanek jirivanek1@gmail.com
drivers/gpu/drm/bridge/tc358775.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/tc358775.c
b/drivers/gpu/drm/bridge/tc358775.c
index 2272adcc5b4a..1d6ec1baeff2 100644 --- a/drivers/gpu/drm/bridge/tc358775.c +++ b/drivers/gpu/drm/bridge/tc358775.c @@ -241,7 +241,7 @@ static inline u32 TC358775_LVCFG_PCLKDIV(uint32_t
val)
}
#define TC358775_LVCFG_LVDLINK__MASK 0x00000002 -#define TC358775_LVCFG_LVDLINK__SHIFT 0 +#define TC358775_LVCFG_LVDLINK__SHIFT 1 static inline u32 TC358775_LVCFG_LVDLINK(uint32_t val) { return ((val) << TC358775_LVCFG_LVDLINK__SHIFT) & -- 2.30.2
Jiri: Are you able to test this patch?
Vinay: Could you supply a R-b tag, if you feel that it is warranted?
On Tue, 14 Dec 2021 at 09:13, Vinay Simha B N simhavcs@gmail.com wrote:
Robert, I do not have the hardware to test this feature. Sorry for the late response.
On Thu, Nov 18, 2021 at 8:20 PM Robert Foss robert.foss@linaro.org wrote:
- Zhen & Vinay
This patch looks good in itself, but I would like to see a tested by tag. At the very least testing for regression in single-link LVDS but ideally some third party verification of this patch.
On Wed, 10 Nov 2021 at 23:01, Jiri Vanek jirivanek1@gmail.com wrote:
Fixed wrong register shift for single/dual link LVDS output.
Signed-off-by: Jiri Vanek jirivanek1@gmail.com
drivers/gpu/drm/bridge/tc358775.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/tc358775.c b/drivers/gpu/drm/bridge/tc358775.c index 2272adcc5b4a..1d6ec1baeff2 100644 --- a/drivers/gpu/drm/bridge/tc358775.c +++ b/drivers/gpu/drm/bridge/tc358775.c @@ -241,7 +241,7 @@ static inline u32 TC358775_LVCFG_PCLKDIV(uint32_t val) }
#define TC358775_LVCFG_LVDLINK__MASK 0x00000002 -#define TC358775_LVCFG_LVDLINK__SHIFT 0 +#define TC358775_LVCFG_LVDLINK__SHIFT 1 static inline u32 TC358775_LVCFG_LVDLINK(uint32_t val) { return ((val) << TC358775_LVCFG_LVDLINK__SHIFT) & -- 2.30.2
-- regards, vinaysimha
Actually, this patch is based on testing with a real HW with dual-link LVDS display (full HD) and it also matches with a datasheet. Without this fix it does not work at all.
út 4. 1. 2022 v 14:51 odesílatel Robert Foss robert.foss@linaro.org napsal:
Jiri: Are you able to test this patch?
Vinay: Could you supply a R-b tag, if you feel that it is warranted?
On Tue, 14 Dec 2021 at 09:13, Vinay Simha B N simhavcs@gmail.com wrote:
Robert, I do not have the hardware to test this feature. Sorry for the late
response.
On Thu, Nov 18, 2021 at 8:20 PM Robert Foss robert.foss@linaro.org
wrote:
- Zhen & Vinay
This patch looks good in itself, but I would like to see a tested by tag. At the very least testing for regression in single-link LVDS but ideally some third party verification of this patch.
On Wed, 10 Nov 2021 at 23:01, Jiri Vanek jirivanek1@gmail.com wrote:
Fixed wrong register shift for single/dual link LVDS output.
Signed-off-by: Jiri Vanek jirivanek1@gmail.com
drivers/gpu/drm/bridge/tc358775.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/tc358775.c
b/drivers/gpu/drm/bridge/tc358775.c
index 2272adcc5b4a..1d6ec1baeff2 100644 --- a/drivers/gpu/drm/bridge/tc358775.c +++ b/drivers/gpu/drm/bridge/tc358775.c @@ -241,7 +241,7 @@ static inline u32 TC358775_LVCFG_PCLKDIV(uint32_t
val)
}
#define TC358775_LVCFG_LVDLINK__MASK
0x00000002
-#define TC358775_LVCFG_LVDLINK__SHIFT 0 +#define TC358775_LVCFG_LVDLINK__SHIFT 1 static inline u32 TC358775_LVCFG_LVDLINK(uint32_t val) { return ((val) << TC358775_LVCFG_LVDLINK__SHIFT) & -- 2.30.2
-- regards, vinaysimha
Excellent.
Jiri, can you add your Tested-by tag to this patch?
On Tue, 4 Jan 2022 at 15:29, Jiří Vaněk jirivanek1@gmail.com wrote:
Actually, this patch is based on testing with a real HW with dual-link LVDS display (full HD) and it also matches with a datasheet. Without this fix it does not work at all.
út 4. 1. 2022 v 14:51 odesílatel Robert Foss robert.foss@linaro.org napsal:
Jiri: Are you able to test this patch?
Vinay: Could you supply a R-b tag, if you feel that it is warranted?
On Tue, 14 Dec 2021 at 09:13, Vinay Simha B N simhavcs@gmail.com wrote:
Robert, I do not have the hardware to test this feature. Sorry for the late response.
On Thu, Nov 18, 2021 at 8:20 PM Robert Foss robert.foss@linaro.org wrote:
- Zhen & Vinay
This patch looks good in itself, but I would like to see a tested by tag. At the very least testing for regression in single-link LVDS but ideally some third party verification of this patch.
On Wed, 10 Nov 2021 at 23:01, Jiri Vanek jirivanek1@gmail.com wrote:
Fixed wrong register shift for single/dual link LVDS output.
Signed-off-by: Jiri Vanek jirivanek1@gmail.com
drivers/gpu/drm/bridge/tc358775.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/tc358775.c b/drivers/gpu/drm/bridge/tc358775.c index 2272adcc5b4a..1d6ec1baeff2 100644 --- a/drivers/gpu/drm/bridge/tc358775.c +++ b/drivers/gpu/drm/bridge/tc358775.c @@ -241,7 +241,7 @@ static inline u32 TC358775_LVCFG_PCLKDIV(uint32_t val) }
#define TC358775_LVCFG_LVDLINK__MASK 0x00000002 -#define TC358775_LVCFG_LVDLINK__SHIFT 0 +#define TC358775_LVCFG_LVDLINK__SHIFT 1 static inline u32 TC358775_LVCFG_LVDLINK(uint32_t val) { return ((val) << TC358775_LVCFG_LVDLINK__SHIFT) & -- 2.30.2
-- regards, vinaysimha
Jiri Vanek,
Could you please share the part number or datasheet of the dual-link LVDS display used.
On Tue, Jan 4, 2022 at 7:59 PM Jiří Vaněk jirivanek1@gmail.com wrote:
Actually, this patch is based on testing with a real HW with dual-link LVDS display (full HD) and it also matches with a datasheet. Without this fix it does not work at all.
út 4. 1. 2022 v 14:51 odesílatel Robert Foss robert.foss@linaro.org napsal:
Jiri: Are you able to test this patch?
Vinay: Could you supply a R-b tag, if you feel that it is warranted?
On Tue, 14 Dec 2021 at 09:13, Vinay Simha B N simhavcs@gmail.com wrote:
Robert, I do not have the hardware to test this feature. Sorry for the late response.
On Thu, Nov 18, 2021 at 8:20 PM Robert Foss robert.foss@linaro.org wrote:
- Zhen & Vinay
This patch looks good in itself, but I would like to see a tested by tag. At the very least testing for regression in single-link LVDS but ideally some third party verification of this patch.
On Wed, 10 Nov 2021 at 23:01, Jiri Vanek jirivanek1@gmail.com wrote:
Fixed wrong register shift for single/dual link LVDS output.
Signed-off-by: Jiri Vanek jirivanek1@gmail.com
drivers/gpu/drm/bridge/tc358775.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/tc358775.c b/drivers/gpu/drm/bridge/tc358775.c index 2272adcc5b4a..1d6ec1baeff2 100644 --- a/drivers/gpu/drm/bridge/tc358775.c +++ b/drivers/gpu/drm/bridge/tc358775.c @@ -241,7 +241,7 @@ static inline u32 TC358775_LVCFG_PCLKDIV(uint32_t val) }
#define TC358775_LVCFG_LVDLINK__MASK 0x00000002 -#define TC358775_LVCFG_LVDLINK__SHIFT 0 +#define TC358775_LVCFG_LVDLINK__SHIFT 1 static inline u32 TC358775_LVCFG_LVDLINK(uint32_t val) { return ((val) << TC358775_LVCFG_LVDLINK__SHIFT) & -- 2.30.2
-- regards, vinaysimha
Robert, What is R-b tag?
On Tue, Jan 4, 2022 at 7:21 PM Robert Foss robert.foss@linaro.org wrote:
Jiri: Are you able to test this patch?
Vinay: Could you supply a R-b tag, if you feel that it is warranted?
On Tue, 14 Dec 2021 at 09:13, Vinay Simha B N simhavcs@gmail.com wrote:
Robert, I do not have the hardware to test this feature. Sorry for the late response.
On Thu, Nov 18, 2021 at 8:20 PM Robert Foss robert.foss@linaro.org wrote:
- Zhen & Vinay
This patch looks good in itself, but I would like to see a tested by tag. At the very least testing for regression in single-link LVDS but ideally some third party verification of this patch.
On Wed, 10 Nov 2021 at 23:01, Jiri Vanek jirivanek1@gmail.com wrote:
Fixed wrong register shift for single/dual link LVDS output.
Signed-off-by: Jiri Vanek jirivanek1@gmail.com
drivers/gpu/drm/bridge/tc358775.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/tc358775.c b/drivers/gpu/drm/bridge/tc358775.c index 2272adcc5b4a..1d6ec1baeff2 100644 --- a/drivers/gpu/drm/bridge/tc358775.c +++ b/drivers/gpu/drm/bridge/tc358775.c @@ -241,7 +241,7 @@ static inline u32 TC358775_LVCFG_PCLKDIV(uint32_t val) }
#define TC358775_LVCFG_LVDLINK__MASK 0x00000002 -#define TC358775_LVCFG_LVDLINK__SHIFT 0 +#define TC358775_LVCFG_LVDLINK__SHIFT 1 static inline u32 TC358775_LVCFG_LVDLINK(uint32_t val) { return ((val) << TC358775_LVCFG_LVDLINK__SHIFT) & -- 2.30.2
-- regards, vinaysimha
On Tue, Jan 4, 2022, 17:56 Vinay Simha B N simhavcs@gmail.com wrote:
Robert, What is R-b tag?
It looks like this Reviewed-by: Name Lastname <email address>
Maybe have a quick look at this document.
https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html
On Tue, Jan 4, 2022 at 7:21 PM Robert Foss robert.foss@linaro.org wrote:
Jiri: Are you able to test this patch?
Vinay: Could you supply a R-b tag, if you feel that it is warranted?
On Tue, 14 Dec 2021 at 09:13, Vinay Simha B N simhavcs@gmail.com
wrote:
Robert, I do not have the hardware to test this feature. Sorry for the late
response.
On Thu, Nov 18, 2021 at 8:20 PM Robert Foss robert.foss@linaro.org
wrote:
- Zhen & Vinay
This patch looks good in itself, but I would like to see a tested by tag. At the very least testing for regression in single-link LVDS but ideally some third party verification of this patch.
On Wed, 10 Nov 2021 at 23:01, Jiri Vanek jirivanek1@gmail.com
wrote:
Fixed wrong register shift for single/dual link LVDS output.
Signed-off-by: Jiri Vanek jirivanek1@gmail.com
drivers/gpu/drm/bridge/tc358775.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/tc358775.c
b/drivers/gpu/drm/bridge/tc358775.c
index 2272adcc5b4a..1d6ec1baeff2 100644 --- a/drivers/gpu/drm/bridge/tc358775.c +++ b/drivers/gpu/drm/bridge/tc358775.c @@ -241,7 +241,7 @@ static inline u32
TC358775_LVCFG_PCLKDIV(uint32_t val)
}
#define TC358775_LVCFG_LVDLINK__MASK
0x00000002
-#define TC358775_LVCFG_LVDLINK__SHIFT 0 +#define TC358775_LVCFG_LVDLINK__SHIFT 1 static inline u32 TC358775_LVCFG_LVDLINK(uint32_t val) { return ((val) << TC358775_LVCFG_LVDLINK__SHIFT) & -- 2.30.2
-- regards, vinaysimha
-- regards, vinaysimha
Fixed wrong register shift for single/dual link LVDS output.
Tested-by: Jiri Vanek jirivanek1@gmail.com Signed-off-by: Jiri Vanek jirivanek1@gmail.com
--- v1: * Initial version
v2: * Tested-by tag added
--- drivers/gpu/drm/bridge/tc358775.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/tc358775.c b/drivers/gpu/drm/bridge/tc358775.c index 2272adcc5b4a..1d6ec1baeff2 100644 --- a/drivers/gpu/drm/bridge/tc358775.c +++ b/drivers/gpu/drm/bridge/tc358775.c @@ -241,7 +241,7 @@ static inline u32 TC358775_LVCFG_PCLKDIV(uint32_t val) }
#define TC358775_LVCFG_LVDLINK__MASK 0x00000002 -#define TC358775_LVCFG_LVDLINK__SHIFT 0 +#define TC358775_LVCFG_LVDLINK__SHIFT 1 static inline u32 TC358775_LVCFG_LVDLINK(uint32_t val) { return ((val) << TC358775_LVCFG_LVDLINK__SHIFT) &
Reviewed-by: Vinay Simha BN simhavcs@gmail.com
Jiri Vanek, Could you please share the part number or datasheet of the dual-link LVDS display/panel used.
On Fri, Jan 7, 2022 at 12:30 AM Jiri Vanek jirivanek1@gmail.com wrote:
Fixed wrong register shift for single/dual link LVDS output.
Tested-by: Jiri Vanek jirivanek1@gmail.com Signed-off-by: Jiri Vanek jirivanek1@gmail.com
v1:
- Initial version
v2:
- Tested-by tag added
drivers/gpu/drm/bridge/tc358775.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/tc358775.c b/drivers/gpu/drm/bridge/tc358775.c index 2272adcc5b4a..1d6ec1baeff2 100644 --- a/drivers/gpu/drm/bridge/tc358775.c +++ b/drivers/gpu/drm/bridge/tc358775.c @@ -241,7 +241,7 @@ static inline u32 TC358775_LVCFG_PCLKDIV(uint32_t val) }
#define TC358775_LVCFG_LVDLINK__MASK 0x00000002 -#define TC358775_LVCFG_LVDLINK__SHIFT 0 +#define TC358775_LVCFG_LVDLINK__SHIFT 1 static inline u32 TC358775_LVCFG_LVDLINK(uint32_t val) { return ((val) << TC358775_LVCFG_LVDLINK__SHIFT) & -- 2.30.2
On Thu, 6 Jan 2022 at 20:22, Vinay Simha B N simhavcs@gmail.com wrote:
Reviewed-by: Vinay Simha BN simhavcs@gmail.com
Jiri Vanek, Could you please share the part number or datasheet of the dual-link LVDS display/panel used.
On Fri, Jan 7, 2022 at 12:30 AM Jiri Vanek jirivanek1@gmail.com wrote:
Fixed wrong register shift for single/dual link LVDS output.
Tested-by: Jiri Vanek jirivanek1@gmail.com Signed-off-by: Jiri Vanek jirivanek1@gmail.com
v1:
- Initial version
v2:
- Tested-by tag added
drivers/gpu/drm/bridge/tc358775.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/tc358775.c b/drivers/gpu/drm/bridge/tc358775.c index 2272adcc5b4a..1d6ec1baeff2 100644 --- a/drivers/gpu/drm/bridge/tc358775.c +++ b/drivers/gpu/drm/bridge/tc358775.c @@ -241,7 +241,7 @@ static inline u32 TC358775_LVCFG_PCLKDIV(uint32_t val) }
#define TC358775_LVCFG_LVDLINK__MASK 0x00000002 -#define TC358775_LVCFG_LVDLINK__SHIFT 0 +#define TC358775_LVCFG_LVDLINK__SHIFT 1 static inline u32 TC358775_LVCFG_LVDLINK(uint32_t val) { return ((val) << TC358775_LVCFG_LVDLINK__SHIFT) & --
Applied to drm-misc-next
AUO P215HVN01.0 / AUO G215HVN01.0
čt 6. 1. 2022 v 20:22 odesílatel Vinay Simha B N simhavcs@gmail.com napsal:
Reviewed-by: Vinay Simha BN simhavcs@gmail.com
Jiri Vanek, Could you please share the part number or datasheet of the dual-link LVDS display/panel used.
On Fri, Jan 7, 2022 at 12:30 AM Jiri Vanek jirivanek1@gmail.com wrote:
Fixed wrong register shift for single/dual link LVDS output.
Tested-by: Jiri Vanek jirivanek1@gmail.com Signed-off-by: Jiri Vanek jirivanek1@gmail.com
v1:
- Initial version
v2:
- Tested-by tag added
drivers/gpu/drm/bridge/tc358775.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/tc358775.c b/drivers/gpu/drm/bridge/tc358775.c index 2272adcc5b4a..1d6ec1baeff2 100644 --- a/drivers/gpu/drm/bridge/tc358775.c +++ b/drivers/gpu/drm/bridge/tc358775.c @@ -241,7 +241,7 @@ static inline u32 TC358775_LVCFG_PCLKDIV(uint32_t val) }
#define TC358775_LVCFG_LVDLINK__MASK 0x00000002 -#define TC358775_LVCFG_LVDLINK__SHIFT 0 +#define TC358775_LVCFG_LVDLINK__SHIFT 1 static inline u32 TC358775_LVCFG_LVDLINK(uint32_t val) { return ((val) << TC358775_LVCFG_LVDLINK__SHIFT) & -- 2.30.2
-- regards, vinaysimha
dri-devel@lists.freedesktop.org
-
Jiri Vanek -
Jiří Vaněk
-
Robert Foss -
Vinay Simha B N