[Bug 90056] Unigine Valley regression since radeon/llvm: Run LLVM's instruction combining pass

List overview All Threads
Download

newer

older

[Bug 90439] Xonotic render green...

block_all_signals() usage in DRM

bugzilla-daemon＠freedesktop.org

16 Apr 2015 16 Apr '15

9:45 p.m.

https://bugs.freedesktop.org/show_bug.cgi?id=90056

Bug ID: 90056 Summary: Unigine Valley regression since radeon/llvm: Run LLVM's instruction combining pass Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/radeonsi Assignee: dri-devel@lists.freedesktop.org Reporter: adf.lists@gmail.com QA Contact: dri-devel@lists.freedesktop.org

R9270X

Since

commit c6d79ed289a75f13c65f011be870f7e43a0fedc7 Author: Tom Stellard thomas.stellard@amd.com Date: Fri Apr 10 17:07:16 2015 +0000

radeon/llvm: Run LLVM's instruction combining pass

This should improve code quality in general and will help with some future changes to how we emit kill instructions.

shader-db shows a few regressions, but these don't seem to be the result of deficiencies in instcombine. They're mostly caused by the scheduler making different decisions than before.

Unigine Valley quits saying -

Unhandled loop condition! UNREACHABLE executed at SIAnnotateControlFlow.cpp:267!

Only tried my normal settings on valley which are

quality ultra + 8x AA

-- You are receiving this mail because: You are the assignee for the bug.

Attachments:

attachment.html (text/html — 2.7 KB)

Show replies by date

bugzilla-daemon＠freedesktop.org

16 Apr 16 Apr

11:16 p.m.

https://bugs.freedesktop.org/show_bug.cgi?id=90056

--- Comment #1 from Tom Stellard tstellar@gmail.com --- Could you run the program with the environment variable R600_DEBUG=ps,vs,gs and post the output.

-- You are receiving this mail because: You are the assignee for the bug.

bugzilla-daemon＠freedesktop.org

11:41 p.m.

https://bugs.freedesktop.org/show_bug.cgi?id=90056

--- Comment #2 from Andy Furniss adf.lists@gmail.com --- Created attachment 115136 --> https://bugs.freedesktop.org/attachment.cgi?id=115136&action=edit valley with R600_DEBUG=ps,vs,gs

-- You are receiving this mail because: You are the assignee for the bug.

bugzilla-daemon＠freedesktop.org

17 Apr 17 Apr

7:22 a.m.

https://bugs.freedesktop.org/show_bug.cgi?id=90056

--- Comment #3 from Grigori Goronzy greg@chown.ath.cx --- Control flow annotation seems to choke on a predecessor with "undef" incoming value, for some reason.

-- You are receiving this mail because: You are the assignee for the bug.

bugzilla-daemon＠freedesktop.org

25 Apr 25 Apr

10:53 p.m.

https://bugs.freedesktop.org/show_bug.cgi?id=90056

--- Comment #4 from Grigori Goronzy greg@chown.ath.cx --- Created attachment 115333 --> https://bugs.freedesktop.org/attachment.cgi?id=115333&action=edit Reduced test case

Here's a reduced testcase. I'm not sure how undef branch conditions are supposed to be handled, make someone else can take a look?

-- You are receiving this mail because: You are the assignee for the bug.

bugzilla-daemon＠freedesktop.org

28 Apr 28 Apr

8:22 a.m.

https://bugs.freedesktop.org/show_bug.cgi?id=90056

--- Comment #5 from Michel Dänzer michel@daenzer.net --- If this can't be fixed soon, maybe the bisected change should be reverted for now?

-- You are receiving this mail because: You are the assignee for the bug.

bugzilla-daemon＠freedesktop.org

10:54 a.m.

https://bugs.freedesktop.org/show_bug.cgi?id=90056

--- Comment #6 from Grigori Goronzy greg@chown.ath.cx --- Created attachment 115401 --> https://bugs.freedesktop.org/attachment.cgi?id=115401&action=edit Possible fix

How about this? Not tested yet, I don't have access to a radeon GPU right now.

-- You are receiving this mail because: You are the assignee for the bug.

bugzilla-daemon＠freedesktop.org

1:03 p.m.

https://bugs.freedesktop.org/show_bug.cgi?id=90056

--- Comment #7 from Andy Furniss adf.lists@gmail.com --- (In reply to Grigori Goronzy from comment #6)

...

Created attachment 115401 [details] [review] Possible fix

How about this? Not tested yet, I don't have access to a radeon GPU right now.

It doesn't help valley.

-- You are receiving this mail because: You are the assignee for the bug.

bugzilla-daemon＠freedesktop.org

5:03 p.m.

https://bugs.freedesktop.org/show_bug.cgi?id=90056

--- Comment #8 from Tom Stellard tstellar@gmail.com --- Does this patch help: http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20150202/257738....

-- You are receiving this mail because: You are the assignee for the bug.

bugzilla-daemon＠freedesktop.org

5:25 p.m.

https://bugs.freedesktop.org/show_bug.cgi?id=90056

--- Comment #9 from Grigori Goronzy greg@chown.ath.cx --- Created attachment 115409 --> https://bugs.freedesktop.org/attachment.cgi?id=115409&action=edit Full shader

That does not help either. Seems to break the SSA somehow. Full shader that triggers the bug attached.

The patch I posted earlier help with the the reduced testcase, but not with the full shader. Both undef incoming values in phi nodes and undef branch conditions cause problems in different ways.

-- You are receiving this mail because: You are the assignee for the bug.

bugzilla-daemon＠freedesktop.org

6:03 p.m.

https://bugs.freedesktop.org/show_bug.cgi?id=90056

--- Comment #10 from Andy Furniss adf.lists@gmail.com --- (In reply to Grigori Goronzy from comment #9)

...

Created attachment 115409 [details] [review] Full shader

That does not help either. Seems to break the SSA somehow. Full shader that triggers the bug attached.

The patch I posted earlier help with the the reduced testcase, but not with the full shader. Both undef incoming values in phi nodes and undef branch conditions cause problems in different ways.

With the second patch + valley I get -

valley_x64: LiveVariables.cpp:114: void llvm::LiveVariables::MarkVirtRegAliveInBlock(llvm::LiveVariables::VarInfo &, llvm::MachineBasicBlock *, llvm::MachineBasicBlock *, std::vector<MachineBasicBlock *> &): Assertion `MBB != &MF->front() && "Can't find reaching def for virtreg"' failed.

-- You are receiving this mail because: You are the assignee for the bug.

bugzilla-daemon＠freedesktop.org

29 Apr 29 Apr

2:04 a.m.

https://bugs.freedesktop.org/show_bug.cgi?id=90056

--- Comment #11 from Tom Stellard tstellar@gmail.com --- Created attachment 115423 --> https://bugs.freedesktop.org/attachment.cgi?id=115423&action=edit Reduced test case

-- You are receiving this mail because: You are the assignee for the bug.

bugzilla-daemon＠freedesktop.org

2:06 a.m.

https://bugs.freedesktop.org/show_bug.cgi?id=90056

--- Comment #12 from Tom Stellard tstellar@gmail.com --- (In reply to Andy Furniss from comment #10)

...

(In reply to Grigori Goronzy from comment #9)

...
Created attachment 115409 [details] [review] [review] Full shader

That does not help either. Seems to break the SSA somehow. Full shader that triggers the bug attached.

The patch I posted earlier help with the the reduced testcase, but not with the full shader. Both undef incoming values in phi nodes and undef branch conditions cause problems in different ways.

With the second patch + valley I get -

valley_x64: LiveVariables.cpp:114: void llvm::LiveVariables::MarkVirtRegAliveInBlock(llvm::LiveVariables::VarInfo &, llvm::MachineBasicBlock *, llvm::MachineBasicBlock *, std::vector<MachineBasicBlock *> &): Assertion `MBB != &MF->front() && "Can't find reaching def for virtreg"' failed.

Did test with only the patch from comment #8 or did you test with both patches?

-- You are receiving this mail because: You are the assignee for the bug.

bugzilla-daemon＠freedesktop.org

9:48 a.m.

https://bugs.freedesktop.org/show_bug.cgi?id=90056

--- Comment #13 from Andy Furniss adf.lists@gmail.com --- (In reply to Tom Stellard from comment #12)

...

(In reply to Andy Furniss from comment #10)

...
(In reply to Grigori Goronzy from comment #9)

...
Created attachment 115409 [details] [review] [review] [review] Full shader

That does not help either. Seems to break the SSA somehow. Full shader that triggers the bug attached.

The patch I posted earlier help with the the reduced testcase, but not with the full shader. Both undef incoming values in phi nodes and undef branch conditions cause problems in different ways.

With the second patch + valley I get -

valley_x64: LiveVariables.cpp:114: void llvm::LiveVariables::MarkVirtRegAliveInBlock(llvm::LiveVariables::VarInfo &, llvm::MachineBasicBlock *, llvm::MachineBasicBlock *, std::vector<MachineBasicBlock *> &): Assertion `MBB != &MF->front() && "Can't find reaching def for virtreg"' failed.

Did test with only the patch from comment #8 or did you test with both patches?

Just #8 but I just tried with both and get the same fail.

-- You are receiving this mail because: You are the assignee for the bug.

bugzilla-daemon＠freedesktop.org

9:02 p.m.

https://bugs.freedesktop.org/show_bug.cgi?id=90056

Tom Stellard tstellar@gmail.com changed:

-- You are receiving this mail because: You are the assignee for the bug.

bugzilla-daemon＠freedesktop.org

30 Apr 30 Apr

9:19 p.m.

https://bugs.freedesktop.org/show_bug.cgi?id=90056

--- Comment #14 from Tom Stellard tstellar@gmail.com --- Created attachment 115488 --> https://bugs.freedesktop.org/attachment.cgi?id=115488&action=edit Possible fix

Can you try this applying this patch only?

-- You are receiving this mail because: You are the assignee for the bug.

bugzilla-daemon＠freedesktop.org

10:17 p.m.

https://bugs.freedesktop.org/show_bug.cgi?id=90056

--- Comment #15 from Andy Furniss adf.lists@gmail.com --- (In reply to Tom Stellard from comment #14)

...

Created attachment 115488 [details] [review] Possible fix

Can you try this applying this patch only?

This fixes it.

-- You are receiving this mail because: You are the assignee for the bug.

bugzilla-daemon＠freedesktop.org

1 May 1 May

3:57 a.m.

https://bugs.freedesktop.org/show_bug.cgi?id=90056

Tom Stellard tstellar@gmail.com changed:

--- Comment #16 from Tom Stellard tstellar@gmail.com --- Fixed in llvm: r236306

-- You are receiving this mail because: You are the assignee for the bug.

bugzilla-daemon＠freedesktop.org

11 May 11 May

9:38 p.m.

https://bugs.freedesktop.org/show_bug.cgi?id=90056

--- Comment #17 from falaca@gmail.com --- Since mesa 10.6 is going RC soon, what's going to happen with this feature? If it remains enabled, and the fix isn't backported to llvm 3.6, this bug will end up being present in a stable release (unless llvm 3.7 is also going to be released soon).

Fez is also affected by the same bug (I tested and verified that it is fixed by the same patch), so there may be many more games affected:

Good (mesa 10.5): https://www.dropbox.com/s/h7qtlgln1xlnxrk/fez_good.png?dl=0 Bad (mesa 10.6): https://www.dropbox.com/s/f5yqqx2l6pz284z/fez_bad.png?dl=0

-- You are receiving this mail because: You are the assignee for the bug.

bugzilla-daemon＠freedesktop.org

25 May 25 May

10:06 p.m.

https://bugs.freedesktop.org/show_bug.cgi?id=90056

--- Comment #18 from Tom Stellard tstellar@gmail.com --- (In reply to Furkan from comment #17)

...

Since mesa 10.6 is going RC soon, what's going to happen with this feature? If it remains enabled, and the fix isn't backported to llvm 3.6, this bug will end up being present in a stable release (unless llvm 3.7 is also going to be released soon).

Fez is also affected by the same bug (I tested and verified that it is fixed by the same patch), so there may be many more games affected:

Good (mesa 10.5): https://www.dropbox.com/s/h7qtlgln1xlnxrk/fez_good.png?dl=0 Bad (mesa 10.6): https://www.dropbox.com/s/f5yqqx2l6pz284z/fez_bad.png?dl=0

This bug will be fixed in the LLVM 3.6.1 release.

-- You are receiving this mail because: You are the assignee for the bug.

3634

Age (days ago)

3673

Last active (days ago)

dri-devel@lists.freedesktop.org

19 comments

1 participants

tags (0)

participants (1)

bugzilla-daemon＠freedesktop.org