Hi Ben,
My Macbook Pro Retina fails to resume properly on 3.8. I tracked this down to commit 6c5a04249d7afeea3e0ed971e7813f84e29a1706 (drm/nvd0/disp: move link training helpers into core as display methods)
Anything I can try to help solve this?
Note, I'm using the Intel driver as the main controller for this laptop, well, I think I am, my xorg log is attached.
And sorry for not reporting this sooner, it took me a long time to bisect down, there were other resume and boot issues on the bisect trail leading to this, the full log is below.
thanks,
greg k-h
git bisect start # good: [29594404d7fe73cd80eaa4ee8c43dcc53970c60e] Linux 3.7 git bisect good 29594404d7fe73cd80eaa4ee8c43dcc53970c60e # bad: [19f949f52599ba7c3f67a5897ac6be14bfcb1200] Linux 3.8 git bisect bad 19f949f52599ba7c3f67a5897ac6be14bfcb1200 # good: [dadfab4873256d2145640c0ce468fcbfb48977fe] Merge tag 'firewire-updates' of git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394 git bisect good dadfab4873256d2145640c0ce468fcbfb48977fe # bad: [992956189de58cae9f2be40585bc25105cd7c5ad] efi: Fix the build with user namespaces enabled. git bisect bad 992956189de58cae9f2be40585bc25105cd7c5ad # skip: [2b8318881ddbcb67c5e8d2178b42284749442222] Merge tag 'fbdev-for-3.8' of git://gitorious.org/linux-omap-dss2/linux git bisect skip 2b8318881ddbcb67c5e8d2178b42284749442222 # good: [da22f22e91f0d14d996c7258101575a5a06ddf85] ssb: add ssb_chipco_gpio_pull{up,down} git bisect good da22f22e91f0d14d996c7258101575a5a06ddf85 # good: [bb523fc08d4a4a726c7555be7800735685888b3c] drm/i915: convert PIPE_CLK_SEL to transcoder git bisect good bb523fc08d4a4a726c7555be7800735685888b3c # good: [d3e4ea017a414a19ab11a10b52e80a0c8b3f1670] [media] em28xx-cards: fix a warning git bisect good d3e4ea017a414a19ab11a10b52e80a0c8b3f1670 # good: [3fcb6eb4063ab4eef05601c266afa2af667c8e1f] video: exynos_dp: remove redundant parameters git bisect good 3fcb6eb4063ab4eef05601c266afa2af667c8e1f # good: [c5b005ab7091c9ef4ca9b47569a8e27e54588933] drbd: use bitmap_parse instead of __bitmap_parse git bisect good c5b005ab7091c9ef4ca9b47569a8e27e54588933 # skip: [c13e69b2f0e1e2da41a175c7e9215659842cbef9] Merge tag 'upstream-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev git bisect skip c13e69b2f0e1e2da41a175c7e9215659842cbef9 # good: [c8241969b44438c9335b59d375b627214bc36483] drm/i915: pass adjusted_mode to intel_choose_pipe_bpp_dither(), again git bisect good c8241969b44438c9335b59d375b627214bc36483 # skip: [c5258190c2ae664cdf367417a2a25e5fa4104322] Merge branch 'next' of git://git.monstr.eu/linux-2.6-microblaze git bisect skip c5258190c2ae664cdf367417a2a25e5fa4104322 # good: [24ebb37e6515d999bb27f5f8de6ff30faa7479f5] HID: i2c-hid: change I2C name git bisect good 24ebb37e6515d999bb27f5f8de6ff30faa7479f5 # good: [189e11731aa858597095fbe1e6d243bad26bd96b] x86: pvclock: add note about rdtsc barriers git bisect good 189e11731aa858597095fbe1e6d243bad26bd96b # skip: [75e300c8ba5864367634d946c729d8fd05c1cbc2] Merge tag 'for-v3.8' of git://git.infradead.org/users/cbou/linux-pstore git bisect skip 75e300c8ba5864367634d946c729d8fd05c1cbc2 # good: [08ff32352d6ff7083533dc1c25618d42f92ec28e] mlx4: 64-byte CQE/EQE support git bisect good 08ff32352d6ff7083533dc1c25618d42f92ec28e # skip: [e81d372ff9f694e13fa46e8b5aaed505c7fd2a1f] Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/cooloney/linux-leds git bisect skip e81d372ff9f694e13fa46e8b5aaed505c7fd2a1f # good: [fc8d7547b1e19e1bb8f3206837ee0c7c6538e2e5] RDMA/nes: Fix for sending fpdus in order to hardware git bisect good fc8d7547b1e19e1bb8f3206837ee0c7c6538e2e5 # good: [4247bfe20ab1cb8cf1874b811c0dc60bcd0249e8] Merge remote-tracking branch 'regulator/topic/stub' into regulator-next git bisect good 4247bfe20ab1cb8cf1874b811c0dc60bcd0249e8 # good: [5028ea04c8a8a67fe73f18f5f34386730c9c1bf2] OMAPDSS: Remove acb and acbi fields from omap_dss_device git bisect good 5028ea04c8a8a67fe73f18f5f34386730c9c1bf2 # good: [986836503e49ccf7e84b813715d344964ec93566] Merge branch 'drbd-8.4_ed6' into for-3.8-drivers-drbd-8.4_ed6 git bisect good 986836503e49ccf7e84b813715d344964ec93566 # bad: [9add1ac3dd256ad12e266f8403daf928be19953f] Merge branch 'drm-next-3.8' of git://people.freedesktop.org/~agd5f/linux into drm-next git bisect bad 9add1ac3dd256ad12e266f8403daf928be19953f # good: [1f2285d462c02ef9b82ee9c553a31884c23994f0] drm/nouveau/clk: fix crystal frequency retrieval on nv25 git bisect good 1f2285d462c02ef9b82ee9c553a31884c23994f0 # bad: [bd3b49f25a3eae2d91432247b7565489120b6bcf] drm: tegra: Add maintainers entry git bisect bad bd3b49f25a3eae2d91432247b7565489120b6bcf # bad: [6c8e4633d351f6f794c8a5c03f19e8d5a25f9639] drm/nouveau/dp: move core link training calls to common code git bisect bad 6c8e4633d351f6f794c8a5c03f19e8d5a25f9639 # good: [b6caea505879c4a606cf364442fd1f06f6c40e30] drm/nouveau/bios: implement BIT 'U' table (and subtable) parsing in core git bisect good b6caea505879c4a606cf364442fd1f06f6c40e30 # skip: [ed58aee93c45d5095253d9bc370b418e3d767940] drm/nvd0/disp: handle DP transfer unit setup from second supervisor interrupt git bisect skip ed58aee93c45d5095253d9bc370b418e3d767940 # skip: [4a230fa61884ffe6b6a806563eee82f12a60fa1e] drm/nvd0/disp: calculate U script id in supervisor interrupt git bisect skip 4a230fa61884ffe6b6a806563eee82f12a60fa1e # bad: [0a9e2b959f2a1673ca9315df8e0b6dec1069060e] drm/nvd0/disp: move HDA codec setup to core git bisect bad 0a9e2b959f2a1673ca9315df8e0b6dec1069060e # good: [cbe7270d48670889a88705478a68d000b0bc3f6e] drm/nouveau/core: expose full method calling capabilities with nv_exec git bisect good cbe7270d48670889a88705478a68d000b0bc3f6e # bad: [6c5a04249d7afeea3e0ed971e7813f84e29a1706] drm/nvd0/disp: move link training helpers into core as display methods git bisect bad 6c5a04249d7afeea3e0ed971e7813f84e29a1706 # good: [fb445b3c23a4ae75190e814d952be6dce6181abe] drm/nouveau/core: allow representing method ranges in nouveau_omthds git bisect good fb445b3c23a4ae75190e814d952be6dce6181abe
On Mon, Feb 25, 2013 at 3:52 PM, Greg KH gregkh@linuxfoundation.org wrote:
Hi Ben,
My Macbook Pro Retina fails to resume properly on 3.8. I tracked this down to commit 6c5a04249d7afeea3e0ed971e7813f84e29a1706 (drm/nvd0/disp: move link training helpers into core as display methods)
Anything I can try to help solve this?
Note, I'm using the Intel driver as the main controller for this laptop, well, I think I am, my xorg log is attached.
No you are using the nvidia, the efi always boots nvidia enabled now.
Cool, might have to lend Ben my retina to see if he can reproduce.
Dave.
On Mon, Feb 25, 2013 at 4:06 PM, Dave Airlie airlied@gmail.com wrote:
On Mon, Feb 25, 2013 at 3:52 PM, Greg KH gregkh@linuxfoundation.org wrote:
Hi Ben,
My Macbook Pro Retina fails to resume properly on 3.8. I tracked this down to commit 6c5a04249d7afeea3e0ed971e7813f84e29a1706 (drm/nvd0/disp: move link training helpers into core as display methods)
Anything I can try to help solve this?
Note, I'm using the Intel driver as the main controller for this laptop, well, I think I am, my xorg log is attached.
No you are using the nvidia, the efi always boots nvidia enabled now.
Cool, might have to lend Ben my retina to see if he can reproduce.
btw I just tested my drm-next tree on mine and it resumed the display fine, something oopsed a few seconds later that I haven't tracked down
git://git.freedesktop.org/~airlied/linux drm-next
I'll be sending it to Linus this evening or tomorrow morning, once I fix my tree.
Dave.
On Mon, Feb 25, 2013 at 04:06:02PM +1000, Dave Airlie wrote:
On Mon, Feb 25, 2013 at 3:52 PM, Greg KH gregkh@linuxfoundation.org wrote:
Hi Ben,
My Macbook Pro Retina fails to resume properly on 3.8. I tracked this down to commit 6c5a04249d7afeea3e0ed971e7813f84e29a1706 (drm/nvd0/disp: move link training helpers into core as display methods)
Anything I can try to help solve this?
Note, I'm using the Intel driver as the main controller for this laptop, well, I think I am, my xorg log is attached.
No you are using the nvidia, the efi always boots nvidia enabled now.
Really? When did that change? I thought I wanted to be using the Intel chip to save battery life.
btw I just tested my drm-next tree on mine and it resumed the display fine, something oopsed a few seconds later that I haven't tracked down
git://git.freedesktop.org/~airlied/linux drm-next
I'll be sending it to Linus this evening or tomorrow morning, once I fix my tree.
Ok, I'll test again when it hits Linus's tree, and if that works, it would be good to try to work out what patch fixes it to get them into the 3.8-stable series so that others don't run into the same problem.
thanks,
greg k-h
On Mon, Feb 25, 2013 at 02:32:43PM -0800, Greg KH wrote:
On Mon, Feb 25, 2013 at 04:06:02PM +1000, Dave Airlie wrote:
On Mon, Feb 25, 2013 at 3:52 PM, Greg KH gregkh@linuxfoundation.org wrote:
Hi Ben,
My Macbook Pro Retina fails to resume properly on 3.8. I tracked this down to commit 6c5a04249d7afeea3e0ed971e7813f84e29a1706 (drm/nvd0/disp: move link training helpers into core as display methods)
Anything I can try to help solve this?
Note, I'm using the Intel driver as the main controller for this laptop, well, I think I am, my xorg log is attached.
No you are using the nvidia, the efi always boots nvidia enabled now.
Really? When did that change? I thought I wanted to be using the Intel chip to save battery life.
btw I just tested my drm-next tree on mine and it resumed the display fine, something oopsed a few seconds later that I haven't tracked down
git://git.freedesktop.org/~airlied/linux drm-next
I'll be sending it to Linus this evening or tomorrow morning, once I fix my tree.
Ok, I'll test again when it hits Linus's tree, and if that works, it would be good to try to work out what patch fixes it to get them into the 3.8-stable series so that others don't run into the same problem.
I've tested Linus's tree now (I'm guessing it has all of your changes in it), and it works!
I see a bunch of patches marked for the stable branch, so I'll try those out and see if they fix the problem. If not, I'll let you and Ben know.
thanks,
greg k-h
On Mon, Feb 25, 2013 at 07:45:45PM -0800, Greg KH wrote:
On Mon, Feb 25, 2013 at 02:32:43PM -0800, Greg KH wrote:
On Mon, Feb 25, 2013 at 04:06:02PM +1000, Dave Airlie wrote:
On Mon, Feb 25, 2013 at 3:52 PM, Greg KH gregkh@linuxfoundation.org wrote:
Hi Ben,
My Macbook Pro Retina fails to resume properly on 3.8. I tracked this down to commit 6c5a04249d7afeea3e0ed971e7813f84e29a1706 (drm/nvd0/disp: move link training helpers into core as display methods)
Anything I can try to help solve this?
Note, I'm using the Intel driver as the main controller for this laptop, well, I think I am, my xorg log is attached.
No you are using the nvidia, the efi always boots nvidia enabled now.
Really? When did that change? I thought I wanted to be using the Intel chip to save battery life.
btw I just tested my drm-next tree on mine and it resumed the display fine, something oopsed a few seconds later that I haven't tracked down
git://git.freedesktop.org/~airlied/linux drm-next
I'll be sending it to Linus this evening or tomorrow morning, once I fix my tree.
Ok, I'll test again when it hits Linus's tree, and if that works, it would be good to try to work out what patch fixes it to get them into the 3.8-stable series so that others don't run into the same problem.
I've tested Linus's tree now (I'm guessing it has all of your changes in it), and it works!
I see a bunch of patches marked for the stable branch, so I'll try those out and see if they fix the problem. If not, I'll let you and Ben know.
I've applied the radeon patches tagged for -stable and tested that on 3.8.0, but that doesn't solve the resume problem. Any ideas of anything else I can do to test this? Doing a "backwards" git-bisect is a pain, but I guess I can do that to try to track down what patch fixed this, if that's the only idea people have...
thanks,
greg k-h
On 26 February 2013 17:35, Greg KH gregkh@linuxfoundation.org wrote:
On Mon, Feb 25, 2013 at 07:45:45PM -0800, Greg KH wrote:
On Mon, Feb 25, 2013 at 02:32:43PM -0800, Greg KH wrote:
On Mon, Feb 25, 2013 at 04:06:02PM +1000, Dave Airlie wrote:
On Mon, Feb 25, 2013 at 3:52 PM, Greg KH gregkh@linuxfoundation.org wrote:
Hi Ben,
My Macbook Pro Retina fails to resume properly on 3.8. I tracked this down to commit 6c5a04249d7afeea3e0ed971e7813f84e29a1706 (drm/nvd0/disp: move link training helpers into core as display methods)
Anything I can try to help solve this?
Note, I'm using the Intel driver as the main controller for this laptop, well, I think I am, my xorg log is attached.
No you are using the nvidia, the efi always boots nvidia enabled now.
Really? When did that change? I thought I wanted to be using the Intel chip to save battery life.
btw I just tested my drm-next tree on mine and it resumed the display fine, something oopsed a few seconds later that I haven't tracked down
git://git.freedesktop.org/~airlied/linux drm-next
I'll be sending it to Linus this evening or tomorrow morning, once I fix my tree.
Ok, I'll test again when it hits Linus's tree, and if that works, it would be good to try to work out what patch fixes it to get them into the 3.8-stable series so that others don't run into the same problem.
I've tested Linus's tree now (I'm guessing it has all of your changes in it), and it works!
I see a bunch of patches marked for the stable branch, so I'll try those out and see if they fix the problem. If not, I'll let you and Ben know.
I've applied the radeon patches tagged for -stable and tested that on 3.8.0, but that doesn't solve the resume problem. Any ideas of anything else I can do to test this? Doing a "backwards" git-bisect is a pain, but I guess I can do that to try to track down what patch fixed this, if that's the only idea people have...
If it helps, I have a similar resume problem here. 3.7.8 good 3.8.0 bad
Laptop with no nvidia, no amd graphics, just Intel Graphics 4000, 3rd Gen I5 CPU.
On Tue, Feb 26, 2013 at 06:11:31PM +0000, James Courtier-Dutton wrote:
On 26 February 2013 17:35, Greg KH gregkh@linuxfoundation.org wrote:
On Mon, Feb 25, 2013 at 07:45:45PM -0800, Greg KH wrote:
On Mon, Feb 25, 2013 at 02:32:43PM -0800, Greg KH wrote:
On Mon, Feb 25, 2013 at 04:06:02PM +1000, Dave Airlie wrote:
On Mon, Feb 25, 2013 at 3:52 PM, Greg KH gregkh@linuxfoundation.org wrote:
Hi Ben,
My Macbook Pro Retina fails to resume properly on 3.8. I tracked this down to commit 6c5a04249d7afeea3e0ed971e7813f84e29a1706 (drm/nvd0/disp: move link training helpers into core as display methods)
Anything I can try to help solve this?
Note, I'm using the Intel driver as the main controller for this laptop, well, I think I am, my xorg log is attached.
No you are using the nvidia, the efi always boots nvidia enabled now.
Really? When did that change? I thought I wanted to be using the Intel chip to save battery life.
btw I just tested my drm-next tree on mine and it resumed the display fine, something oopsed a few seconds later that I haven't tracked down
git://git.freedesktop.org/~airlied/linux drm-next
I'll be sending it to Linus this evening or tomorrow morning, once I fix my tree.
Ok, I'll test again when it hits Linus's tree, and if that works, it would be good to try to work out what patch fixes it to get them into the 3.8-stable series so that others don't run into the same problem.
I've tested Linus's tree now (I'm guessing it has all of your changes in it), and it works!
I see a bunch of patches marked for the stable branch, so I'll try those out and see if they fix the problem. If not, I'll let you and Ben know.
I've applied the radeon patches tagged for -stable and tested that on 3.8.0, but that doesn't solve the resume problem. Any ideas of anything else I can do to test this? Doing a "backwards" git-bisect is a pain, but I guess I can do that to try to track down what patch fixed this, if that's the only idea people have...
If it helps, I have a similar resume problem here. 3.7.8 good 3.8.0 bad
Laptop with no nvidia, no amd graphics, just Intel Graphics 4000, 3rd Gen I5 CPU.
But, I'm guessing that if you revert commit 6c5a04249d7afeea3e0ed971e7813f84e29a1706, it doesn't solve your problem, right?
Can you use 'git bisect' to try to track down the offending commit?
thanks,
greg k-h
On 26 February 2013 18:11, James Courtier-Dutton james.dutton@gmail.com wrote:
On 26 February 2013 17:35, Greg KH gregkh@linuxfoundation.org wrote:
On Mon, Feb 25, 2013 at 07:45:45PM -0800, Greg KH wrote:
On Mon, Feb 25, 2013 at 02:32:43PM -0800, Greg KH wrote:
On Mon, Feb 25, 2013 at 04:06:02PM +1000, Dave Airlie wrote:
On Mon, Feb 25, 2013 at 3:52 PM, Greg KH gregkh@linuxfoundation.org wrote:
Hi Ben,
My Macbook Pro Retina fails to resume properly on 3.8. I tracked this down to commit 6c5a04249d7afeea3e0ed971e7813f84e29a1706 (drm/nvd0/disp: move link training helpers into core as display methods)
Anything I can try to help solve this?
Note, I'm using the Intel driver as the main controller for this laptop, well, I think I am, my xorg log is attached.
No you are using the nvidia, the efi always boots nvidia enabled now.
Really? When did that change? I thought I wanted to be using the Intel chip to save battery life.
btw I just tested my drm-next tree on mine and it resumed the display fine, something oopsed a few seconds later that I haven't tracked down
git://git.freedesktop.org/~airlied/linux drm-next
I'll be sending it to Linus this evening or tomorrow morning, once I fix my tree.
Ok, I'll test again when it hits Linus's tree, and if that works, it would be good to try to work out what patch fixes it to get them into the 3.8-stable series so that others don't run into the same problem.
I've tested Linus's tree now (I'm guessing it has all of your changes in it), and it works!
I see a bunch of patches marked for the stable branch, so I'll try those out and see if they fix the problem. If not, I'll let you and Ben know.
I've applied the radeon patches tagged for -stable and tested that on 3.8.0, but that doesn't solve the resume problem. Any ideas of anything else I can do to test this? Doing a "backwards" git-bisect is a pain, but I guess I can do that to try to track down what patch fixed this, if that's the only idea people have...
If it helps, I have a similar resume problem here. 3.7.8 good 3.8.0 bad
Laptop with no nvidia, no amd graphics, just Intel Graphics 4000, 3rd Gen I5 CPU.
Problem: "Backlight not coming on after resume." git finally bisected for my Samsung Serial 7 Laptop. Bisecting: 0 revisions left to test after this (roughly 0 steps) [cf0a6584aa6d382f802f2c3cacac23ccbccde0cd] drm/i915: write backlight harder <- This is the problem commit. Seems that fixing some machines breaks others, based on the existing comments on that patch.
git bisect log git bisect start # bad: [09884964335e85e897876d17783c2ad33cf8a2e0] mm: do not grow the stack vma just because of an overrun on preceding vma git bisect bad 09884964335e85e897876d17783c2ad33cf8a2e0 # good: [6c5096e5538b455bc3bea2b02588c380f070d8c6] Merge tag 'boards' of git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc git bisect good 6c5096e5538b455bc3bea2b02588c380f070d8c6 # good: [21fbd5809ad126b949206d78e0a0e07ec872ea11] Merge branch 'v4l_for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media git bisect good 21fbd5809ad126b949206d78e0a0e07ec872ea11 # bad: [fffddfd6c8e0c10c42c6e2cc54ba880fcc36ebbb] Merge branch 'drm-next' of git://people.freedesktop.org/~airlied/linux git bisect bad fffddfd6c8e0c10c42c6e2cc54ba880fcc36ebbb # bad: [b81e059ec5a7128622ab5d74d78e9b4f361b54ae] Merge branch 'drm-intel-fixes' of git://people.freedesktop.org/~danvet/drm-intel into drm-next git bisect bad b81e059ec5a7128622ab5d74d78e9b4f361b54ae # good: [d6dd9eb1d96d2b7345fe4664066c2b7ed86da898] drm/i915: dynamic Haswell display power well support git bisect good d6dd9eb1d96d2b7345fe4664066c2b7ed86da898 # good: [73ccd6962fff19e53a7d4baaa17cf9311284ac9c] Merge branch 'drm-next-3.9' of git://people.freedesktop.org/~agd5f/linux into drm-next git bisect good 73ccd6962fff19e53a7d4baaa17cf9311284ac9c # good: [a4462f246c8821f625f45bce52c7ca7e0207dffe] staging/omapdrm: Use kmemdup rather than duplicating its implementation git bisect good a4462f246c8821f625f45bce52c7ca7e0207dffe # bad: [d84f031bd230fdf9c3b7734940c859bf28b90219] drm: Use C8 instead of RGB332 when determining the format from depth/bpp git bisect bad d84f031bd230fdf9c3b7734940c859bf28b90219 # bad: [f73f760725636b9d0c3786273e185b053516d1eb] drm/i915/ctx: Remove bad invariant git bisect bad f73f760725636b9d0c3786273e185b053516d1eb # bad: [26739f12cf210cb8df35969258a1f064e8e12b63] drm/i915: unify HDMI/DP hpd definitions git bisect bad 26739f12cf210cb8df35969258a1f064e8e12b63 # good: [b8efb17b3d687695b81485f606fc4e6c35a50f9a] i915: ignore lid open event when resuming git bisect good b8efb17b3d687695b81485f606fc4e6c35a50f9a # bad: [07ea0d85ac8adb87b817913d9720e3c76171b1f6] drm/i915: Clarify HW context size logic git bisect bad 07ea0d85ac8adb87b817913d9720e3c76171b1f6
On Wed, Feb 27, 2013 at 11:27:30PM +0000, James Courtier-Dutton wrote:
On 26 February 2013 18:11, James Courtier-Dutton james.dutton@gmail.com wrote:
On 26 February 2013 17:35, Greg KH gregkh@linuxfoundation.org wrote:
On Mon, Feb 25, 2013 at 07:45:45PM -0800, Greg KH wrote:
On Mon, Feb 25, 2013 at 02:32:43PM -0800, Greg KH wrote:
On Mon, Feb 25, 2013 at 04:06:02PM +1000, Dave Airlie wrote:
On Mon, Feb 25, 2013 at 3:52 PM, Greg KH gregkh@linuxfoundation.org wrote: > Hi Ben, > > My Macbook Pro Retina fails to resume properly on 3.8. I tracked this > down to commit 6c5a04249d7afeea3e0ed971e7813f84e29a1706 (drm/nvd0/disp: > move link training helpers into core as display methods) > > Anything I can try to help solve this? > > Note, I'm using the Intel driver as the main controller for this laptop, > well, I think I am, my xorg log is attached.
No you are using the nvidia, the efi always boots nvidia enabled now.
Really? When did that change? I thought I wanted to be using the Intel chip to save battery life.
btw I just tested my drm-next tree on mine and it resumed the display fine, something oopsed a few seconds later that I haven't tracked down
git://git.freedesktop.org/~airlied/linux drm-next
I'll be sending it to Linus this evening or tomorrow morning, once I fix my tree.
Ok, I'll test again when it hits Linus's tree, and if that works, it would be good to try to work out what patch fixes it to get them into the 3.8-stable series so that others don't run into the same problem.
I've tested Linus's tree now (I'm guessing it has all of your changes in it), and it works!
I see a bunch of patches marked for the stable branch, so I'll try those out and see if they fix the problem. If not, I'll let you and Ben know.
I've applied the radeon patches tagged for -stable and tested that on 3.8.0, but that doesn't solve the resume problem. Any ideas of anything else I can do to test this? Doing a "backwards" git-bisect is a pain, but I guess I can do that to try to track down what patch fixed this, if that's the only idea people have...
If it helps, I have a similar resume problem here. 3.7.8 good 3.8.0 bad
Laptop with no nvidia, no amd graphics, just Intel Graphics 4000, 3rd Gen I5 CPU.
Problem: "Backlight not coming on after resume." git finally bisected for my Samsung Serial 7 Laptop. Bisecting: 0 revisions left to test after this (roughly 0 steps) [cf0a6584aa6d382f802f2c3cacac23ccbccde0cd] drm/i915: write backlight harder <- This is the problem commit. Seems that fixing some machines breaks others, based on the existing comments on that patch.
Hm, so, 3.8.0 works for you, but 3.8.1-rc1 doesn't? Or are you saying Linus's tree doesn't work for you?
As you have a different issue here than the nvidia hardware I was dealing with, you might want to try to start over with a new thread and the needed info, and the needed people on it (i.e. the i915 maintainers and mailing list.)
thanks,
greg k-h
On 28 February 2013 00:02, Greg KH gregkh@linuxfoundation.org wrote:
On Wed, Feb 27, 2013 at 11:27:30PM +0000, James Courtier-Dutton wrote:
On 26 February 2013 18:11, James Courtier-Dutton james.dutton@gmail.com wrote:
On 26 February 2013 17:35, Greg KH gregkh@linuxfoundation.org wrote:
On Mon, Feb 25, 2013 at 07:45:45PM -0800, Greg KH wrote:
On Mon, Feb 25, 2013 at 02:32:43PM -0800, Greg KH wrote:
On Mon, Feb 25, 2013 at 04:06:02PM +1000, Dave Airlie wrote: > On Mon, Feb 25, 2013 at 3:52 PM, Greg KH gregkh@linuxfoundation.org wrote: > > Hi Ben, > > > > My Macbook Pro Retina fails to resume properly on 3.8. I tracked this > > down to commit 6c5a04249d7afeea3e0ed971e7813f84e29a1706 (drm/nvd0/disp: > > move link training helpers into core as display methods) > > > > Anything I can try to help solve this? > > > > Note, I'm using the Intel driver as the main controller for this laptop, > > well, I think I am, my xorg log is attached. > > No you are using the nvidia, the efi always boots nvidia enabled now.
Really? When did that change? I thought I wanted to be using the Intel chip to save battery life.
> btw I just tested my drm-next tree on mine and it resumed the display > fine, something oopsed a few seconds later that I haven't tracked down > > git://git.freedesktop.org/~airlied/linux drm-next > > I'll be sending it to Linus this evening or tomorrow morning, once I > fix my tree.
Ok, I'll test again when it hits Linus's tree, and if that works, it would be good to try to work out what patch fixes it to get them into the 3.8-stable series so that others don't run into the same problem.
I've tested Linus's tree now (I'm guessing it has all of your changes in it), and it works!
I see a bunch of patches marked for the stable branch, so I'll try those out and see if they fix the problem. If not, I'll let you and Ben know.
I've applied the radeon patches tagged for -stable and tested that on 3.8.0, but that doesn't solve the resume problem. Any ideas of anything else I can do to test this? Doing a "backwards" git-bisect is a pain, but I guess I can do that to try to track down what patch fixed this, if that's the only idea people have...
If it helps, I have a similar resume problem here. 3.7.8 good 3.8.0 bad
Laptop with no nvidia, no amd graphics, just Intel Graphics 4000, 3rd Gen I5 CPU.
Problem: "Backlight not coming on after resume." git finally bisected for my Samsung Serial 7 Laptop. Bisecting: 0 revisions left to test after this (roughly 0 steps) [cf0a6584aa6d382f802f2c3cacac23ccbccde0cd] drm/i915: write backlight harder <- This is the problem commit. Seems that fixing some machines breaks others, based on the existing comments on that patch.
Hm, so, 3.8.0 works for you, but 3.8.1-rc1 doesn't? Or are you saying Linus's tree doesn't work for you?
As you have a different issue here than the nvidia hardware I was dealing with, you might want to try to start over with a new thread and the needed info, and the needed people on it (i.e. the i915 maintainers and mailing list.)
I little confusing sorry. I started using: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git For that 3.7.8 worked fine, 3.8 failed to restore X, but the backlight lights.
I then moved to linus tree at: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git On Linus tree the problem commit is: [cf0a6584aa6d382f802f2c3cacac23ccbccde0cd] drm/i915: write backlight harder The problem on the Linux tree is different from the stable tree. Linus tree: Backlight fails to light up after resume. linux-stable tree: Failed to restore X, but the backlight lights.
So, I think the linus tree fixes the "failed to restore X" bit, but introduced a new regression for the backlight. I don't know which patch from the Linus tree would fix the stable 3.8 tree.
I will send an email to the i915 maintainers tomorrow.
On Tue, Feb 26, 2013 at 09:35:14AM -0800, Greg KH wrote:
On Mon, Feb 25, 2013 at 07:45:45PM -0800, Greg KH wrote:
On Mon, Feb 25, 2013 at 02:32:43PM -0800, Greg KH wrote:
On Mon, Feb 25, 2013 at 04:06:02PM +1000, Dave Airlie wrote:
On Mon, Feb 25, 2013 at 3:52 PM, Greg KH gregkh@linuxfoundation.org wrote:
Hi Ben,
My Macbook Pro Retina fails to resume properly on 3.8. I tracked this down to commit 6c5a04249d7afeea3e0ed971e7813f84e29a1706 (drm/nvd0/disp: move link training helpers into core as display methods)
Anything I can try to help solve this?
Note, I'm using the Intel driver as the main controller for this laptop, well, I think I am, my xorg log is attached.
No you are using the nvidia, the efi always boots nvidia enabled now.
Really? When did that change? I thought I wanted to be using the Intel chip to save battery life.
btw I just tested my drm-next tree on mine and it resumed the display fine, something oopsed a few seconds later that I haven't tracked down
git://git.freedesktop.org/~airlied/linux drm-next
I'll be sending it to Linus this evening or tomorrow morning, once I fix my tree.
Ok, I'll test again when it hits Linus's tree, and if that works, it would be good to try to work out what patch fixes it to get them into the 3.8-stable series so that others don't run into the same problem.
I've tested Linus's tree now (I'm guessing it has all of your changes in it), and it works!
I see a bunch of patches marked for the stable branch, so I'll try those out and see if they fix the problem. If not, I'll let you and Ben know.
I've applied the radeon patches tagged for -stable and tested that on 3.8.0, but that doesn't solve the resume problem. Any ideas of anything else I can do to test this? Doing a "backwards" git-bisect is a pain, but I guess I can do that to try to track down what patch fixed this, if that's the only idea people have...
Ok, after getting my brain warped by doing a reverse 'git bisect', I tracked it down to commit ac8cc241a81941932da44993242e68c62e115ec7 (drm/nv50/devinit: reverse the logic for running encoder init scripts) as the patch that solves the problem.
So, I tried applying that patch on 3.8.1-rc1, but ran into the efifb bug that Dave fixed already, which took me a while, so I've queued that up for 3.8.1. Then I determined that it really also needs commit f3ed1048715f2edc10c4dda6148b60e93f6282ed (drm/nouveau/bios: parse external transmitter type if off-chip) and commit 8e992c8d9eebc2bd3246252ee5c0422dbbbce7ae (drm/nouveau/bios: store a type/mask hash in parsed dcb data) in order to build properly.
With those three patches, plus the efifb fix, I can now properly boot, and suspend and resume my macbook on 3.8.1-rc1. Just like I can on Linus's tree.
So, Ben, Dave, any objection to me including these 3 nouveau patches in the 3.8.1-final release?
thanks,
greg k-h
On Tue, 2013-02-26 at 20:02 -0800, Greg KH wrote:
On Tue, Feb 26, 2013 at 09:35:14AM -0800, Greg KH wrote:
On Mon, Feb 25, 2013 at 07:45:45PM -0800, Greg KH wrote:
On Mon, Feb 25, 2013 at 02:32:43PM -0800, Greg KH wrote:
On Mon, Feb 25, 2013 at 04:06:02PM +1000, Dave Airlie wrote:
On Mon, Feb 25, 2013 at 3:52 PM, Greg KH gregkh@linuxfoundation.org wrote:
Hi Ben,
My Macbook Pro Retina fails to resume properly on 3.8. I tracked this down to commit 6c5a04249d7afeea3e0ed971e7813f84e29a1706 (drm/nvd0/disp: move link training helpers into core as display methods)
Anything I can try to help solve this?
Note, I'm using the Intel driver as the main controller for this laptop, well, I think I am, my xorg log is attached.
No you are using the nvidia, the efi always boots nvidia enabled now.
Really? When did that change? I thought I wanted to be using the Intel chip to save battery life.
btw I just tested my drm-next tree on mine and it resumed the display fine, something oopsed a few seconds later that I haven't tracked down
git://git.freedesktop.org/~airlied/linux drm-next
I'll be sending it to Linus this evening or tomorrow morning, once I fix my tree.
Ok, I'll test again when it hits Linus's tree, and if that works, it would be good to try to work out what patch fixes it to get them into the 3.8-stable series so that others don't run into the same problem.
I've tested Linus's tree now (I'm guessing it has all of your changes in it), and it works!
I see a bunch of patches marked for the stable branch, so I'll try those out and see if they fix the problem. If not, I'll let you and Ben know.
I've applied the radeon patches tagged for -stable and tested that on 3.8.0, but that doesn't solve the resume problem. Any ideas of anything else I can do to test this? Doing a "backwards" git-bisect is a pain, but I guess I can do that to try to track down what patch fixed this, if that's the only idea people have...
Ok, after getting my brain warped by doing a reverse 'git bisect', I tracked it down to commit ac8cc241a81941932da44993242e68c62e115ec7 (drm/nv50/devinit: reverse the logic for running encoder init scripts) as the patch that solves the problem.
So, I tried applying that patch on 3.8.1-rc1, but ran into the efifb bug that Dave fixed already, which took me a while, so I've queued that up for 3.8.1. Then I determined that it really also needs commit f3ed1048715f2edc10c4dda6148b60e93f6282ed (drm/nouveau/bios: parse external transmitter type if off-chip) and commit 8e992c8d9eebc2bd3246252ee5c0422dbbbce7ae (drm/nouveau/bios: store a type/mask hash in parsed dcb data) in order to build properly.
With those three patches, plus the efifb fix, I can now properly boot, and suspend and resume my macbook on 3.8.1-rc1. Just like I can on Linus's tree.
So, Ben, Dave, any objection to me including these 3 nouveau patches in the 3.8.1-final release?
Thanks for taking the time to track down exactly what's needed here. I believe those three should be safe to apply.
Ben.
thanks,
greg k-h
On Wed, Feb 27, 2013 at 07:25:35PM +1000, Ben Skeggs wrote:
On Tue, 2013-02-26 at 20:02 -0800, Greg KH wrote:
On Tue, Feb 26, 2013 at 09:35:14AM -0800, Greg KH wrote:
On Mon, Feb 25, 2013 at 07:45:45PM -0800, Greg KH wrote:
On Mon, Feb 25, 2013 at 02:32:43PM -0800, Greg KH wrote:
On Mon, Feb 25, 2013 at 04:06:02PM +1000, Dave Airlie wrote:
On Mon, Feb 25, 2013 at 3:52 PM, Greg KH gregkh@linuxfoundation.org wrote: > Hi Ben, > > My Macbook Pro Retina fails to resume properly on 3.8. I tracked this > down to commit 6c5a04249d7afeea3e0ed971e7813f84e29a1706 (drm/nvd0/disp: > move link training helpers into core as display methods) > > Anything I can try to help solve this? > > Note, I'm using the Intel driver as the main controller for this laptop, > well, I think I am, my xorg log is attached.
No you are using the nvidia, the efi always boots nvidia enabled now.
Really? When did that change? I thought I wanted to be using the Intel chip to save battery life.
btw I just tested my drm-next tree on mine and it resumed the display fine, something oopsed a few seconds later that I haven't tracked down
git://git.freedesktop.org/~airlied/linux drm-next
I'll be sending it to Linus this evening or tomorrow morning, once I fix my tree.
Ok, I'll test again when it hits Linus's tree, and if that works, it would be good to try to work out what patch fixes it to get them into the 3.8-stable series so that others don't run into the same problem.
I've tested Linus's tree now (I'm guessing it has all of your changes in it), and it works!
I see a bunch of patches marked for the stable branch, so I'll try those out and see if they fix the problem. If not, I'll let you and Ben know.
I've applied the radeon patches tagged for -stable and tested that on 3.8.0, but that doesn't solve the resume problem. Any ideas of anything else I can do to test this? Doing a "backwards" git-bisect is a pain, but I guess I can do that to try to track down what patch fixed this, if that's the only idea people have...
Ok, after getting my brain warped by doing a reverse 'git bisect', I tracked it down to commit ac8cc241a81941932da44993242e68c62e115ec7 (drm/nv50/devinit: reverse the logic for running encoder init scripts) as the patch that solves the problem.
So, I tried applying that patch on 3.8.1-rc1, but ran into the efifb bug that Dave fixed already, which took me a while, so I've queued that up for 3.8.1. Then I determined that it really also needs commit f3ed1048715f2edc10c4dda6148b60e93f6282ed (drm/nouveau/bios: parse external transmitter type if off-chip) and commit 8e992c8d9eebc2bd3246252ee5c0422dbbbce7ae (drm/nouveau/bios: store a type/mask hash in parsed dcb data) in order to build properly.
With those three patches, plus the efifb fix, I can now properly boot, and suspend and resume my macbook on 3.8.1-rc1. Just like I can on Linus's tree.
So, Ben, Dave, any objection to me including these 3 nouveau patches in the 3.8.1-final release?
Thanks for taking the time to track down exactly what's needed here. I believe those three should be safe to apply.
Ok, thanks for verifying, I've now applied all 3 of them.
greg k-h
dri-devel@lists.freedesktop.org
-
Ben Skeggs -
Dave Airlie -
Greg KH -
James Courtier-Dutton