In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
Signed-off-by: Gustavo A. R. Silva gustavo@embeddedor.com --- drivers/video/backlight/adp8860_bl.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/video/backlight/adp8860_bl.c b/drivers/video/backlight/adp8860_bl.c index 16119bd..f1dc41c 100644 --- a/drivers/video/backlight/adp8860_bl.c +++ b/drivers/video/backlight/adp8860_bl.c @@ -690,6 +690,7 @@ static int adp8860_probe(struct i2c_client *client, switch (ADP8860_MANID(reg_val)) { case ADP8863_MANUFID: data->gdwn_dis = !!pdata->gdwn_dis; + /* fall through */ case ADP8860_MANUFID: data->en_ambl_sens = !!pdata->en_ambl_sens; break;
On Mon, 09 Jul 2018, Gustavo A. R. Silva wrote:
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
Signed-off-by: Gustavo A. R. Silva gustavo@embeddedor.com
drivers/video/backlight/adp8860_bl.c | 1 + 1 file changed, 1 insertion(+)
Looks good to me, but Dan should still review.
https://gcc.gnu.org/onlinedocs/gcc-8.1.0/gcc.pdf#page=86
Acked-by: Lee Jones lee.jones@linaro.org
On 09.07.2018 23:51, Gustavo A. R. Silva wrote:
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
Signed-off-by: Gustavo A. R. Silva gustavo@embeddedor.com
Acked-by: Michael Hennerich michael.hennerich@analog.com
drivers/video/backlight/adp8860_bl.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/video/backlight/adp8860_bl.c b/drivers/video/backlight/adp8860_bl.c index 16119bd..f1dc41c 100644 --- a/drivers/video/backlight/adp8860_bl.c +++ b/drivers/video/backlight/adp8860_bl.c @@ -690,6 +690,7 @@ static int adp8860_probe(struct i2c_client *client, switch (ADP8860_MANID(reg_val)) { case ADP8863_MANUFID: data->gdwn_dis = !!pdata->gdwn_dis;
/* fall through */
On Mon, Jul 09, 2018 at 04:51:56PM -0500, Gustavo A. R. Silva wrote:
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
Signed-off-by: Gustavo A. R. Silva gustavo@embeddedor.com
Having checked the datasheets...
Reviewed-by: Daniel Thompson daniel.thompson@linaro.org
drivers/video/backlight/adp8860_bl.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/video/backlight/adp8860_bl.c b/drivers/video/backlight/adp8860_bl.c index 16119bd..f1dc41c 100644 --- a/drivers/video/backlight/adp8860_bl.c +++ b/drivers/video/backlight/adp8860_bl.c @@ -690,6 +690,7 @@ static int adp8860_probe(struct i2c_client *client, switch (ADP8860_MANID(reg_val)) { case ADP8863_MANUFID: data->gdwn_dis = !!pdata->gdwn_dis;
/* fall through */-- 2.7.4
On Mon, 09 Jul 2018, Gustavo A. R. Silva wrote:
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
Signed-off-by: Gustavo A. R. Silva gustavo@embeddedor.com
drivers/video/backlight/adp8860_bl.c | 1 + 1 file changed, 1 insertion(+)
Applied, thanks.
dri-devel@lists.freedesktop.org
-
Daniel Thompson -
Gustavo A. R. Silva -
Lee Jones -
Michael Hennerich