This addresses the following gcc warning with "make W=1":
drivers/gpu/drm/v3d/v3d_drv.c:73:32: warning: ‘v3d_v3d_pm_ops’ defined but not used [-Wunused-const-variable=]
Reported-by: Hulk Robot hulkci@huawei.com Signed-off-by: Li Heng liheng40@huawei.com --- drivers/gpu/drm/v3d/v3d_drv.c | 4 ---- 1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/v3d/v3d_drv.c b/drivers/gpu/drm/v3d/v3d_drv.c index 9f7c261..05140db 100644 --- a/drivers/gpu/drm/v3d/v3d_drv.c +++ b/drivers/gpu/drm/v3d/v3d_drv.c @@ -70,10 +70,6 @@ static int v3d_runtime_resume(struct device *dev) } #endif
-static const struct dev_pm_ops v3d_v3d_pm_ops = { - SET_RUNTIME_PM_OPS(v3d_runtime_suspend, v3d_runtime_resume, NULL) -}; - static int v3d_get_param_ioctl(struct drm_device *dev, void *data, struct drm_file *file_priv) { -- 2.7.4
Hi
On Wed, 23 Sep 2020 at 08:53, Li Heng liheng40@huawei.com wrote:
This addresses the following gcc warning with "make W=1":
drivers/gpu/drm/v3d/v3d_drv.c:73:32: warning: ‘v3d_v3d_pm_ops’ defined but not used [-Wunused-const-variable=]
Reported-by: Hulk Robot hulkci@huawei.com Signed-off-by: Li Heng liheng40@huawei.com
drivers/gpu/drm/v3d/v3d_drv.c | 4 ---- 1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/v3d/v3d_drv.c b/drivers/gpu/drm/v3d/v3d_drv.c index 9f7c261..05140db 100644 --- a/drivers/gpu/drm/v3d/v3d_drv.c +++ b/drivers/gpu/drm/v3d/v3d_drv.c @@ -70,10 +70,6 @@ static int v3d_runtime_resume(struct device *dev) } #endif
-static const struct dev_pm_ops v3d_v3d_pm_ops = {
SET_RUNTIME_PM_OPS(v3d_runtime_suspend, v3d_runtime_resume, NULL)-};
This looks to be the wrong approach, and I think a patch has got dropped somewhere.
On our Raspberry Pi downstream vendor tree we have a patch [1] from Eric that renames v3d_v3d_pm_ops to v3d_pm_ops (don't need the duplicated suffix), and adds it to v3d_platform_driver. Why that never made it through the mainline trees I don't know.
Eric: How good's your memory on this one?
Thanks Dave
[1] https://github.com/raspberrypi/linux/commit/fddfb26f6503835a3c6f7ca0175ce226...
static int v3d_get_param_ioctl(struct drm_device *dev, void *data, struct drm_file *file_priv) { -- 2.7.4
dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Wed, Sep 23, 2020 at 6:13 AM Dave Stevenson dave.stevenson@raspberrypi.com wrote:
Hi
On Wed, 23 Sep 2020 at 08:53, Li Heng liheng40@huawei.com wrote:
This addresses the following gcc warning with "make W=1":
drivers/gpu/drm/v3d/v3d_drv.c:73:32: warning: ‘v3d_v3d_pm_ops’ defined but not used [-Wunused-const-variable=]
Reported-by: Hulk Robot hulkci@huawei.com Signed-off-by: Li Heng liheng40@huawei.com
drivers/gpu/drm/v3d/v3d_drv.c | 4 ---- 1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/v3d/v3d_drv.c b/drivers/gpu/drm/v3d/v3d_drv.c index 9f7c261..05140db 100644 --- a/drivers/gpu/drm/v3d/v3d_drv.c +++ b/drivers/gpu/drm/v3d/v3d_drv.c @@ -70,10 +70,6 @@ static int v3d_runtime_resume(struct device *dev) } #endif
-static const struct dev_pm_ops v3d_v3d_pm_ops = {
SET_RUNTIME_PM_OPS(v3d_runtime_suspend, v3d_runtime_resume, NULL)-};
This looks to be the wrong approach, and I think a patch has got dropped somewhere.
On our Raspberry Pi downstream vendor tree we have a patch [1] from Eric that renames v3d_v3d_pm_ops to v3d_pm_ops (don't need the duplicated suffix), and adds it to v3d_platform_driver. Why that never made it through the mainline trees I don't know.
Eric: How good's your memory on this one?
The RPM stuff ended up abandoned because I didn't have any support in debugging the power domain driver and I punted for a downstream hack. We should at least be using these ops, though.
dri-devel@lists.freedesktop.org
-
Dave Stevenson -
Eric Anholt -
Li Heng