[Bug 92082] Build on Solaris: xf86drm.c:3021: error: 'PATH_MAX' undeclared (first use in this function)
https://bugs.freedesktop.org/show_bug.cgi?id=92082
Bug ID: 92082 Summary: Build on Solaris: xf86drm.c:3021: error: 'PATH_MAX' undeclared (first use in this function) Product: DRI Version: DRI git Hardware: x86-64 (AMD64) OS: Solaris Status: NEW Severity: normal Priority: medium Component: libdrm Assignee: dri-devel@lists.freedesktop.org Reporter: evgeny.v.litvinenko@gmail.com
commit 291b2bb92c5fc90101417b80bbdc6c994be5fff2 (xf86drm: move ifdef __linux__ guards where needed) introduces the following error when build on illumos (OpenIndiana):
xf86drm.c: In function 'drmGetDevices': xf86drm.c:3021: error: 'PATH_MAX' undeclared (first use in this function) xf86drm.c:3021: error: (Each undeclared identifier is reported only once xf86drm.c:3021: error: for each function it appears in.)
OpenIndiana has the line #define PATH_MAX 1024 /* max # of characters in a path name */ in /usr/include/limits.h
May be xf86drm.c should #include limits.h?
https://bugs.freedesktop.org/show_bug.cgi?id=92082
--- Comment #1 from Emil Velikov emil.l.velikov@gmail.com --- Hi Evgeny,
Including limits.h does seem like the right way forward. Can you send a git format-patch created fix to the ML [1]?
Additionally you should have noticed a bunch of warnings (missing implementation of XXX) on non-linux platforms. If you'd like to solve these but you're unsure what exactly the functions are supposed to do, let me know and I can help out. You can also catch me at #dri-devel (freenode), look for xexaxo.
Thanks
[1] http://lists.freedesktop.org/mailman/listinfo/dri-devel
https://bugs.freedesktop.org/show_bug.cgi?id=92082
--- Comment #2 from Bernd Kuhls berndkuhls@hotmail.com --- Using a musl toolchain this bug triggers as well and is fixed by http://lists.freedesktop.org/archives/dri-devel/2015-September/091104.html
https://bugs.freedesktop.org/show_bug.cgi?id=92082
Emil Velikov emil.l.velikov@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED
--- Comment #3 from Emil Velikov emil.l.velikov@gmail.com --- Should be fixed in master. Thanks for the report.
dri-devel@lists.freedesktop.org
-
bugzilla-daemon＠freedesktop.org