This patch implements support for United Radiant Technology UMSH-8596MD-xT 7.0" WVGA TFT LCD panels in DRM panel-simple driver.
Signed-off-by: Maciej Szmigiero mail@maciej.szmigiero.name --- This replaces "drm: panel-simple: add URT UMSH-8596MD-xT panel support" submission.
drivers/gpu/drm/panel/panel-simple.c | 54 ++++++++++++++++++++++++++++++++++++ 1 file changed, 54 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index f97b73e..44d0deb9 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -1096,6 +1096,42 @@ static const struct panel_desc shelly_sca07010_bfn_lnn = { .bus_format = MEDIA_BUS_FMT_RGB666_1X18, };
+static const struct display_timing urt_umsh_8596md_timing = { + .pixelclock = { 33260000, 33260000, 33260000 }, + .hactive = { 800, 800, 800 }, + .hfront_porch = { 41, 41, 41 }, + .hback_porch = { 216 - 128, 216 - 128, 216 - 128 }, + .hsync_len = { 71, 128, 128 }, + .vactive = { 480, 480, 480 }, + .vfront_porch = { 10, 10, 10 }, + .vback_porch = { 35 - 2, 35 - 2, 35 - 2 }, + .vsync_len = { 2, 2, 2 }, + .flags = DISPLAY_FLAGS_DE_HIGH | DISPLAY_FLAGS_PIXDATA_NEGEDGE | + DISPLAY_FLAGS_HSYNC_LOW | DISPLAY_FLAGS_VSYNC_LOW, +}; + +static const struct panel_desc urt_umsh_8596md_lvds = { + .timings = &urt_umsh_8596md_timing, + .num_timings = 1, + .bpc = 6, + .size = { + .width = 152, + .height = 91, + }, + .bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG, +}; + +static const struct panel_desc urt_umsh_8596md_parallel = { + .timings = &urt_umsh_8596md_timing, + .num_timings = 1, + .bpc = 6, + .size = { + .width = 152, + .height = 91, + }, + .bus_format = MEDIA_BUS_FMT_RGB666_1X18, +}; + static const struct of_device_id platform_of_match[] = { { .compatible = "ampire,am800480r3tmqwa1h", @@ -1191,6 +1227,24 @@ static const struct of_device_id platform_of_match[] = { .compatible = "shelly,sca07010-bfn-lnn", .data = &shelly_sca07010_bfn_lnn, }, { + .compatible = "urt,umsh-8596md-t", + .data = &urt_umsh_8596md_parallel, + }, { + .compatible = "urt,umsh-8596md-1t", + .data = &urt_umsh_8596md_parallel, + }, { + .compatible = "urt,umsh-8596md-7t", + .data = &urt_umsh_8596md_parallel, + }, { + .compatible = "urt,umsh-8596md-11t", + .data = &urt_umsh_8596md_lvds, + }, { + .compatible = "urt,umsh-8596md-19t", + .data = &urt_umsh_8596md_lvds, + }, { + .compatible = "urt,umsh-8596md-20t", + .data = &urt_umsh_8596md_parallel, + }, { /* sentinel */ } };
On Wed, Oct 07, 2015 at 11:02:20PM +0200, Maciej S. Szmigiero wrote:
This patch implements support for United Radiant Technology UMSH-8596MD-xT 7.0" WVGA TFT LCD panels in DRM panel-simple driver.
Signed-off-by: Maciej Szmigiero mail@maciej.szmigiero.name
This replaces "drm: panel-simple: add URT UMSH-8596MD-xT panel support" submission.
drivers/gpu/drm/panel/panel-simple.c | 54 ++++++++++++++++++++++++++++++++++++ 1 file changed, 54 insertions(+)
Looks good to me. I'll wait for Rob or anyone else to ack the vendor prefix before merging this.
Thierry
On 08.10.2015 10:24, Thierry Reding wrote:
On Wed, Oct 07, 2015 at 11:02:20PM +0200, Maciej S. Szmigiero wrote:
This patch implements support for United Radiant Technology UMSH-8596MD-xT 7.0" WVGA TFT LCD panels in DRM panel-simple driver.
Signed-off-by: Maciej Szmigiero mail@maciej.szmigiero.name
This replaces "drm: panel-simple: add URT UMSH-8596MD-xT panel support" submission.
drivers/gpu/drm/panel/panel-simple.c | 54 ++++++++++++++++++++++++++++++++++++ 1 file changed, 54 insertions(+)
Looks good to me. I'll wait for Rob or anyone else to ack the vendor prefix before merging this.
Thierry
Is anybody there who can ack this prefix?
Maciej Szmigiero
Hi Thierry,
On 08.10.2015 10:24, Thierry Reding wrote:
On Wed, Oct 07, 2015 at 11:02:20PM +0200, Maciej S. Szmigiero wrote:
This patch implements support for United Radiant Technology UMSH-8596MD-xT 7.0" WVGA TFT LCD panels in DRM panel-simple driver.
Signed-off-by: Maciej Szmigiero mail@maciej.szmigiero.name
This replaces "drm: panel-simple: add URT UMSH-8596MD-xT panel support" submission.
drivers/gpu/drm/panel/panel-simple.c | 54 ++++++++++++++++++++++++++++++++++++ 1 file changed, 54 insertions(+)
Looks good to me. I'll wait for Rob or anyone else to ack the vendor prefix before merging this.
Now the vendor prefix has been acked, but because some files have moved since these patches were originally submitted I will update and resubmit them.
Thierry
Maciej
Add DT bindings for United Radiant Technology UMSH-8596MD-xT 7.0" WVGA TFT LCD panels.
Signed-off-by: Maciej S. Szmigiero mail@maciej.szmigiero.name --- This replaces "of: add URT UMSH-8596MD-xT panel DT bindings" submission.
.../bindings/display/panel/urt,umsh-8596md.txt | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/urt,umsh-8596md.txt
diff --git a/Documentation/devicetree/bindings/display/panel/urt,umsh-8596md.txt b/Documentation/devicetree/bindings/display/panel/urt,umsh-8596md.txt new file mode 100644 index 000000000000..088a6cea5015 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/urt,umsh-8596md.txt @@ -0,0 +1,16 @@ +United Radiant Technology UMSH-8596MD-xT 7.0" WVGA TFT LCD panel + +Supported are LVDS versions (-11T, -19T) and parallel ones +(-T, -1T, -7T, -20T). + +Required properties: +- compatible: should be one of: + "urt,umsh-8596md-t", + "urt,umsh-8596md-1t", + "urt,umsh-8596md-7t", + "urt,umsh-8596md-11t", + "urt,umsh-8596md-19t", + "urt,umsh-8596md-20t". + +This binding is compatible with the simple-panel binding, which is specified +in simple-panel.txt in this directory.
On Sat, Feb 13, 2016 at 10:50:24PM +0100, Maciej S. Szmigiero wrote:
Add DT bindings for United Radiant Technology UMSH-8596MD-xT 7.0" WVGA TFT LCD panels.
Signed-off-by: Maciej S. Szmigiero mail@maciej.szmigiero.name
This replaces "of: add URT UMSH-8596MD-xT panel DT bindings" submission.
.../bindings/display/panel/urt,umsh-8596md.txt | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/urt,umsh-8596md.txt
Acked-by: Rob Herring robh@kernel.org
On 22.02.2016 03:54, Rob Herring wrote:
On Sat, Feb 13, 2016 at 10:50:24PM +0100, Maciej S. Szmigiero wrote:
Add DT bindings for United Radiant Technology UMSH-8596MD-xT 7.0" WVGA TFT LCD panels.
Signed-off-by: Maciej S. Szmigiero mail@maciej.szmigiero.name
This replaces "of: add URT UMSH-8596MD-xT panel DT bindings" submission.
.../bindings/display/panel/urt,umsh-8596md.txt | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/urt,umsh-8596md.txt
Acked-by: Rob Herring robh@kernel.org
@Thierry: now that both vendor prefix and DT bindings have been acked can this panel support be merged?
Maciej
On Sat, Feb 13, 2016 at 10:50:24PM +0100, Maciej S. Szmigiero wrote:
Add DT bindings for United Radiant Technology UMSH-8596MD-xT 7.0" WVGA TFT LCD panels.
Signed-off-by: Maciej S. Szmigiero mail@maciej.szmigiero.name
This replaces "of: add URT UMSH-8596MD-xT panel DT bindings" submission.
.../bindings/display/panel/urt,umsh-8596md.txt | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/urt,umsh-8596md.txt
Applied, thanks.
Thierry
Add support for United Radiant Technology UMSH-8596MD-xT 7.0" WVGA TFT LCD panels in DRM panel-simple driver.
Signed-off-by: Maciej S. Szmigiero mail@maciej.szmigiero.name --- This replaces "drm: panel-simple: implement URT UMSH-8596MD-xT panel support" submission.
drivers/gpu/drm/panel/panel-simple.c | 54 ++++++++++++++++++++++++++++++++++++ 1 file changed, 54 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index f88a631c43ab..6530c1ffca2c 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -1176,6 +1176,42 @@ static const struct panel_desc shelly_sca07010_bfn_lnn = { .bus_format = MEDIA_BUS_FMT_RGB666_1X18, };
+static const struct display_timing urt_umsh_8596md_timing = { + .pixelclock = { 33260000, 33260000, 33260000 }, + .hactive = { 800, 800, 800 }, + .hfront_porch = { 41, 41, 41 }, + .hback_porch = { 216 - 128, 216 - 128, 216 - 128 }, + .hsync_len = { 71, 128, 128 }, + .vactive = { 480, 480, 480 }, + .vfront_porch = { 10, 10, 10 }, + .vback_porch = { 35 - 2, 35 - 2, 35 - 2 }, + .vsync_len = { 2, 2, 2 }, + .flags = DISPLAY_FLAGS_DE_HIGH | DISPLAY_FLAGS_PIXDATA_NEGEDGE | + DISPLAY_FLAGS_HSYNC_LOW | DISPLAY_FLAGS_VSYNC_LOW, +}; + +static const struct panel_desc urt_umsh_8596md_lvds = { + .timings = &urt_umsh_8596md_timing, + .num_timings = 1, + .bpc = 6, + .size = { + .width = 152, + .height = 91, + }, + .bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG, +}; + +static const struct panel_desc urt_umsh_8596md_parallel = { + .timings = &urt_umsh_8596md_timing, + .num_timings = 1, + .bpc = 6, + .size = { + .width = 152, + .height = 91, + }, + .bus_format = MEDIA_BUS_FMT_RGB666_1X18, +}; + static const struct of_device_id platform_of_match[] = { { .compatible = "ampire,am800480r3tmqwa1h", @@ -1280,6 +1316,24 @@ static const struct of_device_id platform_of_match[] = { .compatible = "shelly,sca07010-bfn-lnn", .data = &shelly_sca07010_bfn_lnn, }, { + .compatible = "urt,umsh-8596md-t", + .data = &urt_umsh_8596md_parallel, + }, { + .compatible = "urt,umsh-8596md-1t", + .data = &urt_umsh_8596md_parallel, + }, { + .compatible = "urt,umsh-8596md-7t", + .data = &urt_umsh_8596md_parallel, + }, { + .compatible = "urt,umsh-8596md-11t", + .data = &urt_umsh_8596md_lvds, + }, { + .compatible = "urt,umsh-8596md-19t", + .data = &urt_umsh_8596md_lvds, + }, { + .compatible = "urt,umsh-8596md-20t", + .data = &urt_umsh_8596md_parallel, + }, { /* sentinel */ } };
On Sat, Feb 13, 2016 at 10:52:03PM +0100, Maciej S. Szmigiero wrote:
Add support for United Radiant Technology UMSH-8596MD-xT 7.0" WVGA TFT LCD panels in DRM panel-simple driver.
Signed-off-by: Maciej S. Szmigiero mail@maciej.szmigiero.name
This replaces "drm: panel-simple: implement URT UMSH-8596MD-xT panel support" submission.
drivers/gpu/drm/panel/panel-simple.c | 54 ++++++++++++++++++++++++++++++++++++ 1 file changed, 54 insertions(+)
Applied, thanks.
Thierry
dri-devel@lists.freedesktop.org