[Bug 91444] regression bisected radeonsi: don't change pipe_resource in resource_copy_region
https://bugs.freedesktop.org/show_bug.cgi?id=91444
Bug ID: 91444 Summary: regression bisected radeonsi: don't change pipe_resource in resource_copy_region Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/radeonsi Assignee: dri-devel@lists.freedesktop.org Reporter: shawn.starr@rogers.com QA Contact: dri-devel@lists.freedesktop.org
While playing ARK: Survival Evolved, I ran into image corruption and can reproduce it easy in game, it came down to this commit:
commit 46b2b3bda8d962fce02838e09c742ac06fbec45f Author: Marek Olšák marek.olsak@amd.com Date: Thu Jul 16 13:17:14 2015 +0200
radeonsi: don't change pipe_resource in resource_copy_region
Copied from r600g. pipe_resource can be shared by multiple threads, so we shouldn't change it.
Reviewed-by: Michel Dänzer michel.daenzer@amd.com
Reverting this fixed corruption seen, I've attached a picture of the corruption noticed, but it manifests itself in striped transparency of certain objects.
See attachment of image
https://bugs.freedesktop.org/show_bug.cgi?id=91444
--- Comment #1 from Shawn Starr shawn.starr@rogers.com --- Created attachment 117328 --> https://bugs.freedesktop.org/attachment.cgi?id=117328&action=edit ARK: Survival Evolved corruption
ARK: Survival Evolved corruption
https://bugs.freedesktop.org/show_bug.cgi?id=91444
Shawn Starr shawn.starr@rogers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #117328|0 |1 is obsolete| | Attachment #117328|text/plain |image/jpeg mime type| |
https://bugs.freedesktop.org/show_bug.cgi?id=91444
Shawn Starr shawn.starr@rogers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #117328|1 |0 is obsolete| |
https://bugs.freedesktop.org/show_bug.cgi?id=91444
--- Comment #2 from Shawn Starr shawn.starr@rogers.com --- This is for BONAIRE (Saturn XT [FirePro M6100])
https://bugs.freedesktop.org/show_bug.cgi?id=91444
--- Comment #3 from Marek Olšák maraeo@gmail.com --- Could you please create and attach (or send a link to) an apitrace reproducing the issue?
https://bugs.freedesktop.org/show_bug.cgi?id=91444
--- Comment #4 from Shawn Starr shawn.starr@rogers.com --- Here is the apitrace, decompress with XZ- https://drive.google.com/open?id=0Bze7CJKD12nOYkhrdlZERXBKMDA
https://bugs.freedesktop.org/show_bug.cgi?id=91444
--- Comment #5 from Shawn Starr shawn.starr@rogers.com --- http://www.sh0n.net/spstarr/radeon/player-stat-glyph-corrupt.png - Copy region OK http://www.sh0n.net/spstarr/radeon/player-stat-glyph-region-corrupt.png - Copy region corruption
There is glyph corruption but this pre-dates this issue and will be a separate bug report.
https://bugs.freedesktop.org/show_bug.cgi?id=91444
--- Comment #6 from Shawn Starr shawn.starr@rogers.com --- Marek's has fixed this in http://cgit.freedesktop.org/~mareko/mesa/commit/?id=21f4eb11d76d45c8b4099e0d...
This has been tested, works for me now.
https://bugs.freedesktop.org/show_bug.cgi?id=91444
Marek Olšák maraeo@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED
--- Comment #7 from Marek Olšák maraeo@gmail.com --- (In reply to Shawn Starr from comment #6)
Marek's has fixed this in http://cgit.freedesktop.org/~mareko/mesa/commit/ ?id=21f4eb11d76d45c8b4099e0df36d1263901c39a2
This has been tested, works for me now.
Closing.
dri-devel@lists.freedesktop.org
-
bugzilla-daemon＠freedesktop.org