zhengbin (2): drm/amd/powerplay: remove set but not used variable 'vbios_version','data' drm/amd/powerplay: remove set but not used variable 'data'
drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 4 ---- drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 2 -- 2 files changed, 6 deletions(-)
-- 2.7.4
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c: In function smu7_check_mc_firmware: drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c:4215:11: warning: variable vbios_version set but not used [-Wunused-but-set-variable] drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c: In function smu7_get_performance_level: drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c:5054:21: warning: variable data set but not used [-Wunused-but-set-variable]
'vbios_version' is introduced by commit 599a7e9fe1b6 ("drm/amd/powerplay: implement smu7 hwmgr to manager asics with smu ip version 7."), but never used, so remove it.
'data' is introduced by commit f688b614b643 ("drm/amd/pp: Implement get_performance_level for legacy dgpu"), but never used, so remove it.
Reported-by: Hulk Robot hulkci@huawei.com Signed-off-by: zhengbin zhengbin13@huawei.com --- drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 4 ---- 1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c index c805c6f..775366a 100644 --- a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c @@ -4218,7 +4218,6 @@ static int smu7_check_mc_firmware(struct pp_hwmgr *hwmgr) { struct smu7_hwmgr *data = (struct smu7_hwmgr *)(hwmgr->backend);
- uint32_t vbios_version; uint32_t tmp;
/* Read MC indirect register offset 0x9F bits [3:0] to see @@ -4227,7 +4226,6 @@ static int smu7_check_mc_firmware(struct pp_hwmgr *hwmgr) */
smu7_get_mc_microcode_version(hwmgr); - vbios_version = hwmgr->microcode_version_info.MC & 0xf;
data->need_long_memory_training = false;
@@ -5057,13 +5055,11 @@ static int smu7_get_performance_level(struct pp_hwmgr *hwmgr, const struct pp_hw PHM_PerformanceLevel *level) { const struct smu7_power_state *ps; - struct smu7_hwmgr *data; uint32_t i;
if (level == NULL || hwmgr == NULL || state == NULL) return -EINVAL;
- data = hwmgr->backend; ps = cast_const_phw_smu7_power_state(state);
i = index > ps->performance_level_count - 1 ? -- 2.7.4
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c: In function vega10_get_performance_level: drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c:5217:23: warning: variable data set but not used [-Wunused-but-set-variable]
'data' is introduced by commit f688b614b643 ("drm/amd/pp: Implement get_performance_level for legacy dgpu"), but never used, so remove it.
Reported-by: Hulk Robot hulkci@huawei.com Signed-off-by: zhengbin zhengbin13@huawei.com --- drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 2 -- 1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c index a4a7f85..776e632 100644 --- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c @@ -5252,13 +5252,11 @@ static int vega10_get_performance_level(struct pp_hwmgr *hwmgr, const struct pp_ PHM_PerformanceLevel *level) { const struct vega10_power_state *ps; - struct vega10_hwmgr *data; uint32_t i;
if (level == NULL || hwmgr == NULL || state == NULL) return -EINVAL;
- data = hwmgr->backend; ps = cast_const_phw_vega10_power_state(state);
i = index > ps->performance_level_count - 1 ? -- 2.7.4
Series is reviewed-by: Evan Quan evan.quan@amd.com
-----Original Message----- From: zhengbin zhengbin13@huawei.com Sent: Monday, November 11, 2019 11:46 AM To: rex.zhu@amd.com; Quan, Evan Evan.Quan@amd.com; Deucher, Alexander Alexander.Deucher@amd.com; Koenig, Christian Christian.Koenig@amd.com; Zhou, David(ChunMing) David1.Zhou@amd.com; airlied@linux.ie; daniel@ffwll.ch; amd- gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org Cc: zhengbin13@huawei.com Subject: [PATCH 0/2] remove some set but not used variables in hwmgr
zhengbin (2): drm/amd/powerplay: remove set but not used variable 'vbios_version','data' drm/amd/powerplay: remove set but not used variable 'data'
drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 4 ---- drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 2 -- 2 files changed, 6 deletions(-)
-- 2.7.4
Applied. Thanks!
Alex
On Sun, Nov 10, 2019 at 11:04 PM Quan, Evan Evan.Quan@amd.com wrote:
Series is reviewed-by: Evan Quan evan.quan@amd.com
-----Original Message----- From: zhengbin zhengbin13@huawei.com Sent: Monday, November 11, 2019 11:46 AM To: rex.zhu@amd.com; Quan, Evan Evan.Quan@amd.com; Deucher, Alexander Alexander.Deucher@amd.com; Koenig, Christian Christian.Koenig@amd.com; Zhou, David(ChunMing) David1.Zhou@amd.com; airlied@linux.ie; daniel@ffwll.ch; amd- gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org Cc: zhengbin13@huawei.com Subject: [PATCH 0/2] remove some set but not used variables in hwmgr
zhengbin (2): drm/amd/powerplay: remove set but not used variable 'vbios_version','data' drm/amd/powerplay: remove set but not used variable 'data'
drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 4 ---- drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 2 -- 2 files changed, 6 deletions(-)
-- 2.7.4
dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
dri-devel@lists.freedesktop.org