From: Xinlei Lee xinlei.lee@mediatek.com
Base on Linux-next
change since v1: 1. Put switch dpi Topckgen MUX action in mt8186.dtsi.
Xinlei Lee (2): dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8186 drm/mediatek: Add mt8186 dpi compatible to mtk_dpi.c
.../bindings/display/mediatek/mediatek,dpi.yaml | 1 + drivers/gpu/drm/mediatek/mtk_dpi.c | 11 +++++++++++ 2 files changed, 12 insertions(+)
From: Xinlei Lee xinlei.lee@mediatek.com
Add dt-binding documentation of dpi for MediaTek MT8186 SoC.
Signed-off-by: Xinlei Lee xinlei.lee@mediatek.com --- .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 1 + 1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml index dd2896a40ff0..a73044c50b5f 100644 --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml @@ -22,6 +22,7 @@ properties: - mediatek,mt7623-dpi - mediatek,mt8173-dpi - mediatek,mt8183-dpi + - mediatek,mt8186-dpi - mediatek,mt8192-dpi
reg:
On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@mediatek.com wrote:
From: Xinlei Lee xinlei.lee@mediatek.com
Add dt-binding documentation of dpi for MediaTek MT8186 SoC.
Signed-off-by: Xinlei Lee xinlei.lee@mediatek.com
.../devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 1
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam l b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam l index dd2896a40ff0..a73044c50b5f 100644
a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam l +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam l @@ -22,6 +22,7 @@ properties: - mediatek,mt7623-dpi - mediatek,mt8173-dpi - mediatek,mt8183-dpi
- mediatek,mt8186-dpi - mediatek,mt8192-dpireg:
Hello Xinlei,
From the dts we use, the dpi node needs other properties for MT8186.
Please send another patch and add these properties to binding.
assigned-clocks = <&topckgen CLK_TOP_DPI>; assigned-clock-parents = <&topckgen CLK_TOP_TVDPLL_D2>;
Thanks
BRs, Rex
Hi,
On Fri, 2022-04-01 at 09:38 +0800, Rex-BC Chen wrote:
On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@mediatek.com wrote:
From: Xinlei Lee xinlei.lee@mediatek.com
Add dt-binding documentation of dpi for MediaTek MT8186 SoC.
Signed-off-by: Xinlei Lee xinlei.lee@mediatek.com
.../devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 1
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.y am l b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.y am l index dd2896a40ff0..a73044c50b5f 100644
a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.y am l +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.y am l @@ -22,6 +22,7 @@ properties: - mediatek,mt7623-dpi - mediatek,mt8173-dpi - mediatek,mt8183-dpi
- mediatek,mt8186-dpi - mediatek,mt8192-dpireg:
Hello Xinlei,
From the dts we use, the dpi node needs other properties for MT8186. Please send another patch and add these properties to binding.
assigned-clocks = <&topckgen CLK_TOP_DPI>; assigned-clock-parents = <&topckgen CLK_TOP_TVDPLL_D2>;
According to [1], the assigned-clocks is initial value. Without this initial value, I think driver would set this clock again, wouldn't it?
[1] https://www.kernel.org/doc/Documentation/devicetree/bindings/clock/clock-bin...
Regards, CK
Thanks
BRs, Rex
Linux-mediatek mailing list Linux-mediatek@lists.infradead.org
https://urldefense.com/v3/__http://lists.infradead.org/mailman/listinfo/linu...
On Wed, 2022-04-06 at 14:38 +0800, CK Hu wrote:
Hi,
On Fri, 2022-04-01 at 09:38 +0800, Rex-BC Chen wrote:
On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@mediatek.com wrote:
From: Xinlei Lee xinlei.lee@mediatek.com
Add dt-binding documentation of dpi for MediaTek MT8186 SoC.
Signed-off-by: Xinlei Lee xinlei.lee@mediatek.com
.../devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 1
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi .y am l b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi .y am l index dd2896a40ff0..a73044c50b5f 100644
a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi .y am l +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi .y am l @@ -22,6 +22,7 @@ properties: - mediatek,mt7623-dpi - mediatek,mt8173-dpi - mediatek,mt8183-dpi
- mediatek,mt8186-dpi - mediatek,mt8192-dpireg:
Hello Xinlei,
From the dts we use, the dpi node needs other properties for MT8186. Please send another patch and add these properties to binding.
assigned-clocks = <&topckgen CLK_TOP_DPI>; assigned-clock-parents = <&topckgen CLK_TOP_TVDPLL_D2>;
According to [1], the assigned-clocks is initial value. Without this initial value, I think driver would set this clock again, wouldn't it?
[1]
https://www.kernel.org/doc/Documentation/devicetree/bindings/clock/clock-bin...
Regards, CK
Hello CK,
OK, Thanks for your explanation.
Reviewed-by: Rex-BC Chen rex-bc.chen@mediatek.com
BRs, Rex
Thanks
BRs, Rex
Linux-mediatek mailing list Linux-mediatek@lists.infradead.org
https://urldefense.com/v3/__http://lists.infradead.org/mailman/listinfo/linu...
On Fri, Apr 01, 2022 at 09:38:20AM +0800, Rex-BC Chen wrote:
On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@mediatek.com wrote:
From: Xinlei Lee xinlei.lee@mediatek.com
Add dt-binding documentation of dpi for MediaTek MT8186 SoC.
Signed-off-by: Xinlei Lee xinlei.lee@mediatek.com
.../devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 1
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam l b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam l index dd2896a40ff0..a73044c50b5f 100644
a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam l +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam l @@ -22,6 +22,7 @@ properties: - mediatek,mt7623-dpi - mediatek,mt8173-dpi - mediatek,mt8183-dpi
- mediatek,mt8186-dpi - mediatek,mt8192-dpireg:
Hello Xinlei,
From the dts we use, the dpi node needs other properties for MT8186. Please send another patch and add these properties to binding.
assigned-clocks = <&topckgen CLK_TOP_DPI>; assigned-clock-parents = <&topckgen CLK_TOP_TVDPLL_D2>;
Those are always allowed on any node with 'clocks', so no need to add them here.
Rob
On Wed, 2022-04-06 at 10:15 -0500, Rob Herring wrote:
On Fri, Apr 01, 2022 at 09:38:20AM +0800, Rex-BC Chen wrote:
On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@mediatek.com wrote:
From: Xinlei Lee xinlei.lee@mediatek.com
Add dt-binding documentation of dpi for MediaTek MT8186 SoC.
Signed-off-by: Xinlei Lee xinlei.lee@mediatek.com
.../devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 1
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi .yam l b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi .yam l index dd2896a40ff0..a73044c50b5f 100644
a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi .yam l +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi .yam l @@ -22,6 +22,7 @@ properties: - mediatek,mt7623-dpi - mediatek,mt8173-dpi - mediatek,mt8183-dpi
- mediatek,mt8186-dpi - mediatek,mt8192-dpireg:
Hello Xinlei,
From the dts we use, the dpi node needs other properties for MT8186. Please send another patch and add these properties to binding.
assigned-clocks = <&topckgen CLK_TOP_DPI>; assigned-clock-parents = <&topckgen CLK_TOP_TVDPLL_D2>;
Those are always allowed on any node with 'clocks', so no need to add them here.
Rob
Hi Rob:
Thank you for your review. I understand your suggestion, and the next version will be sent soon.
Best Regards! xinlei
On Thu, 31 Mar 2022 19:58:36 +0800, xinlei.lee@mediatek.com wrote:
From: Xinlei Lee xinlei.lee@mediatek.com
Add dt-binding documentation of dpi for MediaTek MT8186 SoC.
Signed-off-by: Xinlei Lee xinlei.lee@mediatek.com
.../devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 1 + 1 file changed, 1 insertion(+)
Acked-by: Rob Herring robh@kernel.org
From: Xinlei Lee xinlei.lee@mediatek.com
Add the compatible because use different .data in mt8186.
Signed-off-by: Xinlei Lee xinlei.lee@mediatek.com --- drivers/gpu/drm/mediatek/mtk_dpi.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c index 4554e2de1430..6fac146cf1fb 100644 --- a/drivers/gpu/drm/mediatek/mtk_dpi.c +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c @@ -823,6 +823,14 @@ static const struct mtk_dpi_conf mt8192_conf = { .num_output_fmts = ARRAY_SIZE(mt8173_output_fmts), };
+static const struct mtk_dpi_conf mt8186_conf = { + .cal_factor = mt8183_calculate_factor, + .reg_h_fre_con = 0xe0, + .max_clock_khz = 150000, + .output_fmts = mt8183_output_fmts, + .num_output_fmts = ARRAY_SIZE(mt8183_output_fmts), +}; + static int mtk_dpi_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; @@ -945,6 +953,9 @@ static const struct of_device_id mtk_dpi_of_ids[] = { { .compatible = "mediatek,mt8192-dpi", .data = &mt8192_conf, }, + { .compatible = "mediatek,mt8186-dpi", + .data = &mt8186_conf, + }, { }, }; MODULE_DEVICE_TABLE(of, mtk_dpi_of_ids);
On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@mediatek.com wrote:
From: Xinlei Lee xinlei.lee@mediatek.com
Add the compatible because use different .data in mt8186.
Signed-off-by: Xinlei Lee xinlei.lee@mediatek.com
drivers/gpu/drm/mediatek/mtk_dpi.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c index 4554e2de1430..6fac146cf1fb 100644 --- a/drivers/gpu/drm/mediatek/mtk_dpi.c +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c @@ -823,6 +823,14 @@ static const struct mtk_dpi_conf mt8192_conf = { .num_output_fmts = ARRAY_SIZE(mt8173_output_fmts), };
+static const struct mtk_dpi_conf mt8186_conf = {
- .cal_factor = mt8183_calculate_factor,
- .reg_h_fre_con = 0xe0,
- .max_clock_khz = 150000,
- .output_fmts = mt8183_output_fmts,
- .num_output_fmts = ARRAY_SIZE(mt8183_output_fmts),
+};
Hello Xinlei,
Could you move 8186 between 8183 and 8192?
static int mtk_dpi_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; @@ -945,6 +953,9 @@ static const struct of_device_id mtk_dpi_of_ids[] = { { .compatible = "mediatek,mt8192-dpi", .data = &mt8192_conf, },
- { .compatible = "mediatek,mt8186-dpi",
.data = &mt8186_conf,- },
ditto
BRs, Rex
{ }, }; MODULE_DEVICE_TABLE(of, mtk_dpi_of_ids);
On Wed, 2022-04-06 at 15:13 +0800, Rex-BC Chen wrote:
On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@mediatek.com wrote:
From: Xinlei Lee xinlei.lee@mediatek.com
Add the compatible because use different .data in mt8186.
Signed-off-by: Xinlei Lee xinlei.lee@mediatek.com
drivers/gpu/drm/mediatek/mtk_dpi.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c index 4554e2de1430..6fac146cf1fb 100644 --- a/drivers/gpu/drm/mediatek/mtk_dpi.c +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c @@ -823,6 +823,14 @@ static const struct mtk_dpi_conf mt8192_conf = { .num_output_fmts = ARRAY_SIZE(mt8173_output_fmts), };
+static const struct mtk_dpi_conf mt8186_conf = {
- .cal_factor = mt8183_calculate_factor,
- .reg_h_fre_con = 0xe0,
- .max_clock_khz = 150000,
- .output_fmts = mt8183_output_fmts,
- .num_output_fmts = ARRAY_SIZE(mt8183_output_fmts),
+};
Hello Xinlei,
Could you move 8186 between 8183 and 8192?
static int mtk_dpi_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; @@ -945,6 +953,9 @@ static const struct of_device_id mtk_dpi_of_ids[] = { { .compatible = "mediatek,mt8192-dpi", .data = &mt8192_conf, },
- { .compatible = "mediatek,mt8186-dpi",
.data = &mt8186_conf,- },
ditto
BRs, Rex
{ }, }; MODULE_DEVICE_TABLE(of, mtk_dpi_of_ids);
Hi Rex:
Thanks for your review. I will put it between 8183 & 8192 in the next version. In addition, I will add two properties assigned-clocks & assigned- clock-parents to dtbing.
Best Regards! xinlei
dri-devel@lists.freedesktop.org
-
CK Hu -
Rex-BC Chen -
Rob Herring -
xinlei.lee -
xinlei.lee＠mediatek.com