On 3/8/22 21:23, Colin Ian King wrote:

Don't populate the read-only array ODValues on the stack but instead make it static const. Also makes the object code a little smaller.

Signed-off-by: Colin Ian King colin.i.king@gmail.com

---

drivers/video/fbdev/kyro/STG4000InitDevice.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/kyro/STG4000InitDevice.c b/drivers/video/fbdev/kyro/STG4000InitDevice.c index 21875d3c2dc2..ffeb355c8b50 100644 --- a/drivers/video/fbdev/kyro/STG4000InitDevice.c +++ b/drivers/video/fbdev/kyro/STG4000InitDevice.c @@ -124,7 +124,7 @@ u32 ProgramClock(u32 refClock, u32 ulScore, ulPhaseScore, ulVcoScore; u32 ulTmp = 0, ulVCO; u32 ulScaleClockReq, ulMinClock, ulMaxClock;

• u32 ODValues[] = { 1, 2, 0 };

• static const u32 ODValues[] = { 1, 2, 0 };

applied, but I made this: static const unsigned char

Thanks! Helge

/* Translate clock in Hz */ coreClock *= 100; /* in Hz */