https://bugs.freedesktop.org/show_bug.cgi?id=31667
Summary: r600c and r600g: wrong rendering for Savage2 game Product: Mesa Version: git Platform: Other OS/Version: All Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/r600 AssignedTo: dri-devel@lists.freedesktop.org ReportedBy: edwintorok@gmail.com
Created an attachment (id=40311) --> (https://bugs.freedesktop.org/attachment.cgi?id=40311) r600g_bad_transp_lines.jpg
Savage2 is a free to play (but not opensource) game with native Linux clients, it renders correctly with llvmpipe and fglrx. It doesn't render correctly with r600c and r600g. Using latest git version (commit 063c6b8f74d114241f663ef8fd93732a0a07c10f).
llvmpipe that works (sort of, its very very slow): $ LD_LIBRARY_PATH=$HOME/mesa/lib/gallium glxinfo | grep OpenGL OpenGL vendor string: VMware, Inc. OpenGL renderer string: Gallium 0.4 on llvmpipe OpenGL version string: 2.1 Mesa 7.10-devel OpenGL shading language version string: 1.20 OpenGL extensions:
r600c has part of the screen black (see attached screenshot r600c_bad_partblack.jpg), but the menu is good (r600c_menu_good.jpg): $ glxinfo|grep OpenGL OpenGL vendor string: Advanced Micro Devices, Inc. OpenGL renderer string: Mesa DRI R600 (RV730 9498) 20090101 TCL DRI2 OpenGL version string: 2.1 Mesa 7.10-devel OpenGL shading language version string: 1.20 OpenGL extensions:
r600g doesn't have the blackness bug, but the main character is missing/totally transparent you just see some swords running around (r600g_bad_transp_lines.jpg), and it has some thin black horizontal lines all over the screen. The menu also has the thin black horizontal lines (r600g_bad_menu_lines.jpg). LIBGL_DRIVERS_PATH=$HOME/mesa/lib/gallium glxinfo|grep OpenGL OpenGL vendor string: X.Org OpenGL renderer string: Gallium 0.4 on AMD RV730 OpenGL version string: 2.1 Mesa 7.10-devel OpenGL shading language version string: 1.20 OpenGL extensions:
The video card is: 01:00.0 VGA compatible controller: ATI Technologies Inc RV730 PRO [Radeon HD 4650]
https://bugs.freedesktop.org/show_bug.cgi?id=31667
--- Comment #1 from Török Edwin edwintorok@gmail.com 2010-11-16 09:19:58 PST --- Created an attachment (id=40312) --> (https://bugs.freedesktop.org/attachment.cgi?id=40312) r600g_bad_menu_lines.jpg
https://bugs.freedesktop.org/show_bug.cgi?id=31667
--- Comment #2 from Török Edwin edwintorok@gmail.com 2010-11-16 09:20:16 PST --- Created an attachment (id=40313) --> (https://bugs.freedesktop.org/attachment.cgi?id=40313) r600c_bad_partblack.jpg
https://bugs.freedesktop.org/show_bug.cgi?id=31667
--- Comment #3 from Török Edwin edwintorok@gmail.com 2010-11-16 09:20:32 PST --- Created an attachment (id=40314) --> (https://bugs.freedesktop.org/attachment.cgi?id=40314) r600c_menu_good.jpg
https://bugs.freedesktop.org/show_bug.cgi?id=31667
--- Comment #4 from Török Edwin edwintorok@gmail.com 2010-11-16 09:20:46 PST --- Created an attachment (id=40315) --> (https://bugs.freedesktop.org/attachment.cgi?id=40315) llvmpipe_ok.jpg
https://bugs.freedesktop.org/show_bug.cgi?id=31667
--- Comment #5 from Török Edwin edwintorok@gmail.com 2010-11-16 09:22:37 PST --- To reproduce bug: 1. Install Savage2 2. LIBGL_DRIVERS_PATH=$HOME/mesa/lib/gallium ./savage2.bin 3. Press "Practice" (that way you can play locally, and don't have to join multiplayer server etc.) 4. Wait till it loads, can take quite a while 5. When in the game you can take screenshot with F5 (they are saved in ~/.savage2/game/screenshots), as soon as you enter the game you can see the rendering errors.
If you need any more info please ask.
https://bugs.freedesktop.org/show_bug.cgi?id=31667
--- Comment #6 from Török Edwin edwintorok@gmail.com 2010-11-18 03:04:04 PST --- On mesa commit 185d862cd8cd0a56dd86daa01d9c692ff4abfb54 right now, and the horizontal black lines problem is fixed on r600g, the transparent character problem stays though.
https://bugs.freedesktop.org/show_bug.cgi?id=31667
--- Comment #7 from Török Edwin edwintorok@gmail.com 2010-11-18 10:28:10 PST --- The missing character is a similar symptom to that of this bug for r300g which got fixed: http://bugs.freedesktop.org/show_bug.cgi?id=28517
Do you need the RADEON_DEBUG=vp logs (or something else)?
https://bugs.freedesktop.org/show_bug.cgi?id=31667
--- Comment #8 from Alex Deucher agd5f@yahoo.com 2010-11-19 12:09:21 PST --- this is probably a dupe of bug 31613.
https://bugs.freedesktop.org/show_bug.cgi?id=31667
--- Comment #9 from Kevin DeKorte kdekorte@gmail.com 2010-12-06 07:55:16 PST --- Testing r600g from mesa git as of Dec 5, 2010 the menus look good, but the characters are still invisible on the main game screen and in the tutorial.
I'm using kernel 2.6.36.1 and libdrm 2.4.23
I tested secondlife and it works really good with this build. Sometimes frame rates over 50 on an 3650 card.
https://bugs.freedesktop.org/show_bug.cgi?id=31667
--- Comment #10 from Török Edwin edwintorok@gmail.com 2010-12-07 03:34:49 PST --- Also as soon as you start the game, the character on the menu screen is missing too with r600g (softpipe and llvmpipe is fine). Attached is the FRAG and VERT dumps (I uncommented the tgsi_dump in r600g).
https://bugs.freedesktop.org/show_bug.cgi?id=31667
--- Comment #11 from Török Edwin edwintorok@gmail.com 2010-12-07 03:35:08 PST --- Created an attachment (id=40867) --> (https://bugs.freedesktop.org/attachment.cgi?id=40867) vert_frag.log
https://bugs.freedesktop.org/show_bug.cgi?id=31667
--- Comment #12 from Tilman Sauerbeck tilman@code-monkey.de 2010-12-08 13:26:03 PST --- I wonder if bug 31771 might be the same problem as this one (on r600g at least). Maybe comparing shader dumps for sauerbraten to these ones might give a clue...?
https://bugs.freedesktop.org/show_bug.cgi?id=31667
--- Comment #13 from Kevin DeKorte kdekorte@yahoo.com 2010-12-08 13:43:23 PST --- When I put Savage2 in the Low resolution mode, I get a lot of funky red triangles on the main screen (where the big red demon should be). Made me wonder if the coordinates or normals were being interpreted incorrectly for the demon model. Everything else on the screen looks right however.
https://bugs.freedesktop.org/show_bug.cgi?id=31667
--- Comment #14 from Kevin DeKorte kdekorte@yahoo.com 2011-01-04 14:53:14 PST --- http://paste.pocoo.org/raw/314893/ seems to help, makes more of the character visible, but head of character is still missing...
https://bugs.freedesktop.org/show_bug.cgi?id=31667
--- Comment #15 from Kevin DeKorte kdekorte@yahoo.com 2011-01-04 14:53:58 PST --- Created an attachment (id=41652) --> (https://bugs.freedesktop.org/attachment.cgi?id=41652) Savage2 with that patch at http://paste.pocoo.org/raw/314893/ applied
https://bugs.freedesktop.org/show_bug.cgi?id=31667
--- Comment #16 from Kevin DeKorte kdekorte@yahoo.com 2011-01-04 15:42:34 PST --- I'm going to attach the patch here, just so it doesn't get lost.
It also appears as if the suit of armor is rotated clockwise on the Z? axis 90 degrees. I believe you should almost always see the back of the armor.
https://bugs.freedesktop.org/show_bug.cgi?id=31667
--- Comment #17 from Kevin DeKorte kdekorte@yahoo.com 2011-01-04 15:43:13 PST --- Created an attachment (id=41655) View: https://bugs.freedesktop.org/attachment.cgi?id=41655 Review: https://bugs.freedesktop.org/review?bug=31667&attachment=41655
Patch that improves Savage2, but doesn't quite fix it.
https://bugs.freedesktop.org/show_bug.cgi?id=31667
--- Comment #18 from Henri Verbeet hverbeet@gmail.com 2011-01-05 00:46:19 PST --- Well, there are at least two things that are broken in current r600g. The first one is using constant buffer indices > 63, and the patch you tried should help there. The other thing that's broken is relative addressing of constant buffers. It happens to somewhat work as long as the resulting constant index falls within the kcache window, but in general it just doesn't work at all. All the "CONST[ADDR[0].x]" arguments in vert_frag.log are using relative addressing.
https://bugs.freedesktop.org/show_bug.cgi?id=31667
--- Comment #19 from Kevin DeKorte kdekorte@yahoo.com 2011-01-07 06:33:12 PST --- with mesa git db61b9ce39bccc43140357652ceb78baaf2aea44 Savage2 now crashes immediately. Believe it did not crash with e31defc825ee94f1d1092e277954abad7097c552
https://bugs.freedesktop.org/show_bug.cgi?id=31667
--- Comment #20 from Kevin DeKorte kdekorte@yahoo.com 2011-01-16 13:53:41 PST --- The crashing problems seem to be solved and I talked to Christian about this. It appears that relative shader addressing of constants still need to be fixed. Anyway, git of r600g is looking better. The menu in Savage nearly looks correct now.
https://bugs.freedesktop.org/show_bug.cgi?id=31667
--- Comment #21 from Henri Verbeet hverbeet@gmail.com 2011-02-06 07:26:27 PST --- Created an attachment (id=42992) View: https://bugs.freedesktop.org/attachment.cgi?id=42992 Review: https://bugs.freedesktop.org/review?bug=31667&attachment=42992
r600g_relative_addressing
Does this patch make it any better? It's still incomplete (most obviously it doesn't handle relative addressing for all instructions), but should already work for the common cases.
https://bugs.freedesktop.org/show_bug.cgi?id=31667
--- Comment #22 from Kevin DeKorte kdekorte@yahoo.com 2011-02-06 12:59:02 PST --- Henri,
Yes that patch does seem to help alot...
After that patch the only thing broken is shadows.
Please apply the relative_addressing or similar patch.
https://bugs.freedesktop.org/show_bug.cgi?id=31667
--- Comment #23 from Kevin DeKorte kdekorte@yahoo.com 2011-02-07 08:48:40 PST --- Appears the patch is merged in... I can disable shadows in the game and it looks really great... should I open a new bug on the shadows, or should we continue the issue here?
https://bugs.freedesktop.org/show_bug.cgi?id=31667
--- Comment #24 from Török Edwin edwintorok@gmail.com 2011-02-07 09:13:24 PST --- (In reply to comment #23)
Appears the patch is merged in... I can disable shadows in the game and it looks really great...
Confirmed, latest Mesa from git works just fine. Many thanks for fixing this.
should I open a new bug on the shadows, or should we continue the issue here?
I don't know, only thing I notice wrong with shadows is that they are very very slow.
https://bugs.freedesktop.org/show_bug.cgi?id=31667
Jerome Glisse glisse@freedesktop.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #25 from Jerome Glisse glisse@freedesktop.org 2012-02-22 10:04:33 PST --- Closing
https://bugs.freedesktop.org/show_bug.cgi?id=31667
romulasry@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- Assignee|dri-devel@lists.freedesktop |romulasry@gmail.com |.org |
--- Comment #26 from romulasry@gmail.com --- Created attachment 77965 --> https://bugs.freedesktop.org/attachment.cgi?id=77965&action=edit Top of screen *sky* renders white
Reopening due to rendering bug found with top of screen area. Please see attachment.
dri-devel@lists.freedesktop.org
-
bugzilla-daemon＠freedesktop.org