Signed-off-by: Lucas De Marchi lucas.demarchi@intel.com --- Android.common.mk | 1 + 1 file changed, 1 insertion(+)
diff --git a/Android.common.mk b/Android.common.mk index e3de1069..d0e5d559 100644 --- a/Android.common.mk +++ b/Android.common.mk @@ -2,6 +2,7 @@ LOCAL_CFLAGS += \ -DMAJOR_IN_SYSMACROS=1 \ -DHAVE_VISIBILITY=1 \ + -fvisibility=hidden \ -DHAVE_LIBDRM_ATOMIC_PRIMITIVES=1
LOCAL_CFLAGS += \
On Wednesday, 2018-09-19 23:05:48 -0700, Lucas De Marchi wrote:
Signed-off-by: Lucas De Marchi lucas.demarchi@intel.com
Reviewed-by: Eric Engestrom eric.engestrom@intel.com
But it'd be good to have a confirmation from Rob that it actually works: Cc: Rob Herring robh@kernel.org
Android.common.mk | 1 + 1 file changed, 1 insertion(+)
diff --git a/Android.common.mk b/Android.common.mk index e3de1069..d0e5d559 100644 --- a/Android.common.mk +++ b/Android.common.mk @@ -2,6 +2,7 @@ LOCAL_CFLAGS += \ -DMAJOR_IN_SYSMACROS=1 \ -DHAVE_VISIBILITY=1 \
- -fvisibility=hidden \ -DHAVE_LIBDRM_ATOMIC_PRIMITIVES=1
LOCAL_CFLAGS += \
2.17.1
On Thu, 20 Sep 2018 at 13:25, Eric Engestrom eric.engestrom@intel.com wrote:
On Wednesday, 2018-09-19 23:05:48 -0700, Lucas De Marchi wrote:
Signed-off-by: Lucas De Marchi lucas.demarchi@intel.com
Reviewed-by: Eric Engestrom eric.engestrom@intel.com
But it'd be good to have a confirmation from Rob that it actually works: Cc: Rob Herring robh@kernel.org
Yes it does. Older Androids can use GCC which is new enough. While latest ones exclusively use clang which also has the flag. Reviewed-by: Emil Velikov emil.velikov@collabora.com
Will push that in a moment. Emil
dri-devel@lists.freedesktop.org
-
Emil Velikov -
Eric Engestrom -
Lucas De Marchi