Hi David
Am 18.11.20 um 23:01 schrieb David Laight:
...
Did you try Daniel's suggestion of testing with the direct parent commit?
(I was on holiday yesterday and didn't want to spend a sunny afternoon doing bisects.)
I've just done that and it is bad.
Is there any way to bisect through the parts of the drm merge patch into v5.10-rc1 ?
That ought to be quicker (and less error prone) than the bisect builds I was doing.
Note that the stack 'splat' is due to a later change. It is separate from the broken pixel alignment.
I actually saw the vga text go 'funny' while the boot was outputting all the [OK] messages (from systemd?) before the graphic login stole tty1 (bloody stupid to use tty1).
I don't need to use the failing system today, I'll have another go at isolating the failure.
David
- Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)
Hi
Am 20.11.20 um 10:52 schrieb David Laight:
Hi David
Am 18.11.20 um 23:01 schrieb David Laight:
...
Did you try Daniel's suggestion of testing with the direct parent commit?
(I was on holiday yesterday and didn't want to spend a sunny afternoon doing bisects.)
Makes sense :)
I've just done that and it is bad.
Is there any way to bisect through the parts of the drm merge patch into v5.10-rc1 ?
That ought to be quicker (and less error prone) than the bisect builds I was doing.
Note that the stack 'splat' is due to a later change. It is separate from the broken pixel alignment.
I actually saw the vga text go 'funny' while the boot was outputting all the [OK] messages (from systemd?) before the graphic login stole tty1 (bloody stupid to use tty1).
I don't need to use the failing system today, I'll have another go at isolating the failure.
You can use drm-tip for testing, where many of the DRM patches go through.
https://cgit.freedesktop.org/drm/drm-tip/
It's fairly up-to-date.
I have two systems with AST chips and neither shows any of the symptoms you describe; nor do we have such reports about drivers that use a similar stack (hibmc, bochs). Could you provide the output of
dmesg | grep drm
Best regards Thomas
David
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)
From: Thomas Zimmermann
Sent: 20 November 2020 10:14
...
Is there any way to bisect through the parts of the drm merge patch into v5.10-rc1 ?
That ought to be quicker (and less error prone) than the bisect builds I was doing.
Note that the stack 'splat' is due to a later change. It is separate from the broken pixel alignment.
I actually saw the vga text go 'funny' while the boot was outputting all the [OK] messages (from systemd?) before the graphic login stole tty1 (bloody stupid to use tty1).
I don't need to use the failing system today, I'll have another go at isolating the failure.
You can use drm-tip for testing, where many of the DRM patches go through.
https://cgit.freedesktop.org/drm/drm-tip/
It's fairly up-to-date.
Any idea of tags either side of the 5.10 merge?
I have two systems with AST chips and neither shows any of the symptoms you describe; nor do we have such reports about drivers that use a similar stack (hibmc, bochs). Could you provide the output of
dmesg | grep drm
[ 2.112303] fb0: switching to astdrmfb from EFI VGA [ 2.120222] ast 0000:02:00.0: [drm] Using P2A bridge for configuration [ 2.120233] ast 0000:02:00.0: [drm] AST 2400 detected [ 2.120247] ast 0000:02:00.0: [drm] Analog VGA only [ 2.120257] ast 0000:02:00.0: [drm] dram MCLK=408 Mhz type=1 bus_width=16 [ 2.121121] [drm] Initialized ast 0.1.0 20120228 for 0000:02:00.0 on minor 0 [ 2.125838] fbcon: astdrmfb (fb0) is primary device [ 2.152179] ast 0000:02:00.0: [drm] fb0: astdrmfb frame buffer device [ 6.061034] systemd[1]: Condition check resulted in Load Kernel Module drm being skipped.
The output is the same for both good and bad kernels.
David
- Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)
Hi
Am 20.11.20 um 11:51 schrieb David Laight:
From: Thomas Zimmermann
Sent: 20 November 2020 10:14
...
Is there any way to bisect through the parts of the drm merge patch into v5.10-rc1 ?
That ought to be quicker (and less error prone) than the bisect builds I was doing.
Note that the stack 'splat' is due to a later change. It is separate from the broken pixel alignment.
I actually saw the vga text go 'funny' while the boot was outputting all the [OK] messages (from systemd?) before the graphic login stole tty1 (bloody stupid to use tty1).
I don't need to use the failing system today, I'll have another go at isolating the failure.
You can use drm-tip for testing, where many of the DRM patches go through.
https://cgit.freedesktop.org/drm/drm-tip/It's fairly up-to-date.
Any idea of tags either side of the 5.10 merge?
The final commit before v5.9 appears to be
Fixes: 33c8256b3bcc ("drm/amd/display: Change ABM config init interface")
I'd try this as a good commit. For the bad commit, just try HEAD.
Best regards Thomas
I have two systems with AST chips and neither shows any of the symptoms you describe; nor do we have such reports about drivers that use a similar stack (hibmc, bochs). Could you provide the output of
dmesg | grep drm[ 2.112303] fb0: switching to astdrmfb from EFI VGA [ 2.120222] ast 0000:02:00.0: [drm] Using P2A bridge for configuration [ 2.120233] ast 0000:02:00.0: [drm] AST 2400 detected [ 2.120247] ast 0000:02:00.0: [drm] Analog VGA only [ 2.120257] ast 0000:02:00.0: [drm] dram MCLK=408 Mhz type=1 bus_width=16 [ 2.121121] [drm] Initialized ast 0.1.0 20120228 for 0000:02:00.0 on minor 0 [ 2.125838] fbcon: astdrmfb (fb0) is primary device [ 2.152179] ast 0000:02:00.0: [drm] fb0: astdrmfb frame buffer device [ 6.061034] systemd[1]: Condition check resulted in Load Kernel Module drm being skipped.
The output is the same for both good and bad kernels.
David
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)
From: Thomas Zimmermann
Sent: 20 November 2020 11:27
...
You can use drm-tip for testing, where many of the DRM patches go through.
https://cgit.freedesktop.org/drm/drm-tip/It's fairly up-to-date.
Any idea of tags either side of the 5.10 merge?
The final commit before v5.9 appears to be
Fixes: 33c8256b3bcc ("drm/amd/display: Change ABM config init interface")
I'd try this as a good commit. For the bad commit, just try HEAD.
HEAD off that tree works. Colours ok and no stack backtrace.
Ideas??
David
- Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)
Hi
Am 20.11.20 um 12:45 schrieb David Laight:
From: Thomas Zimmermann
Sent: 20 November 2020 11:27
...
You can use drm-tip for testing, where many of the DRM patches go through.
https://cgit.freedesktop.org/drm/drm-tip/It's fairly up-to-date.
Any idea of tags either side of the 5.10 merge?
The final commit before v5.9 appears to be
Fixes: 33c8256b3bcc ("drm/amd/display: Change ABM config init interface")I'd try this as a good commit. For the bad commit, just try HEAD.
HEAD off that tree works. Colours ok and no stack backtrace.
Ideas??
The good news is that it's been fixed. All you have to do is wait for the fix to hit upstream.
Did you try the patch that Dave linked? If not, go back to v5.10-rc4 and do
git am <path to attached file>
The patch is attached. Please report back if this fixes the issue.
Best regards Thomas
David
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)
From: Thomas Zimmermann
Sent: 20 November 2020 12:30
Am 20.11.20 um 12:45 schrieb David Laight:
From: Thomas Zimmermann
Sent: 20 November 2020 11:27
...
You can use drm-tip for testing, where many of the DRM patches go through.
https://cgit.freedesktop.org/drm/drm-tip/It's fairly up-to-date.
Any idea of tags either side of the 5.10 merge?
The final commit before v5.9 appears to be
Fixes: 33c8256b3bcc ("drm/amd/display: Change ABM config init interface")I'd try this as a good commit. For the bad commit, just try HEAD.
HEAD off that tree works. Colours ok and no stack backtrace.
Ideas??
The good news is that it's been fixed. All you have to do is wait for the fix to hit upstream.
Did you try the patch that Dave linked?
That patch makes no difference to my system. The condition is false so it doesn't corrupt the flags. (I printed the values to see.)
David
- Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)
Hi
Am 20.11.20 um 13:53 schrieb David Laight:
From: Thomas Zimmermann
Sent: 20 November 2020 12:30
Am 20.11.20 um 12:45 schrieb David Laight:
From: Thomas Zimmermann
Sent: 20 November 2020 11:27
...
You can use drm-tip for testing, where many of the DRM patches go through.
https://cgit.freedesktop.org/drm/drm-tip/It's fairly up-to-date.
Any idea of tags either side of the 5.10 merge?
The final commit before v5.9 appears to be
Fixes: 33c8256b3bcc ("drm/amd/display: Change ABM config init interface")I'd try this as a good commit. For the bad commit, just try HEAD.
HEAD off that tree works. Colours ok and no stack backtrace.
Ideas??
The good news is that it's been fixed. All you have to do is wait for the fix to hit upstream.
Did you try the patch that Dave linked?
That patch makes no difference to my system. The condition is false so it doesn't corrupt the flags. (I printed the values to see.)
I see, so it's probably something else that has been fixed in drm-tip. It's likely that at least one commit in drm-tip is also broken. I'd try to find one of these. One idea is to go through the commits that went into the related files. Maybe go back to the HEAD of drm-tip and try something like
git log --oneline -- drivers/gpu/drm/ast/ drivers/gpu/drm/drm_gem_vram_helper.c drivers/gpu/drm/ttm/
That lists recent ast and memory-management commits. One of them might be broken and can serve an a starting point for a bisect.
I did a diff from v5.10-rc4 to drm-tip to look for suspicious changes. Some candidates are
8e3784dfef8a ("drm/ast: Reload gamma LUT after changing primary plane's color format") 2b8283ff1a60 ("drm/vram_helper: implement a ttm move callback.") 6a6e5988a265 ("drm/ttm: replace last move_notify with delete_mem_notify")
I'd test them against their parent commits to see if anything changes.
Thanks for all your efforts!
Best regards Thomas
David
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)
From: Thomas Zimmermann
Sent: 20 November 2020 13:42
...
I did a diff from v5.10-rc4 to drm-tip to look for suspicious changes. Some candidates are
8e3784dfef8a ("drm/ast: Reload gamma LUT after changing primary plane's color format")
Ok, that one fixes the screen colours (etc). So 8e3784dfef8a was good and then HEAD^ was bad.
I might try to bisect the breakage.
The stack splat is entirely different. I'll try to bisect that on Linus's tree.
David
- Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)
From: David Laight
Sent: 20 November 2020 15:39
From: Thomas Zimmermann
Sent: 20 November 2020 13:42
...
I did a diff from v5.10-rc4 to drm-tip to look for suspicious changes. Some candidates are
8e3784dfef8a ("drm/ast: Reload gamma LUT after changing primary plane's color format")
Ok, that one fixes the screen colours (etc). So 8e3784dfef8a was good and then HEAD^ was bad.
I might try to bisect the breakage.
The stack splat is entirely different. I'll try to bisect that on Linus's tree.
The good news is I'm not getting the stack splat on rc5. I'm not sure I can be bothered to find out when :-)
Applying 8e3784dfef8a to rc5 by hand also fixes the display colours.
David
- Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)
Hi
Am 24.11.20 um 17:27 schrieb David Laight:
From: David Laight
Sent: 20 November 2020 15:39
From: Thomas Zimmermann
Sent: 20 November 2020 13:42
...
I did a diff from v5.10-rc4 to drm-tip to look for suspicious changes. Some candidates are
8e3784dfef8a ("drm/ast: Reload gamma LUT after changing primaryplane's color format")
Ok, that one fixes the screen colours (etc). So 8e3784dfef8a was good and then HEAD^ was bad.
I might try to bisect the breakage.
The stack splat is entirely different. I'll try to bisect that on Linus's tree.
The good news is I'm not getting the stack splat on rc5. I'm not sure I can be bothered to find out when :-)
Applying 8e3784dfef8a to rc5 by hand also fixes the display colours.
Sounds good. I'm counting this as solved then. Thanks for putting all this work into it.
Best regards Thomas
David
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)
Hi
Am 24.11.20 um 17:27 schrieb David Laight:
From: David Laight
Sent: 20 November 2020 15:39
From: Thomas Zimmermann
Sent: 20 November 2020 13:42
...
I did a diff from v5.10-rc4 to drm-tip to look for suspicious changes. Some candidates are
8e3784dfef8a ("drm/ast: Reload gamma LUT after changing primaryplane's color format")
Ok, that one fixes the screen colours (etc). So 8e3784dfef8a was good and then HEAD^ was bad.
I might try to bisect the breakage.
The stack splat is entirely different. I'll try to bisect that on Linus's tree.
The good news is I'm not getting the stack splat on rc5. I'm not sure I can be bothered to find out when :-)
Applying 8e3784dfef8a to rc5 by hand also fixes the display colours.
I've added this commit to drm-misc-fixes and it should show up in the upstream kernel soonish.
Best regards Thomas
David
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales) _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
dri-devel@lists.freedesktop.org
-
David Laight -
Thomas Zimmermann